From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sai Prakash Ranjan Subject: Re: [PATCH 2/6] pstore: Add event tracing support Date: Sun, 23 Sep 2018 21:03:04 +0530 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Joel Fernandes Cc: Steven Rostedt , Ingo Molnar , Laura Abbott , Kees Cook , Anton Vorontsov , Rob Herring , devicetree@vger.kernel.org, Colin Cross , Jason Baron , Tony Luck , Arnd Bergmann , Catalin Marinas , Will Deacon , Masami Hiramatsu , Joe Perches , Jim Cromie , Rajendra Nayak , Vivek Gautam , Sibi Sankar , linux-arm-kernel@lists.infradead.org, LKML List-Id: devicetree@vger.kernel.org On 9/22/2018 10:07 PM, Sai Prakash Ranjan wrote: > On 9/22/2018 2:35 PM, Joel Fernandes wrote: >> On Sat, Sep 8, 2018 at 4:28 PM Sai Prakash Ranjan >> wrote: >>> >>> + >>> +       trace_seq_init(&iter->seq); >>> +       iter->ent = fbuffer->entry; >>> +       event_call->event.funcs->trace(iter, 0, event); >>> +       trace_seq_putc(&iter->seq, 0); >> >> Would it be possible to store the binary trace record in the pstore >> buffer instead of outputting text? I suspect that will both be faster >> and less space. >> > > I will try this and come back. > Hi Joel, I removed trace_seq_putc and there is some improvement seen: 203 MB/s # dd if=/dev/zero of=/dev/null status=progress 12207371264 bytes (12 GB, 11 GiB) copied, 60 s, 203 MB/s^C 24171926+0 records in 24171926+0 records out 12376026112 bytes (12 GB, 12 GiB) copied, 60.8282 s, 203 MB/s This seems good when compared to 190 MB/s seen previously. If this is Ok, then I will spin v2 with changes suggested. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation