From: Jianguo Zhang <jianguo.zhang@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Biao Huang <biao.huang@mediatek.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v5 2/4] dt-bindings: net: snps,dwmac: add clk_csr property
Date: Tue, 27 Sep 2022 16:49:27 +0800 [thread overview]
Message-ID: <eb6a70844b067f76e8405b937de9408045d569a0.camel@mediatek.com> (raw)
In-Reply-To: <a215ae81-10de-7880-1a15-b7b08d0d80d7@linaro.org>
Dear Krzysztof,
Thanks for your comment.
On Fri, 2022-09-23 at 20:11 +0200, Krzysztof Kozlowski wrote:
> On 23/09/2022 07:28, Jianguo Zhang wrote:
> > The clk_csr property is parsed in driver for generating MDC clock
> > with correct frequency. A warning('clk_csr' was unexpeted) is
> > reported
> > when runing 'make_dtbs_check' because the clk_csr property
> > has been not documented in the binding file.
>
> Your subject is not accurate anymore. Maybe mention that instead of
> existing clk_csr, you add a different property.
>
> With commit msg fixes:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
We will fix commit message in next version patches.
> Best regards,
> Krzysztof
>
BRS
Jianguo
next prev parent reply other threads:[~2022-09-27 8:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 5:28 [PATCH v5 0/4] Mediatek ethernet patches for mt8188 Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 1/4] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 2/4] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
2022-09-23 18:11 ` Krzysztof Kozlowski
2022-09-27 8:49 ` Jianguo Zhang [this message]
2022-09-23 5:28 ` [PATCH v5 3/4] arm64: dts: mediatek: mt2712e: Update the name of property 'clk_csr' Jianguo Zhang
2022-09-23 5:28 ` [PATCH v5 4/4] net: stmmac: " Jianguo Zhang
2022-09-23 9:10 ` AngeloGioacchino Del Regno
2022-09-23 18:14 ` Krzysztof Kozlowski
2022-09-23 18:15 ` Krzysztof Kozlowski
2022-09-27 8:43 ` Jianguo Zhang
2022-09-27 8:44 ` Jianguo Zhang
2022-09-27 10:44 ` AngeloGioacchino Del Regno
2022-09-28 7:17 ` Krzysztof Kozlowski
2022-09-28 7:40 ` Jianguo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb6a70844b067f76e8405b937de9408045d569a0.camel@mediatek.com \
--to=jianguo.zhang@mediatek.com \
--cc=alexandre.torgue@foss.st.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).