From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
<linux-kernel@vger.kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] ARM: dts: stm32: re-add CAN support on stm32f746
Date: Tue, 11 Jul 2023 11:54:47 +0200 [thread overview]
Message-ID: <eb735953-bfa3-4dd7-6ab0-184de050c7de@foss.st.com> (raw)
In-Reply-To: <20230704173317.590190-1-dario.binacchi@amarulasolutions.com>
Hi Dario
On 7/4/23 19:33, Dario Binacchi wrote:
> The revert commit 36a6418bb1259 ("Revert "ARM: dts: stm32: add CAN support
> on stm32f746"") prevented parsing errors due to the lack of CAN3 binding.
>
> Now that the binding definition for CAN3 is available in the mainline
> thanks to commit 8f3ef556f8e1a ("dt-bindings: mfd: stm32f7: Add binding
> definition for CAN3"), we can re-add the CAN support and make the driver
> usable again.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
...
> + };
> +
> + can2: can@40006800 {
> + compatible = "st,stm32f4-bxcan";
> + reg = <0x40006800 0x200>;
> + iterrupts = <63>, <64>, <65>, <66>;
I modified this (bad) line and applied the patch on stm32-next.
br
Alex
> + interrupt-names = "tx", "rx0", "rx1", "sce";
> + resets = <&rcc STM32F7_APB1_RESET(CAN2)>;
> + clocks = <&rcc 0 STM32F7_APB1_CLOCK(CAN2)>;
> + st,can-secondary;
> + st,gcan = <&gcan1>;
> + status = "disabled";
> + };
> +
> cec: cec@40006c00 {
> compatible = "st,stm32-cec";
> reg = <0x40006C00 0x400>;
prev parent reply other threads:[~2023-07-11 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 17:33 [PATCH] ARM: dts: stm32: re-add CAN support on stm32f746 Dario Binacchi
2023-07-11 9:54 ` Alexandre TORGUE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb735953-bfa3-4dd7-6ab0-184de050c7de@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).