From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C903C7EE29 for ; Thu, 1 Jun 2023 12:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232853AbjFAMWn (ORCPT ); Thu, 1 Jun 2023 08:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232163AbjFAMWm (ORCPT ); Thu, 1 Jun 2023 08:22:42 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7915F13E for ; Thu, 1 Jun 2023 05:22:38 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4f3b314b1d7so864495e87.1 for ; Thu, 01 Jun 2023 05:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685622156; x=1688214156; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IE+0EX4jreqRlyvWFwvtw7kJ5ElwsDpu8BjalgiWcXU=; b=VbdfY032bBD2Euu6/l61SoonPI2YsFbrMVqB7CAxiR/3dW2j8PWJV1JBpvh62EKD3E cek4CPMPfOlWgG6X26tv3K1dKSlfJfynqwC9j+LMDNVd0kICypB6iy7D1N+X4MkHZRKA VLuzng3F8AaK7EKTWhNhGgU9sPCv9KsDx+7qyx4hZ43/q2sYOjnYe8yBoCVynpDbUCS8 seNsAk91002SH7ssJBngI4i3Dj1u5oZ2YLXI1PjNiwGBSlc3NtIRPRGC1JsHqqqHhaWK haKd4cj4UODEnszHslFUW5DVEOvHhg4eeAe+pZV/HmVYdSWds99BnkjEg2SzVLfxTkR+ LdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685622156; x=1688214156; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IE+0EX4jreqRlyvWFwvtw7kJ5ElwsDpu8BjalgiWcXU=; b=h79/ieLc2DkIpyFppgqk6zB/x6RvWl3SxEDrS7i2TIJLCOwkUvPYWmwm1Xuvoa1mI4 m1OITC7jcGuOycawjITrmncddq1Aoo0gEqv8sVlqiZ26by8e6yvo4Dbl3INqHvvo3uUJ sWKc73+0NopwVMZf6OlyQODwBV1Jm3FVVK5kmnI+d7wo1VO3v8ZV8zVBESDGDhLrzYY9 +CVCQeTeV877pD7OUdnz/+8BXI+J+B/+nVWGBD36edQ33g24ArPPyivxdhGoS7HKbxr3 SMhCBTD3/NFEZXWvMe0imLrm9w2LNnoQxo0QjVuvlyeP5vvI1oDjzu6LUf0je3cjn359 N+cw== X-Gm-Message-State: AC+VfDyHYHKxziYylWKk9m7PAbLMw8B6Y/SK/WiiaPfHGflfPBdDk0T5 v3RLlWhtgOOeT3Bgb/EOSSCOoQ== X-Google-Smtp-Source: ACHHUZ7spUu4Hagh90t4Pz2sHu6HA0S8/g8G6Z3nQe4orPReZPUVweivSfWaVh0G9b8UC713mtMBgA== X-Received: by 2002:ac2:520a:0:b0:4f3:78c2:2a6d with SMTP id a10-20020ac2520a000000b004f378c22a6dmr1356274lfl.3.1685622156740; Thu, 01 Jun 2023 05:22:36 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id q3-20020ac24a63000000b004f27471e0aesm1071127lfp.79.2023.06.01.05.22.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 05:22:36 -0700 (PDT) Message-ID: Date: Thu, 1 Jun 2023 14:22:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 2/4] arm64: dts: qcom: sm8250: Add missing interconnect paths to USB HCs Content-Language: en-US To: Abel Vesa , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List References: <20230601120029.38859-1-abel.vesa@linaro.org> <20230601120029.38859-2-abel.vesa@linaro.org> From: Konrad Dybcio In-Reply-To: <20230601120029.38859-2-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 1.06.2023 14:00, Abel Vesa wrote: > The USB HCs nodes are missing the interconnect paths, so add them. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index e5c60a6e4074..eefd3dcbb2e1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3750,6 +3750,10 @@ usb_1: usb@a6f8800 { > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>; You need to update #interconnect-cells to 2. Konrad > + interconnect-names = "usb-ddr", "apps-usb"; > + > usb_1_dwc3: usb@a600000 { > compatible = "snps,dwc3"; > reg = <0 0x0a600000 0 0xcd00>; > @@ -3810,6 +3814,10 @@ usb_2: usb@a8f8800 { > > resets = <&gcc GCC_USB30_SEC_BCR>; > > + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>, > + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>; > + interconnect-names = "usb-ddr", "apps-usb"; > + > usb_2_dwc3: usb@a800000 { > compatible = "snps,dwc3"; > reg = <0 0x0a800000 0 0xcd00>;