From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9422AC001DF for ; Wed, 26 Jul 2023 10:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbjGZK4B (ORCPT ); Wed, 26 Jul 2023 06:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234037AbjGZKz7 (ORCPT ); Wed, 26 Jul 2023 06:55:59 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 101A42688 for ; Wed, 26 Jul 2023 03:55:57 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-31427ddd3fbso5404045f8f.0 for ; Wed, 26 Jul 2023 03:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690368955; x=1690973755; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iegk/2TKL5Rj456XBjxdhlF2YFlmLFdSyPtT2uk62mo=; b=CW3jL5pMUrmOUizoS1E9Hcsvtp4BD/g7xIZqvjeEkiUm4QBhFwTSenULu7s0INr9iJ zQysgQPFzzAVrqets21G+KcdMXNDWvaj9TwVMnDuA/v4sGB1JgcKYEF4cErb4lNceJ+2 YVE6eDM18TkSiSu4iJfWA/Ku+F+wohEkxQgbqJuieY0qLQv1e8ZYLf/FY/BaKem8B936 PdG2Z39Rxp+xEfrzkebV4lh0v083vpRRmnFRTIW+Kyfr+rB3xFJLS1yHpobQYxZbtkhC rywe5ncdgxjclxQMKOK0X5tJhU/o+KgtRF2F4GQhNwTe3EUKY1Gt4rriLeBpkloQS8X/ wCFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690368955; x=1690973755; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iegk/2TKL5Rj456XBjxdhlF2YFlmLFdSyPtT2uk62mo=; b=Wv0Ml/YZTXOA66RVkeFgDZeBQAM7CceUkRsDe1Zt4PIF9cOao+AuZMIhZJykQgPSVK K50LyTjHCeRLQBF6hlvmo40sA8/+iUTo5vF327lokv2N3rzkJQN/wqKDDI278bHxVGGr 1aLIcY57etsKDr2Oxj5E3w9NQzivznj6nTEmgr5i5Zv404oASteZmujKT3zFInJb8yYv OIrs6Um+kKOzuiAXHCJaDBDyt+WV0hUe+UTA3svf3obEwYBrgtMrTZilptaCYGodUdhd uLq9ApOgOvS/Yc8qtCYgi4Jk3Kf/g9vntQcXXl0FYHGwKrKWl3LQC6ARM+K/gBG6NMli lGGQ== X-Gm-Message-State: ABy/qLbZfVGgeFtyJ3kK2ekfpmBNPKv6xIUMVMXKAYrVaS1Ymtpsi1fV oPB7PJSBKYL42pf6rp3naOZ6ag== X-Google-Smtp-Source: APBJJlG6UyprMnFMQm4Ei76lg009+z+sJ9pxlVFtN/IZb2oMNBA6ouM38riQicLc05GMonaqkYMTWw== X-Received: by 2002:a5d:558e:0:b0:313:e9f6:3378 with SMTP id i14-20020a5d558e000000b00313e9f63378mr1003950wrv.4.1690368955338; Wed, 26 Jul 2023 03:55:55 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id o26-20020a5d58da000000b0030ae499da59sm19353583wrf.111.2023.07.26.03.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 03:55:54 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 11:55:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver Content-Language: en-US To: Jack Zhu , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-4-jack.zhu@starfivetech.com> From: Bryan O'Donoghue In-Reply-To: <20230619112838.19797-4-jack.zhu@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/06/2023 12:28, Jack Zhu wrote: > +static int stfcamss_of_parse_ports(struct stfcamss *stfcamss) > +{ > + struct device *dev = stfcamss->dev; > + struct device_node *node = NULL; > + int ret, num_subdevs = 0; > + > + for_each_endpoint_of_node(dev->of_node, node) { > + struct stfcamss_async_subdev *csd; > + > + if (!of_device_is_available(node)) > + continue; > + > + csd = v4l2_async_nf_add_fwnode_remote(&stfcamss->notifier, > + of_fwnode_handle(node), > + struct stfcamss_async_subdev); > + if (IS_ERR(csd)) { > + ret = PTR_ERR(csd); > + goto err_cleanup; > + } > + > + ret = stfcamss_of_parse_endpoint_node(dev, node, csd); > + if (ret < 0) > + goto err_cleanup; > + > + num_subdevs++; > + } > + > + return num_subdevs; > + > +err_cleanup: > + of_node_put(node); Where is the _get() for this and if you are releasing it on the error path when is the _get() released on the non-error path ? > + return ret; > +} > + > +static int stfcamss_subdev_notifier_bound(struct v4l2_async_notifier *async, > + struct v4l2_subdev *subdev, > + struct v4l2_async_subdev *asd) > +{ > + struct media_pad *pad[STF_PADS_NUM]; > + unsigned int i, pad_num = 0; > + > + for (i = 0; i < pad_num; ++i) { Does this loop ever run ? I don't see how it can.. --- bod