From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B31334686; Fri, 17 Oct 2025 05:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.29.241.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760679767; cv=none; b=PbOvOLoJIfHDKmbor6rkHT4Gy7Fg92DBcHJcwD9+erllnda3zmtIdsdUe9Q8lcDsYe2FquDq3X1aN6hgoanGhFWmAGvELiw2nT2OgCbKBTcVmCCMQoE3JwMIw6eOF5sCp10Vw3HTxyn7X1+elk5tFf4CLvtxQw+0/MR9VCcKYRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760679767; c=relaxed/simple; bh=p4YrhPxAw19YKbCKmeJHaX98uuLYigduGbo1AFpZgTQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BfDX+E6Jp1OBCx52Ok3YImBkF5BlMAzAinxzrpKT+Z2ClGwfVcEQKYT5Fx4lyFJOX5B/o9WV9W4H+lTZMlrnhuOqihrXEEwuirlpfrHOLjZrwRQd4go6rut4i87segNVRW5A0xNaC64zuv9g83WVJYhWMsaxUT7JbR/i87CfQHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au; spf=pass smtp.mailfrom=codeconstruct.com.au; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b=Hm0yU3a2; arc=none smtp.client-ip=203.29.241.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeconstruct.com.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.b="Hm0yU3a2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1760679762; bh=FBOBE2lJJ4ubL1SZFxRHcJFjs6sCvB23xdXmM4GToK8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Hm0yU3a2z4bD4DKGw34ZbPDfR4rW6dPHM7WeC4kQPhcDJVhiSCwheDLG7f3xa0io2 5H/RYHexWp3moLpTsY05ufX3r1a7hG4pRri3O9/rWF1BwkofObOZcvlSrYycV0aCvw REsTNvcvGFUcT+RqwUVeaChsa7nLBkhXXYTFN8O8177yP4u0tm+ranaQChlIQQVTQT QSxuaeyPqBJSz/3EpmlmIJ1R7MiYaGKmPVNyx4yJsBzcQ/5D86RLiQVhPG82yIAogi 0GKMzuIzyg1tVgF91bMvdOtfyWDX4m8iD7aYuO15s1k1US+vBSe2AcUbZpz7Lx2rFF Rt0o3NL2o9G0g== Received: from [192.168.68.113] (unknown [180.150.112.213]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id E4193766F5; Fri, 17 Oct 2025 13:42:41 +0800 (AWST) Message-ID: Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: add asrock x470d4u bmc From: Andrew Jeffery To: Tan Siewert , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: Zev Weiss , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 17 Oct 2025 16:12:41 +1030 In-Reply-To: <20251011112124.17588-3-tan@siewert.io> References: <20251011112124.17588-1-tan@siewert.io> <20251011112124.17588-3-tan@siewert.io> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2025-10-11 at 13:21 +0200, Tan Siewert wrote: > The ASRock Rack X470D4U X470D4U is a single-socket X470-based microATX > motherboard for Ryzen processors with an AST2500 BMC and either 32MB or > 64MB SPI flash. >=20 > This mainboard exists in three known "flavors" which only differ in the > used host NIC, the BMC SPI size and some parts that may be un-populated. >=20 > To keep the complexity low with the BMC SPI, use the 32MB layout > regardless of the used SPI or mainboard flavor. >=20 > Signed-off-by: Tan Siewert > --- > v2: > =C2=A0 - fix led node names [robh] > =C2=A0 - fix missing gfx memory region and other offenses [Tan] > --- > =C2=A0arch/arm/boot/dts/aspeed/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 1 + > =C2=A0.../dts/aspeed/aspeed-bmc-asrock-x470d4u.dts=C2=A0 | 350 ++++++++++= ++++++++ > =C2=A02 files changed, 351 insertions(+) > =C2=A0create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d= 4u.dts >=20 > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed= /Makefile > index 0f0b5b707654..c601af36915e 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_ASPEED) +=3D \ > =C2=A0 aspeed-bmc-asrock-e3c256d4i.dtb \ > =C2=A0 aspeed-bmc-asrock-romed8hm3.dtb \ > =C2=A0 aspeed-bmc-asrock-spc621d8hm3.dtb \ > + aspeed-bmc-asrock-x470d4u.dtb \ > =C2=A0 aspeed-bmc-asrock-x570d4u.dtb \ > =C2=A0 aspeed-bmc-asus-x4tf.dtb \ > =C2=A0 aspeed-bmc-bytedance-g220a.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts b/arc= h/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts > new file mode 100644 > index 000000000000..e9804b0ace9f > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x470d4u.dts > @@ -0,0 +1,350 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/dts-v1/; > + > +#include "aspeed-g5.dtsi" > +#include > +#include > +#include > + > +/ { > + model =3D "Asrock Rack X470D4U-series BMC"; > + compatible =3D "asrock,x470d4u-bmc", "aspeed,ast2500"; > + > + aliases { > + serial4 =3D &uart5; > + }; > + > + chosen { > + stdout-path =3D &uart5; > + }; >=20 >=20 *snip* > nvmem-cell-names =3D "mac-address"; > +}; > + > +&mac1 { > + status =3D "okay"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_rmii2_default &pinctrl_mdio2_default>; If you're using NCSI you don't need the MDIO pins here, right? > + use-ncsi; > + > + nvmem-cells =3D <ð1_macaddress>; > + nvmem-cell-names =3D "mac-address"; > +}; > + Andrew