devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
	<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation
Date: Tue, 27 Oct 2020 11:33:49 +0530	[thread overview]
Message-ID: <eba1f18a-0b2e-d52b-593a-9ef5304f9199@nvidia.com> (raw)
In-Reply-To: <87h7qgw848.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

>>> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>>
>>> This patch switches from .txt base to .yaml base Document.
>>>
>>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> (snip)
>> Since I am trying to re-use most of audio-graph for Tegra, can
>> 'compatible' be moved to a separate schema?
>> For example,
>> audio-graph.yaml -> defines all the common stuff
>> audio-graph-card.yaml -> audio-graph.yaml + 'compatible' property
>> Similarly, tegra-audio-graph-card.yaml -> audio-graph.yaml + Tegra
>> 'compatible' property
> I'm not expert of Json-Schema, and it sound very expert technique for me.
> (It always indicates me unknown errors...)
> I'm posting this patch since many month ago, and not yet accepted
> for many reasons (audio-graph DT is very complex).
> I spend many times for it and finally come to the point where it
> can (might) be accepted.
> I'm sorry but I want to finish this work,
> this means I don't want to customize it any more.
> If I try it, it needs more month...

I am not a json-schema expert either :) From earlier comments on Tegra 
audio graph series, above re-use is possible I suppose. I depend on your 
audio-graph documentation and for 'compatible' I am seeing error. So I 
thought it may be fine to split audio-graph into two json-schemas now 
itself. Otherwise I need to do it separately in my series if I want to 
re-use your audio-graph, which is fine with me.

  reply	other threads:[~2020-10-27  6:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22  0:45 [PATCH v3 0/3] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation Kuninori Morimoto
2020-10-22  0:46 ` [PATCH v3 1/3] " Kuninori Morimoto
2020-10-22  5:19   ` Sameer Pujar
2020-10-27  4:52     ` Kuninori Morimoto
2020-10-27  6:15       ` Sameer Pujar
2020-10-27  5:32     ` Kuninori Morimoto
2020-10-27  6:03       ` Sameer Pujar [this message]
2020-10-28 16:04         ` Rob Herring
2020-10-28 23:33           ` Kuninori Morimoto
2020-10-23 13:52   ` Sameer Pujar
2020-10-25 23:07     ` Kuninori Morimoto
2020-10-26  2:49       ` Sameer Pujar
2020-10-27  5:22         ` Kuninori Morimoto
2020-10-22  0:46 ` [PATCH v3 2/3] ASoC: dt-bindings: renesas,rsnd: " Kuninori Morimoto
2020-10-23 16:06   ` [PATCH v3 2/3] ASoC: dt-bindings: renesas, rsnd: " Rob Herring
2020-10-22  0:46 ` [PATCH v3 3/3] dt-bindings: ASoC: renesas,rsnd: Add r8a77961 support Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eba1f18a-0b2e-d52b-593a-9ef5304f9199@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).