From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED03BC71136 for ; Fri, 18 Aug 2023 09:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359102AbjHRJcI (ORCPT ); Fri, 18 Aug 2023 05:32:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359248AbjHRJbw (ORCPT ); Fri, 18 Aug 2023 05:31:52 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36F4D3C1D for ; Fri, 18 Aug 2023 02:31:39 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99c353a395cso85449766b.2 for ; Fri, 18 Aug 2023 02:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692351097; x=1692955897; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pL7L3WqTivmRh2NkcdS+o8QoBLa4Dg7vH4Pm6EApcf8=; b=vCjDYRIlAAp5DeEkp/TeWIxPOdQQKKZMZR76F/a9136wSifkRBIsipwCC9T5xagszg lRU47G6naZfec/ZXJdbIQ4ttG+jUBZadVCNFFGZ5YbA8x7Q0cpOJ8UM1avgwnVqzhvMS nvTUbidt9XAzZv/j6YHEyCidXw0bynRO7FEYVwcoCd0Af7es0s+9HHbtRknjWwMo0To8 c87g8Ygxerd9FfHi6pp/Wmy0CtPceg62o/Rf1NrvgDN3ZFS+VdSCgp4VESjLvLrZc2g4 +M6rxEFJOahVODgK23bqQHi7v+WN8ddVF3YwWTM6J5nfHV/3YWM409dTcFkxOaWvl6ul D4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692351097; x=1692955897; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pL7L3WqTivmRh2NkcdS+o8QoBLa4Dg7vH4Pm6EApcf8=; b=agqcHpYIrbJIzmAVU74VIPS2WZ0qduEPcITNGuJhTv08457k2eOQv6c74R/Vlf2/EK NC33AQ/mhZPrU91O7iGJJLig3JFPHJgWVeGGImsfSbYhMQdQwNetnjGH9JJEDvS7+h25 4T8eF5JX/nVlOl7FGN+DQhY3ItJXySvRQby7tyet6BvRZqFYfOuPSjxcRqitTZOCVOh6 97/b77vGqDw8+zrOIh54zeOeFFtUg0A9EqPNoP/DIXGXcAWapW52DCd47VNMOAEmqwPm 7rY8FqO+TTy9NVtbC7AumvHMDdHxGh8hk70jKfRy2NqSBnKpCPjcxNHRtwukOcOK2aJm mqyw== X-Gm-Message-State: AOJu0Yyr8ZFhMG94pm6I76zaJFFZCdaMrluJBjQcU5+r4Y/PrpTBHgNn dtKZIkxW9Ir6SYeuSkcnlE8wKg== X-Google-Smtp-Source: AGHT+IFEfIKo8zmvgiACt6EAKWKYfHjNWnIq6cJKnY6qX//b9iaqG1p449CeXVv+Rj+D+S5crLWdPg== X-Received: by 2002:a17:906:23f2:b0:99c:7915:b844 with SMTP id j18-20020a17090623f200b0099c7915b844mr1388984ejg.57.1692351097620; Fri, 18 Aug 2023 02:31:37 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id h17-20020a17090634d100b00993cc1242d4sm948376ejb.151.2023.08.18.02.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Aug 2023 02:31:37 -0700 (PDT) Message-ID: Date: Fri, 18 Aug 2023 11:31:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] dt-bindings: usb: Add binding for ti,tps25750 Content-Language: en-US To: Abdel Alkuor , devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Abdel Alkuor References: <20230817235212.441254-1-alkuor@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230817235212.441254-1-alkuor@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/08/2023 01:52, Abdel Alkuor wrote: > From: Abdel Alkuor > > TPS25750 provides power negotiation and capabilities management > for USB Type-C applications. > > Signed-off-by: Abdel Alkuor Where is any user of it? DTS, driver or 3rd party upstream open-source project? A nit, subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > --- > .../devicetree/bindings/usb/ti,tps25750.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ti,tps25750.yaml > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps25750.yaml b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml > new file mode 100644 > index 000000000000..326c9c2f766b > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ti,tps25750.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/ti,tps25750.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments 25750 Type-C Port Switch and Power Delivery controller > + > +maintainers: > + - Abdel Alkuor > + > +description: | > + Texas Instruments 25750 Type-C Port Switch and Power Delivery controller > + > +properties: > + compatible: > + enum: > + - ti,tps25750 Blank line > + reg: > + maxItems: 1 > + > + interrupts: > + description: | Drop description > + maxItems: 1 > + > + interrupt-names: > + items: > + - const: irq Drop interrupt-names, it is useless in this form. > + > + firmware-name: > + description: | > + Should contain the name of the default patch binary > + file located on the firmware search path which is > + used to switch the controller into APP mode maxItems: 1 > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml# > + description: > + Properties for usb c connector. > + required: > + - data-role > + > +required: > + - compatible > + - reg > + - interrupts > + - connector > + > +additionalProperties: true > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + tps25750: tps25750@21 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,tps25750"; > + reg = <0x21>; > + Best regards, Krzysztof