From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon
Date: Mon, 21 Aug 2023 14:06:41 +0200 [thread overview]
Message-ID: <ebad4f91-3d4e-c50f-0bde-f11f16061214@linaro.org> (raw)
In-Reply-To: <CAJhJPsXEf0Yuxasq24X=x_JtUJZrNC1aowfeuu9QM2kz+A=asQ@mail.gmail.com>
On 21/08/2023 13:00, Keguang Zhang wrote:
> On Sat, Aug 19, 2023 at 10:23 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 16/08/2023 13:13, Keguang Zhang wrote:
>>> Add Loongson LS1B and LS1C compatibles for system controller.
>>
>> I asked not to use the same compatible for different blocks. Compatible
>> is dwmac, but are you still going to use for other blocks? Please write
>> proper description of the hardware.
>>
> Sorry. I didn't make myself clear.
> The SoC only has one syscon with two registers.
> And Each register contains settings for multiple devices.
> Besides DWMAC, this syscon will be used for other devices.
> Should I keep using loongson,ls1b-syscon/loongson,ls1c-syscon?
Ah, ok, then the naming of the compatible should reflect the name of
this syscon block. If it does not have any name and it is the only
syscon, then name like "loongson,ls1b-syscon" is good. If the block has
some name - use it in compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-21 12:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 11:13 [PATCH v2 0/4] Move Loongson1 MAC arch-code to the driver dir Keguang Zhang
2023-08-16 11:13 ` [PATCH v2 1/4] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon Keguang Zhang
2023-08-19 14:23 ` Krzysztof Kozlowski
2023-08-21 11:00 ` Keguang Zhang
2023-08-21 12:06 ` Krzysztof Kozlowski [this message]
2023-08-16 11:13 ` [PATCH v2 2/4] dt-bindings: net: Add Loongson-1 DWMAC glue layer Keguang Zhang
2023-08-19 14:26 ` Krzysztof Kozlowski
2023-08-21 13:26 ` Keguang Zhang
2023-08-16 11:13 ` [PATCH v2 3/4] net: stmmac: Add glue layer for Loongson-1 SoC Keguang Zhang
2023-08-19 19:05 ` Simon Horman
2023-08-21 13:27 ` Keguang Zhang
2023-08-20 19:04 ` Andrew Lunn
2023-08-22 9:47 ` Keguang Zhang
2023-08-22 9:49 ` Keguang Zhang
2023-08-22 15:21 ` Andrew Lunn
2023-08-22 15:20 ` Andrew Lunn
2023-08-23 2:47 ` Keguang Zhang
2023-08-23 3:46 ` Andrew Lunn
2023-08-23 4:40 ` Keguang Zhang
2023-08-16 11:13 ` [PATCH v2 4/4] MAINTAINERS: Update MIPS/LOONGSON1 entry Keguang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebad4f91-3d4e-c50f-0bde-f11f16061214@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=keguang.zhang@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).