From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706F6EE49A6 for ; Mon, 21 Aug 2023 12:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234206AbjHUMGr (ORCPT ); Mon, 21 Aug 2023 08:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234111AbjHUMGr (ORCPT ); Mon, 21 Aug 2023 08:06:47 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BADDCC for ; Mon, 21 Aug 2023 05:06:45 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-522dd6b6438so3919538a12.0 for ; Mon, 21 Aug 2023 05:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692619603; x=1693224403; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2S+WETvfAyrCVF8DP9tvmJJ5EWf71P/PjeMnXn7n6Lo=; b=AKZiy1IcmrTnS8t3Aj69f9szwT2W6buD4JdkJG4PhzNFd6RC8DEOEnJzG38wHiY0Ct lmbiwczvEAh2uxmGvZAgXbiZ017Oi4wm9iR7//3Zuuf7YMYcMNn1aUN82CmnWaEzEQIg ZhBKp2uSyMsg1I9vn/xFo1RVwdnSQA6OtyXdtESjctJucwdoOQ9sn2Nb/5uw9G7DlkqG qloCTWdZbnsV72yu1caka78IiEqhakoJYJKc60vARtuWBqeL7KqzEXi13BSS9L90bhTF angIuJ2m55GyWnP4ZlERe4CPo6mqJtDkwRVBdSh7h7nCsvmDBiJsGgxCo54DH/y+MXo6 ou3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692619603; x=1693224403; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2S+WETvfAyrCVF8DP9tvmJJ5EWf71P/PjeMnXn7n6Lo=; b=l2gm04J7g2T9bzD0FdDBBk7W7He/4b6/wYG4ykqlpmBYLUUL1wTSSJudf12rKeIcKE d47FFlU4LWUbZ85dgVzYDjv6tGtsVGoAbt8Vat1rjoDeQqg44/PzO6EdkUfvBrMbCvBn 1XbXhHuWIn7hEmOv65G18C23ectXUio77cueSJPqwIy4MTtpfGjXOcNkphC6WkqgCZK7 p1HUexTLWEGsfcFqaE7DGsOlni83S8bE6mMbxwueerMoRsim5ylopm9Eu7+B+ltp67/x 2EeK72yG9tLHpLiCZYlsw19JTRrQnUuV+rKxUMKjPwZ64dVOIVBXCSY03jUy1GcRVT6J OkpA== X-Gm-Message-State: AOJu0YyE4/RWnkca3qKS7Yk2Wc/6dBtDzY3UJbdnDrxXC1Ci4R6cDyGu Tf/kQHzeoXouZoimh9HxJb/vww== X-Google-Smtp-Source: AGHT+IGA3fcwCUwoHfQmYSY/wtDyAlgOxfO0or6c6j0Qcinb4t2/XgeaIcZi4syQvHqfZpMf9jNYmQ== X-Received: by 2002:a50:fa93:0:b0:525:d95b:cd46 with SMTP id w19-20020a50fa93000000b00525d95bcd46mr4674958edr.2.1692619603593; Mon, 21 Aug 2023 05:06:43 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id g4-20020a056402180400b00525727db542sm5974464edy.54.2023.08.21.05.06.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Aug 2023 05:06:43 -0700 (PDT) Message-ID: Date: Mon, 21 Aug 2023 14:06:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon Content-Language: en-US To: Keguang Zhang Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Bogendoerfer , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Serge Semin References: <20230816111310.1656224-1-keguang.zhang@gmail.com> <20230816111310.1656224-2-keguang.zhang@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/08/2023 13:00, Keguang Zhang wrote: > On Sat, Aug 19, 2023 at 10:23 PM Krzysztof Kozlowski > wrote: >> >> On 16/08/2023 13:13, Keguang Zhang wrote: >>> Add Loongson LS1B and LS1C compatibles for system controller. >> >> I asked not to use the same compatible for different blocks. Compatible >> is dwmac, but are you still going to use for other blocks? Please write >> proper description of the hardware. >> > Sorry. I didn't make myself clear. > The SoC only has one syscon with two registers. > And Each register contains settings for multiple devices. > Besides DWMAC, this syscon will be used for other devices. > Should I keep using loongson,ls1b-syscon/loongson,ls1c-syscon? Ah, ok, then the naming of the compatible should reflect the name of this syscon block. If it does not have any name and it is the only syscon, then name like "loongson,ls1b-syscon" is good. If the block has some name - use it in compatible. Best regards, Krzysztof