From: Krzysztof Kozlowski <krzk@kernel.org>
To: Roger Quadros <rogerq@kernel.org>,
miquel.raynal@bootlin.com, robh+dt@kernel.org
Cc: richard@nod.at, vigneshr@ti.com, kishon@ti.com, nm@ti.com,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM
Date: Fri, 25 Mar 2022 17:22:07 +0100 [thread overview]
Message-ID: <ebca0e5d-cc24-af1c-5308-8544682984ec@kernel.org> (raw)
In-Reply-To: <20220325123707.22020-3-rogerq@kernel.org>
On 25/03/2022 13:37, Roger Quadros wrote:
> TI's AM64 SoC has the Error Locator Module. Add compatible and
> related properties to support ELM on AM64 SoC.
>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
> .../devicetree/bindings/mtd/ti,elm.yaml | 28 ++++++++++++++++++-
> 1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> index e36452b742c0..967c87f32c71 100644
> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> @@ -16,7 +16,10 @@ description:
>
> properties:
> compatible:
> - const: ti,am3352-elm
> + items:
Why do the items appeared again?
Make it an enum in first patch, without items, with one entry. Now in
patch #2 you add one more compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-25 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 12:37 [PATCH v2 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml Roger Quadros
2022-03-25 12:37 ` [PATCH v2 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros
2022-03-25 16:08 ` Rob Herring
2022-03-25 16:24 ` Krzysztof Kozlowski
2022-03-25 19:40 ` Rob Herring
2022-03-25 12:37 ` [PATCH v2 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Roger Quadros
2022-03-25 16:22 ` Krzysztof Kozlowski [this message]
2022-03-25 12:37 ` [PATCH v2 3/3] mtd: rawnand: omap_elm: Add compatible " Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebca0e5d-cc24-af1c-5308-8544682984ec@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=nm@ti.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).