From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH] thermal: mt8173: minor mtk_thermal.c cleanups Date: Thu, 9 Feb 2017 22:25:36 +0100 Message-ID: References: <1486531862-31945-1-git-send-email-dawei.chien@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1486531862-31945-1-git-send-email-dawei.chien@mediatek.com> Sender: linux-pm-owner@vger.kernel.org To: Dawei Chien , Zhang Rui , Eduardo Valentin Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, Sascha Hauer , Fan Chen , Eddie Huang , Yingjoe Chen , Erin Lo List-Id: devicetree@vger.kernel.org On 02/08/2017 06:31 AM, Dawei Chien wrote: > Thermal driver should read TEMP_MSR3 if thermal bank with 4 sensors. > However, Currently thermal driver don't need read TEMP_MSR3 since > thermal controller only use 3 sensors for each thermal bank. > > Signed-off-by: Dawei Chien > --- Actually the commit message should state: Fixes: b7cf0053738c ("thermal: Add Mediatek thermal driver for mt2701.") ...and get backported to v4.9 and v4.10. Reviewed-by: Matthias Brugger Regards, Matthias > drivers/thermal/mtk_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 34169c3..c124151 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -191,7 +191,7 @@ struct mtk_thermal { > }; > > const int mt8173_msr[MT8173_NUM_SENSORS_PER_ZONE] = { > - TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR2 > + TEMP_MSR0, TEMP_MSR1, TEMP_MSR2, TEMP_MSR3 > }; > > const int mt8173_adcpnp[MT8173_NUM_SENSORS_PER_ZONE] = { >