From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="HAm8BYCe" X-Greylist: delayed 900 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 28 Nov 2023 00:28:47 PST Received: from mail-m254123.xmail.ntesmail.com (mail-m254123.xmail.ntesmail.com [103.129.254.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A119BE1 for ; Tue, 28 Nov 2023 00:28:47 -0800 (PST) DKIM-Signature: a=rsa-sha256; b=HAm8BYCe9hC7NPROBosIMFj9wasb0u+eJOzr6lpMGIMOAg26fKmaMpCkzi9ZRHDPSYlqMJvaTT0l8bHr4NV2vppOqf5wngABHhxCx8bC3YkshxgK479gp0RBsaUgHQ6aqsz+LfRiAV5V6VoiaJzWKoWbOx+VPmz9kwlUAH9AHD0=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=l5YDICzpqBFa88znUPxe1seE4a0/hNlDkTMuGOSDKdU=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m12762.qiye.163.com (Hmail) with ESMTPA id 01F355C0371; Tue, 28 Nov 2023 16:03:46 +0800 (CST) Message-ID: Date: Tue, 28 Nov 2023 16:03:46 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/12] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Content-Language: en-US To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, sebastian.reichel@collabora.com, kever.yang@rock-chips.com, chris.obbard@collabora.com, s.hauer@pengutronix.de References: <20231122125316.3454268-1-andyshrk@163.com> <20231122125425.3454549-1-andyshrk@163.com> <3927498.QCnGb9OGeP@diego> From: Andy Yan In-Reply-To: <3927498.QCnGb9OGeP@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQxhCT1ZCSEkYTU1PSR9ISktVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk1PSU5JVUpLS1VKQl kG X-HM-Tid: 0a8c14f4a803b229kuuu01f355c0371 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Myo6Lww5Qzw9Sx5MEBY3Ej8I AzcKCQ5VSlVKTEtKSk5DTUlDS0tPVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBSEtKTTcG Hi Heiko: On 11/27/23 23:02, Heiko Stübner wrote: > Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan: >> From: Andy Yan >> >> The enable bit and transform offset of cluster windows should be >> cleared when it work at linear mode, or we may have a iommu fault >> issue. >> >> Signed-off-by: Andy Yan > I guess same here? > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") I'm not sure if we need a Fixes tag here,  in fact this issue never happens on rk3566/8 , because the cluster windows of rk356x only support afbc format, they don't have a chance to switch between afbc and linear mode. Of course, the lack support of linear mode of rk356x cluster windows is a thoughtless of IC design, if it really support both afbc and linear format, we indeed need this fix. The situation is the same as patch 03/12. So I hope follow your advice, if it need a Fixes tag here. > > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip