devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Marc Olberding <molberding@nvidia.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dts: aspeed: Add a dts for the nvidia msx4 hpm
Date: Fri, 19 Sep 2025 03:39:28 +0200	[thread overview]
Message-ID: <ebf28e23-1ee1-456c-8cfd-ee5c02effeeb@lunn.ch> (raw)
In-Reply-To: <20250918-msx1_devicetree-v1-2-18dc07e02118@nvidia.com>

> +// bootloader takes care of proper mac delays for now.
> +// phy-mode is here to prevent breakage once the aspeed
> +// mac driver is fixed.
> +&mac0 {
> +	phy-mode = "rgmii-id";

Just for my understanding, by "bootloader takes care of proper mac
delays for now" you mean you have a 'hacked' bootloader which no
longer adds delays, unlike the stock aspeed bootloader which does add
delays? Because otherwise, i don't see how rgmii-id will work.

> +	phy-handle = <&ethphy3>;
> +	max-speed = <1000>;

RGMII cannot do more than 1G, so max-speed is pointless.

	Andrew

      reply	other threads:[~2025-09-19  1:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18 23:11 [PATCH 0/2] Add device tree for Nvidia BMC msx4 cx8 switchboard Marc Olberding
2025-09-18 23:11 ` [PATCH 1/2] dt-bindings: arm: aspeed: Add Nvidia msx4 board Marc Olberding
2025-09-19 17:20   ` Conor Dooley
2025-09-18 23:11 ` [PATCH 2/2] dts: aspeed: Add a dts for the nvidia msx4 hpm Marc Olberding
2025-09-19  1:39   ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebf28e23-1ee1-456c-8cfd-ee5c02effeeb@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=molberding@nvidia.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).