From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A79333D3CF5; Tue, 28 Jul 2026 15:08:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785251329; cv=none; b=ixC2L3VAll9ruxG+NnoOelT5AyvaJi91Fv/XPvehO6AgnJhFPZL5b+vdoZ+hqo+y7GeN+04TwUMg4b067cr8F9rlv9AlAWFoEsgUlaLFBwPJnuBsXBBhGpNRm0E5HhjocF/tYDbLmX9sShIe+r6hQmEuK8tNFKZkN0ip4PuVWrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785251329; c=relaxed/simple; bh=pv+sMQ7GV/BnoPnLcF7CThx/aHByigCq7f8z/q+RkXU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FpZ0FVpvAb/WxE/wQhJlAAsw2jZiE7HVdUdlczEXCjSy67Dya9YdykQOofw9SWZYs/ccUvmZHlAYKmDPUBL6n5iERu+usXCB6TkyoVwzuHhIPKaJxuQfqRGPZoVMUSzNdgmLDXq32Eh+MbGwO+bz7NoB6R56XaYUNt78oMR+t4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jMc24Rti; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jMc24Rti" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1785251325; bh=pv+sMQ7GV/BnoPnLcF7CThx/aHByigCq7f8z/q+RkXU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jMc24RtiUREB/82DNYfJcM5dY+xEDaQlG7GAJPfC1oS47ek37AIlHr74JVk181Z5S 7ql5VYRMJiPMPTRKq4FOf/VGXP1V7Lbyyce+KAA3BZ3tO6S4ONPw1kF3tc9BxgtFMl ammRPNjem9KtzJPnqKE6Mfj+anwj4msj1OXTm/FQA8mDvnPHvcudYGJTZY7SAw6Zum fequVaM+7ZEUJkxjPpBN5keA2qu7GWHOKvKOXKpIy+zKCy9ujmFLqJiGpp5mWzpJvF 0gTBbMJm8dCUOd13FCoj/v5jWUTKRVrfczH0nDOkG8smA99+pw+ZE8Z+pyjpkP7icd jMeGT5eA4B1AA== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3C34617E028D; Tue, 28 Jul 2026 17:08:45 +0200 (CEST) Message-ID: Date: Tue, 28 Jul 2026 17:08:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] soc: mediatek: cmdq-helper: add legacy GCE ISA support To: rva333@protonmail.com, Jassi Brar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Houlong Wei Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260728-6572-gce-v1-0-750bba32689e@protonmail.com> <20260728-6572-gce-v1-2-750bba32689e@protonmail.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260728-6572-gce-v1-2-750bba32689e@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/28/26 11:42, Roman Vivchar via B4 Relay wrote: > From: Roman Vivchar > > Some SoCs, such as mt6572, have different WRITE and POLL instruction > encoding. Instead of 16-bit offset and 8-bit subsystem ID, old GCEs have > 22-bit offset and 2-bit subsystem ID. What about poll_addr, mask, write_s, write_s_mask and others? Not sure that this will actually work reliably (though I'm sure you're not creating any regression). > > Extend cmdq_instruction struct with additional union and struct to hold > the legacy format of instruction encoding. Add legacy_isa to select > legacy GCE ISA when writing instruction. Finally, add special handing > for legacy_isa cases. > > While mt6572 GCE supports 22-bit offsets, the parameter type for offset > remains 16 bit, because all mt6572 GCE mmsys consumers are in the 0xffff > range. > > Signed-off-by: Roman Vivchar > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 55 ++++++++++++++++++++++---------- > include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + > 2 files changed, 39 insertions(+), 17 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index f8ee6c9ade89..094732405080 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -31,18 +31,27 @@ struct cmdq_instruction { > }; > }; > union { > - u16 offset; > - u16 event; > - u16 reg_dst; > - }; > - union { > - u8 subsys; > struct { > - u8 sop:5; > - u8 arg_c_t:1; > - u8 src_t:1; > - u8 dst_t:1; > - }; > + union { > + u16 offset; > + u16 event; > + u16 reg_dst; > + }; > + union { > + u8 subsys; > + struct { > + u8 sop:5; > + u8 arg_c_t:1; > + u8 src_t:1; > + u8 dst_t:1; > + }; > + }; > + } __packed; > + > + struct { > + u32 offset_legacy:22; > + u32 subsys_legacy:2; > + } __packed; > }; > u8 op; > }; > @@ -219,10 +228,16 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u8 subsys, u16 offset, u32 value) > { > struct cmdq_instruction inst = { > .op = CMDQ_CODE_WRITE, > - .value = value, > - .offset = offset, > - .subsys = subsys > + .value = value > }; > + > + if (pkt->priv.legacy_isa) { > + inst.offset_legacy = offset; > + inst.subsys_legacy = subsys; > + } else { > + inst.offset = offset; > + inst.subsys = subsys; > + } > return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_write); > @@ -459,10 +474,16 @@ int cmdq_pkt_poll(struct cmdq_pkt *pkt, u8 subsys, > { > struct cmdq_instruction inst = { > .op = CMDQ_CODE_POLL, > - .value = value, > - .offset = offset, > - .subsys = subsys > + .value = value > }; > + > + if (pkt->priv.legacy_isa) { > + inst.offset_legacy = offset; > + inst.subsys_legacy = subsys; > + } else { > + inst.offset = offset; > + inst.subsys = subsys; > + } > return cmdq_pkt_append_command(pkt, inst); > } > EXPORT_SYMBOL(cmdq_pkt_poll); > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h > index 07c1bfbdb8c4..9fcebc4ca864 100644 > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > @@ -72,6 +72,7 @@ struct cmdq_cb_data { > > struct cmdq_mbox_priv { > u8 shift_pa; > + bool legacy_isa; > dma_addr_t mminfra_offset; > }; > >