From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F46C433EF for ; Tue, 5 Jul 2022 17:51:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233141AbiGERvn (ORCPT ); Tue, 5 Jul 2022 13:51:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231346AbiGERvm (ORCPT ); Tue, 5 Jul 2022 13:51:42 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2B7F1B794 for ; Tue, 5 Jul 2022 10:51:40 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id t25so21840047lfg.7 for ; Tue, 05 Jul 2022 10:51:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iKfmYqFl8eXZRKHVQFMy0ij+1ahWYflV52//TH7IUPA=; b=lBt5qQV75xYWQrQSgYHwKy3sRqadvbYfSXLv0NCKs6FjpPeEJHKSkHNAyCzDQtK4v3 +OA96M3OAtGz/CFEjQdyFdh0WrNk7RrDySPWzqdKM9HWkiMuB50R7NcXM0syHQ0bbUKw gK09ZCXz2Hce/Br/O3hKNAYRVRuDvRbT4DD13IncTeHeGbvpGFLVHVXyCiCSGRhyRH8P 30yQbOxHN8jZbDG9Ipas1WRDLAomQdCv6jjk6DvjcjdFB6lAkOjNTlrgQ65RZmFRt2b5 jP8pLBvsG68bWhqhpynIZCaOKbCkCDPLelKGuZ5vcExlJhSuJQ5m5Y27soEDxdU2xdix RPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iKfmYqFl8eXZRKHVQFMy0ij+1ahWYflV52//TH7IUPA=; b=Ll/GfPW6aIo4TqMH+Thcx/zXxBnwfTw+GQ0QYChUGlcGvOLR9qSe4pkg/trM14SYlA HFeWBA1PduGVSoix/rN6k33CXUItrSDlCUAPc0IDVDcwKnRbDajjWZjUFd2tBz7r5qMU hXTMZdaTLxXBAzIKN/l2MECET9QLlov+5FfSH1wf8ejULa5lIIs8BGk20+cbx2kmYxb3 d0I5oH0oVgPFXy7Omb0BYszfDoHMihyb4vm/n4S4IDAskuU/dquz1EomOwgmfNVQK+uR KN+NGGcAh7g+f+CpF9Z3gybfRYCfzax9s/DnaabczBD/WahSVDLh8F5Hmyc+zhjyUXIA FH/w== X-Gm-Message-State: AJIora8i4DRa0jvd+kvMiqtS8qdMQODsClMOdSuepnhprrNUBYhrVj9R nnS9ZZRASKOkBGj1MTA1VuZZTw== X-Google-Smtp-Source: AGRyM1uXuX6zwfwoFhhbvBNBZAlJkQSisF7fAqgBYTrNnpqUXMVJoy+6qqRBQ3DpNgbqSX3UW+RrvQ== X-Received: by 2002:a05:6512:3c86:b0:47f:afe3:f26e with SMTP id h6-20020a0565123c8600b0047fafe3f26emr22622739lfv.173.1657043499223; Tue, 05 Jul 2022 10:51:39 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id m10-20020a19710a000000b0047f68b11329sm5783160lfc.266.2022.07.05.10.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 10:51:38 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 19:51:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/2] [RFT] dt-bindings: leds: Add cznic,turris1x-leds.yaml binding Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek , Rob Herring , Krzysztof Kozlowski , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220705000448.14337-1-pali@kernel.org> <20220705155929.25565-1-pali@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220705155929.25565-1-pali@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 17:59, Pali Rohár wrote: > Add device-tree bindings documentation for Turris 1.x RGB LEDs. The patchset is difficult to find because you attached it to some older thread. Don't. > > Signed-off-by: Pali Rohár > > --- > Changes in v2: > * Fix schema errors > --- > .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > new file mode 100644 > index 000000000000..bcaab5b03128 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/cznic,turris1x-leds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: CZ.NIC's Turris 1.x LEDs driver > + > +maintainers: > + - Pali Rohár > + > +description: > + This module adds support for the RGB LEDs found on the front panel of the > + Turris 1.x routers. There are 8 RGB LEDs that are controlled by CZ.NIC CPLD > + firmware running on Lattice FPGA. Firmware is open source and available at > + https://gitlab.nic.cz/turris/hw/turris_cpld/-/blob/master/CZ_NIC_Router_CPLD.v > + > +properties: > + compatible: > + const: cznic,turris1x-leds > + > + reg: > + description: CPLD address range where LED registers are mapped > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-7]$": > + type: object > + $ref: leds-class-multicolor.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + minimum: 0 > + maximum: 7 > + > + required: > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + cpld@3,0 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x3 0x0 0x00020000>; > + > + led-controller@13 { > + compatible = "cznic,turris1x-leds"; > + reg = <0x13 0x1d>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + multi-led@0 { > + reg = <0x0>; You have some weird indentation here. In other places of DTS example it is correct four spaces, so here should be four spaces as well. Best regards, Krzysztof