Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: webgeek1234@gmail.com, Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Teguh Sobirin <teguh@sobir.in>
Subject: Re: [PATCH v8 6/6] arm64: dts: qcom: Add AYN Thor
Date: Wed, 17 Jun 2026 12:55:03 +0200	[thread overview]
Message-ID: <ec16c184-2e0d-4f9f-af9c-d551fc114754@oss.qualcomm.com> (raw)
In-Reply-To: <20260503-ayn-qcs8550-v8-6-d733f5e57446@gmail.com>

On 5/3/26 11:48 PM, Aaron Kling via B4 Relay wrote:
> From: Teguh Sobirin <teguh@sobir.in>
> 
> The AYN Thor is a high-performance Android-based handheld gaming console
> powered by the Qualcomm Snapdragon 8 Gen 2 processor featuring dual
> AMOLED touchscreens.
> 
> Signed-off-by: Teguh Sobirin <teguh@sobir.in>
> Co-developed-by: Aaron Kling <webgeek1234@gmail.com>
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---

[...]

> +&i2c4 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";

'status' is generally meant to be the last property
> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;

especially since these ones are already defined in the included SoC DTSI
(and would only be necessary when building a DTBO, which I know is your
ultimate usecase, but which you aren't doing in this patch)

Perhaps Bjorn can fix that up while applying..

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-06-17 10:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 21:48 [PATCH v8 0/6] arm64: dts: qcom: Support AYN QCS8550 Devices Aaron Kling via B4 Relay
2026-05-03 21:48 ` [PATCH v8 1/6] dt-bindings: vendor-prefixes: Add AYN Technologies Aaron Kling via B4 Relay
2026-05-03 21:48 ` [PATCH v8 2/6] dt-bindings: arm: qcom: Add AYN QCS8550 Devices Aaron Kling via B4 Relay
2026-05-03 21:48 ` [PATCH v8 3/6] arm64: dts: qcom: Add AYN QCS8550 Common Aaron Kling via B4 Relay
2026-06-17 10:52   ` Konrad Dybcio
2026-05-03 21:48 ` [PATCH v8 4/6] arm64: dts: qcom: Add AYN Odin 2 Mini Aaron Kling via B4 Relay
2026-05-03 21:48 ` [PATCH v8 5/6] arm64: dts: qcom: Add AYN Odin 2 Portal Aaron Kling via B4 Relay
2026-05-03 21:48 ` [PATCH v8 6/6] arm64: dts: qcom: Add AYN Thor Aaron Kling via B4 Relay
2026-06-17 10:55   ` Konrad Dybcio [this message]
2026-06-02  4:53 ` [PATCH v8 0/6] arm64: dts: qcom: Support AYN QCS8550 Devices Aaron Kling
2026-06-18 14:01 ` (subset) " Neil Armstrong
2026-06-18 14:02   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec16c184-2e0d-4f9f-af9c-d551fc114754@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=teguh@sobir.in \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox