From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB5BEB64DC for ; Tue, 18 Jul 2023 18:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230404AbjGRSms (ORCPT ); Tue, 18 Jul 2023 14:42:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjGRSmr (ORCPT ); Tue, 18 Jul 2023 14:42:47 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99A36E8 for ; Tue, 18 Jul 2023 11:42:45 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-98df3dea907so779799566b.3 for ; Tue, 18 Jul 2023 11:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689705764; x=1692297764; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YWDxOdiEo182qQTrdfRT1NqU4AQWgKjDTPUDJMk0vho=; b=oM+zaRthwE4f1r8MkTbNFtjNtHOKecZtu+MAMEo0rp8+TxOC3AczvBqG74Wq+XGe9z ayeOGgPv2iSjCSC8JS5AVBnqntVcodyk/VvMSJcBHxiwtRRRKP8HOHgSTxwGw9NsxM+m 5/ePv26ZjawWFhwQDjYTAvkA+/BdJCX7wz94mKhpWSUunUZJRDl68l6SlNJhOooMXDhK XkRWgjaFHT5joJWlLLpy1vAFUwgB5jnxpZgcLbNQSlwYyLWOfTzekB0N8u/VAYKEXkBM O2UgCYLq1kiV3oAlEcxVRALJhxZtPQPtsuXsq1zYPeIwAEO4NNkQvPK8g8kNcWcsinm3 3B2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689705764; x=1692297764; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YWDxOdiEo182qQTrdfRT1NqU4AQWgKjDTPUDJMk0vho=; b=AWlfuSmsVqWbCxNKJ8aTa7n7NPaCJlls809mTr381dGujy1okPR1bT7lU4Er+cnA7c enoTt9EZe8WiaOjuXDn1eD+2PTIvvnhsfuTxo/ufbQ7kp7SZfhPO8J8i9wZH4NinuUhT 1/O1a+amh2XvNvrIa5OZC/f7mXB4TmOIKMB9QkeVgZXgfxtPoQuEbdqpj2IUYVGdN3dV PhfjaMwQLujID1frEqnj2kAMMamrShyTW4FN4Z5MSs0FAINlEIKfU4L3KyP+5CRByGFD KOs9JzW9MYX+6ZHzhBVOL1zFwXHEm3A3O3KzL1CnkkR+BR2EPr1PZHfPkOuNYeOsqNjF NJOA== X-Gm-Message-State: ABy/qLZQyV6i2emMp4GgOQ4rkhDdYoQ8lpjeMJYXHMfrkzzgR68W0W7W 64nd7S3rrjcwriJsV7jyJx9jwA== X-Google-Smtp-Source: APBJJlHwuALuQ2dnZX9w3l3xk/u5CDjDpB+cpbIhy0GLp1XygrSwSlaoo21eYMhJ9yJm12JZwn9kMw== X-Received: by 2002:a17:907:78cf:b0:994:2fa9:7444 with SMTP id kv15-20020a17090778cf00b009942fa97444mr641821ejc.42.1689705764057; Tue, 18 Jul 2023 11:42:44 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id rp25-20020a170906d97900b009786ae9ed50sm1309961ejb.194.2023.07.18.11.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 11:42:43 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 20:42:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] firmware: arm_scmi: Add qcom hvc/shmem transport Content-Language: en-US To: Nikunj Kela , sudeep.holla@arm.com Cc: cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230718160833.36397-3-quic_nkela@quicinc.com> <3ae2d618-490a-06da-b4b6-b5a24b0a9747@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <3ae2d618-490a-06da-b4b6-b5a24b0a9747@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2023 20:25, Nikunj Kela wrote: >>> + >>> + scmi_info = devm_kzalloc(dev, sizeof(*scmi_info), GFP_KERNEL); >>> + if (!scmi_info) >>> + return -ENOMEM; >>> + >>> + np = of_parse_phandle(cdev->of_node, "shmem", 0); >>> + if (!of_device_is_compatible(np, "arm,scmi-shmem")) >> You leak here reference. > Wouldn't the devm_* API take care of that implicitly? It is same in > smc.c as well. Thanks for bringing my attention to this. I sent a fix for smc.c. Fix your patch as well, please. >>> + return -ENXIO; >>> + >>> + ret = of_address_to_resource(np, 0, &res); >>> + of_node_put(np); >>> + if (ret) { >>> + dev_err(cdev, "failed to get SCMI Tx shared memory\n"); >>> + return ret; >>> + } >>> + >>> + size = resource_size(&res); >>> + >>> + /* let's map 2 additional ulong since >>> + * func-id & capability-id are kept after shmem. >>> + * +-------+ >>> + * | | >>> + * | shmem | >>> + * | | >>> + * | | >>> + * +-------+ <-- size >>> + * | funcId| >>> + * +-------+ <-- size + sizeof(ulong) >>> + * | capId | >>> + * +-------+ <-- size + 2*sizeof(ulong) >>> + */ >>> + >>> + scmi_info->shmem = devm_ioremap(dev, res.start, >>> + size + 2 * sizeof(unsigned long)); >>> + if (!scmi_info->shmem) { >>> + dev_err(dev, "failed to ioremap SCMI Tx shared memory\n"); >>> + return -EADDRNOTAVAIL; >>> + } >>> + >>> + func_id = readl((void *)(scmi_info->shmem) + size); >>> + >>> +#ifdef CONFIG_ARM64 >>> + cap_id = readq((void *)(scmi_info->shmem) + size + >>> + sizeof(unsigned long)); >>> +#else >>> + cap_id = readl((void *)(scmi_info->shmem) + size + >>> + sizeof(unsigned long)); >>> +#endif >>> + >>> + /* >>> + * If there is an interrupt named "a2p", then the service and >>> + * completion of a message is signaled by an interrupt rather than by >>> + * the return of the hvc call. >>> + */ >>> + irq = of_irq_get_byname(cdev->of_node, "a2p"); >>> + if (irq > 0) { >>> + ret = devm_request_irq(dev, irq, qcom_hvc_msg_done_isr, >>> + IRQF_NO_SUSPEND, >>> + dev_name(dev), scmi_info); >>> + if (ret) { >>> + dev_err(dev, "failed to setup SCMI completion irq\n"); >> return dev_err_probe, unless this is not called in probe... but then >> using devm-interface raises questions. > This is copied as is from existing smc.c I understand and I hope you understand the code you copied. If there is a bug in existing code, please do not copy it to new code (like leaking OF node reference). Best regards, Krzysztof