From: Robin Murphy <robin.murphy@arm.com>
To: Heiko Stuebner <heiko@sntech.de>, dri-devel@lists.freedesktop.org
Cc: thierry.reding@gmail.com, sam@ravnborg.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, mark.rutland@arm.com,
christoph.muellner@theobroma-systems.com,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH 3/3] drm/panel: add panel driver for Elida KD35T133 panels
Date: Mon, 24 Feb 2020 15:06:11 +0000 [thread overview]
Message-ID: <ec42b04a-4727-cbd4-d0c4-21a8def8abd0@arm.com> (raw)
In-Reply-To: <20200223150711.194482-3-heiko@sntech.de>
On 23/02/2020 3:07 pm, Heiko Stuebner wrote:
[...]
> +#define dsi_generic_write_seq(dsi, cmd, seq...) do { \
> + static const u8 d[] = { seq }; \
> + int ret; \
> + ret = mipi_dsi_dcs_write(dsi, cmd, d, ARRAY_SIZE(d)); \
Nit: in the rocktech driver, dsi_generic_write_seq() is wrapping
mipi_dsi_generic_write() which seems logically self-consistent.
Therefore shouldn't this wrapper be called something like
dsi_dcs_write_seq()? I have no idea what any of this actually means, but
the dissonance is enough to make my reviewer-sense tingle ;)
Robin.
> + if (ret < 0) \
> + return ret; \
> + } while (0)
next prev parent reply other threads:[~2020-02-24 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 15:07 [PATCH 1/3] dt-bindings: Add vendor prefix for Elida Heiko Stuebner
2020-02-23 15:07 ` [PATCH 2/3] dt-bindings: display: panel: Add binding document for Elida KD35T133 Heiko Stuebner
2020-02-23 15:07 ` [PATCH 3/3] drm/panel: add panel driver for Elida KD35T133 panels Heiko Stuebner
2020-02-24 15:06 ` Robin Murphy [this message]
2020-02-25 10:49 ` Francesco Lavra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec42b04a-4727-cbd4-d0c4-21a8def8abd0@arm.com \
--to=robin.murphy@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).