Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615 support

Alex Elder
2026-05-03T02:23:43Z

On 5/2/26 9:14 PM, Jakub Kicinski wrote:
> On Sat, 2 May 2026 21:06:33 -0500 Alex Elder wrote:
>>> drivers/misc/tc956x_pci.c:541:17: error: call to undeclared function 'u32_get_bits'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>>> 541 | chip->rev_id = u32_get_bits(val, NCID_REV_ID_MASK);
>>> | ^
>>
>> Yeah I think I noticed an error like that shows up with 32-bit builds?
>> In any case we didn't see it during development, and we'll make sure
>> <linux/bitfield.h> gets included.
>
> on x86 it hits on all configs, I suspected you're building for ARM?

Yes. I'll spend a little more time trying to build on other
architectures. I normally like to add COMPILE_TEST.

-Alex