Re: [PATCH net-next 11/12] misc: tc956x_pci: add TC956x/QPS615 support

Alex Elder
2026-05-03T02:06:38Z

On 5/2/26 11:45 AM, Jakub Kicinski wrote:
> On Fri, 1 May 2026 10:54:19 -0500 Alex Elder wrote:
>> The Toshiba TC956x is an Ethernet AVB/TSN bridge, and is
>> essentially a small and highly-specialized SoC. It implements
>> a number of internal functions, including a GPIO controller,
>> control registers managing internal reset and clock control
>> signals, a PCIe switch and internal endpoint, and mapping
>> hardware that translates between PCIe and internal addressing.
>
> drivers/misc/tc956x_pci.c:541:17: error: call to undeclared function 'u32_get_bits'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 541 | chip->rev_id = u32_get_bits(val, NCID_REV_ID_MASK);
> | ^

Yeah I think I noticed an error like that shows up with 32-bit builds?
In any case we didn't see it during development, and we'll make sure
<linux/bitfield.h> gets included.

Thanks.

-Alex