Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support

Xilin Wu
2026-05-06T02:31:04Z

On 5/1/2026 11:54 PM, Alex Elder wrote:
> From: Daniel Thompson <daniel@riscstar.com>
>
> Toshiba TC956x is an Ethernet AVB/TSN bridge and is essentially a
> small and highly-specialized SoC. TC956x includes an "eMAC" subsystem
> that can be accessed, along with several other peripherals, via two
> PCIe endpoint functions. There is a main driver for the endpoint that
> decomposes things and creates auxiliary bus devices to model the SoC.
>
> The eMAC consists of a Designware XGMAC, XPCS and PMA. Each eMAC is
> supported by an MSIGEN that bridges TC956x level interrupts to PCIe
> MSIs.
>
> Add a driver for the eMAC/MSIGEN combination.
>
> Co-developed-by: Alex Elder <elder@riscstar.com>
> Signed-off-by: Alex Elder <elder@riscstar.com>
> Signed-off-by: Daniel Thompson <daniel@riscstar.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 13 +
> drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +
> .../ethernet/stmicro/stmmac/dwmac-tc956x.c | 791 ++++++++++++++++++
> include/soc/toshiba/tc956x-dwmac.h | 84 ++
> 4 files changed, 890 insertions(+)
> create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-tc956x.c
> create mode 100644 include/soc/toshiba/tc956x-dwmac.h
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index e3dd5adda5aca..66bcfaccbe21f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -404,6 +404,19 @@ config DWMAC_MOTORCOMM
> This enables glue driver for Motorcomm DWMAC-based PCI Ethernet
> controllers. Currently only YT6801 is supported.
>
> +config DWMAC_TC956X
> + tristate "Toshiba TC956X DWMAC support"
> + depends on PCI
> + depends on COMMON_CLK
> + depends on TOSHIBA_TC956X_PCI
> + default m if TOSHIBA_TC956X_PCI

Hi Alex,

I think GENERIC_IRQ_CHIP should be selected here.

Thank you for the driver.

--
Best regards,
Xilin Wu <sophon@radxa.com>