Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support

Andrew Lunn
2026-05-06T14:20:45Z

On Wed, May 06, 2026 at 08:59:01PM +0800, Xilin Wu wrote:
> On 5/1/2026 11:54 PM, Alex Elder wrote:
> > + /* AXI Configuration */
> > + axi = &td->axi;
> > + axi->axi_lpi_en = 1;
> > + axi->axi_wr_osr_lmt = 31;
> > + axi->axi_rd_osr_lmt = 31;
> > + /* All sizes (2^2..2^8) are supported */
> > + axi->axi_blen_regval = DMA_AXI_BLEN_MASK;
> > + plat->axi = axi;
> > +
> > + plat->mac_port_sel_speed = speed;
> > + plat->flags = STMMAC_FLAG_MULTI_MSI_EN | STMMAC_FLAG_TSO_EN;
>
> I got WoL working only after adding STMMAC_FLAG_USE_PHY_WOL here. I guess
> it's required, since the driver clocks down the MAC/PMA/XPCS in its suspend
> hook?

Nice to see somebody testing WoL.

In your testing, is it the PHY doing the WoL, or the MAC? I assume
PHY.

If i remember the DT correctly, the PHY interrupt is connected to a
SoC GPIO, not a GPIO of this chip. So for your board, it is the SoCs
GPIO controllers ability to perform the wake which is
important. However, where the PHY interrupt is connected is a board
design issue. Could the PHY interrupt be connected to the chip? Would
the chip be able to wake the system? Should STMMAC_FLAG_USE_PHY_WOL be
conditional?

Andrew