Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support

Alex Elder
2026-05-05T16:46:18Z

On 5/5/26 11:38 AM, Mohd Ayaan Anwar wrote:
> Hi Alex,
> On Fri, May 01, 2026 at 10:54:18AM -0500, Alex Elder wrote:
>
>> + /*
>> + * TX956x has 8 TX queues but only #0 to #3 work for general IP traffic.
>
> Minor typo in the comment: I think you meant TC956X instead of TX956X?

Yes, I'll fix that.

>> + for (i = 0; i < td->plat->rx_queues_to_use; i++) {
>> + res->rx_irq[i] = irq_create_mapping(irq_domain, HWIRQ_RX0 + i);
>> + if (!res->tx_irq[i])
>
> Typo: res->rx_irq instead of res->tx_irq.

Wow, that's important... Fortunately we haven't been getting errors.

This will be fixed.

> PS: I was able to successfully test this series out on a Rb3Gen2 board.

Great! Thank you.

-Alex

> Ayaan