From: Krzysztof Kozlowski <krzk@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen Wang <unicorn_wang@outlook.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Vinod Koul <vkoul@kernel.org>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Yu Yuan <yu.yuan@sjtu.edu.cn>, Ze Huang <huangze@whut.edu.cn>,
Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
Junhui Liu <junhui.liu@pigmoral.tech>,
devicetree@vger.kernel.org, sophgo@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
dmaengine@vger.kernel.org, Yixun Lan <dlan@gentoo.org>,
Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support
Date: Wed, 11 Jun 2025 11:09:50 +0200 [thread overview]
Message-ID: <ec60631a-7e55-4dc0-83f7-6e6cb156dbf2@kernel.org> (raw)
In-Reply-To: <2v4hfzqgz22k6s776onexnhd5cnhfr7s7ggvcmh4mfiviigq66@a2ehkwbv7oll>
On 11/06/2025 10:29, Inochi Amaoto wrote:
> On Wed, Jun 11, 2025 at 10:19:49AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Jun 11, 2025 at 03:53:15PM GMT, Inochi Amaoto wrote:
>>> Add bindings for the reset generator on the SOPHGO CV1800B
>>> RISC-V SoC.
>>>
>>> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>> Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>>> index 1d1b84575960..bd8dfa998939 100644
>>> --- a/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/sophgo,sg2042-reset.yaml
>>> @@ -17,6 +17,7 @@ properties:
>>> - sophgo,sg2044-reset
>>> - const: sophgo,sg2042-reset
>>> - const: sophgo,sg2042-reset
>>> + - const: sophgo,cv1800b-reset
>>
>> Keep alphabetical order. That's enum with previous entry, btw.
>>
>
> There is a small question for this: should I move this before the entry
> "const: sophgo,sg2042-reset", or before the first item entry?
It does not matter where you place the enum. There is no convention for
that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-11 9:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 7:53 [PATCH v3 0/4] riscv: sophgo: cv18xx: Add reset generator support Inochi Amaoto
2025-06-11 7:53 ` [PATCH v3 1/4] dt-bindings: reset: sophgo: Add CV1800B support Inochi Amaoto
2025-06-11 8:19 ` Krzysztof Kozlowski
2025-06-11 8:21 ` Krzysztof Kozlowski
2025-06-11 8:23 ` Inochi Amaoto
2025-06-11 8:29 ` Inochi Amaoto
2025-06-11 9:09 ` Krzysztof Kozlowski [this message]
2025-06-11 9:45 ` Inochi Amaoto
2025-06-11 7:53 ` [PATCH v3 2/4] reset: simple: add support for Sophgo CV1800B Inochi Amaoto
2025-06-15 15:39 ` Alexander Sverdlin
2025-06-11 7:53 ` [PATCH v3 3/4] riscv: dts: sophgo: add reset generator for Sophgo CV1800 series SoC Inochi Amaoto
2025-06-11 10:07 ` Junhui Liu
2025-06-15 15:39 ` Alexander Sverdlin
2025-06-11 7:53 ` [PATCH v3 4/4] riscv: dts: sophgo: add reset configuration " Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec60631a-7e55-4dc0-83f7-6e6cb156dbf2@kernel.org \
--to=krzk@kernel.org \
--cc=alex@ghiti.fr \
--cc=alexander.sverdlin@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=dmaengine@vger.kernel.org \
--cc=huangze@whut.edu.cn \
--cc=inochiama@gmail.com \
--cc=junhui.liu@pigmoral.tech \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=looong.bin@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sophgo@lists.linux.dev \
--cc=thomas.bonnefille@bootlin.com \
--cc=unicorn_wang@outlook.com \
--cc=vkoul@kernel.org \
--cc=yu.yuan@sjtu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox