From: Krzysztof Kozlowski <krzk@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Masato Kiuchi <kiuchi_masato@yuridenki.co.jp>
Subject: Re: [PATCH 4/4] arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai Kakip board
Date: Wed, 15 Jan 2025 09:36:46 +0100 [thread overview]
Message-ID: <ec99af75-8f53-44c8-b8d1-e42ca693bc76@kernel.org> (raw)
In-Reply-To: <CAMuHMdVsHrcWdc2LD=F1keJg0ZPgq19g3uZEgFGs499SQhCd2w@mail.gmail.com>
On 14/01/2025 14:44, Geert Uytterhoeven wrote:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
>>
>>> + compatible = "regulator-fixed";
>>> +
>>> + regulator-name = "fixed-3.3V";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vqmmc_sdhi0: regulator-vccq-sdhi0 {
>>
>> regulator-2? Why different styles of names?
>
> ... i.e. no numbered regulators, as these tend to cause hard-to-debug
> conflicts.
"regulator-vccq-sdhi0" also works for me, because the recommended
pattern might have name conflicts, but then please keep the style across
all of them in this patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-15 8:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 8:08 [PATCH 0/4] Add support Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
2025-01-11 8:09 ` [PATCH 1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H SoC variants Nobuhiro Iwamatsu
2025-01-11 9:31 ` Krzysztof Kozlowski
2025-01-11 8:09 ` [PATCH 2/4] dt-bindings: vendor-prefixes: Add Yuridenki-Shokai Co. Ltd Nobuhiro Iwamatsu
2025-01-11 9:31 ` Krzysztof Kozlowski
2025-01-11 8:09 ` [PATCH 3/4] dt-bindings: soc: renesas: Document Yuridenki-Shokai Kakip board Nobuhiro Iwamatsu
2025-01-11 9:32 ` Krzysztof Kozlowski
2025-01-14 13:31 ` Nobuhiro Iwamatsu
2025-01-11 8:09 ` [PATCH 4/4] arm64: dts: renesas: Add initial device tree for " Nobuhiro Iwamatsu
2025-01-11 9:34 ` Krzysztof Kozlowski
2025-01-14 13:34 ` Nobuhiro Iwamatsu
2025-01-14 13:44 ` Geert Uytterhoeven
2025-01-15 8:36 ` Krzysztof Kozlowski [this message]
2025-01-16 14:24 ` Nobuhiro Iwamatsu
2025-01-13 9:41 ` [PATCH 0/4] Add support " Geert Uytterhoeven
2025-01-14 13:45 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec99af75-8f53-44c8-b8d1-e42ca693bc76@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=iwamatsu@nigauri.org \
--cc=kiuchi_masato@yuridenki.co.jp \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).