Re: [PATCH v2 1/2] media: dt-bindings: i2c: toshiba,et8ek8: Convert to DT schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/12/2025 09:57, Alex Tran wrote:
> On Thu, Dec 25, 2025 at 12:40 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 24/12/2025 22:59, Alex Tran wrote:
>>> +
>>> +  reset-gpios:
>>> +    description:
>>> +      XSHUTDOWN GPIO. The XSHUTDOWN signal is active low. The sensor
>>> +      is in hardware standby mode when the signal is in the low state.
>>> +    maxItems: 1
>>> +
>>> +  flash-leds: true
>>> +  lens-focus: true
>>
>> No, where did you find this syntax. I do not see how you carefully fixed
>> it. You need proper schema for these.
>>
>> Best regards,
>> Krzysztof
> 
> I saw it used under sony,imx214.yaml and mipi-ccs.yaml. I thought referencing
> video-interface-devices.yaml in this schema was correct because the flash-leds
> and lens-focus properties are both specified in that file.

Ah, so you wanted to reference video-inteface-devices in top-level?
Wasn't this already before? If that was missing then that's another
thing to fix.

And then you need to use unevaluatedProperties: false. flash-leds needs
constraints, number of items. lens-focus you simply remove.

Best regards,
Krzysztof