From: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
To: Mark Brown <broonie@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>, <swboyd@chromium.org>,
<collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
Das Srinagesh <gurus@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>,
"Lee Jones" <lee.jones@linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC
Date: Mon, 20 Dec 2021 16:14:29 +0530 [thread overview]
Message-ID: <ec9eddf5-aba2-d63b-0e39-1a3d5bda3ce9@quicinc.com> (raw)
In-Reply-To: <Ya4nn0/qp5El8P0L@sirena.org.uk>
On 12/6/2021 8:39 PM, Mark Brown wrote:
> On Mon, Dec 06, 2021 at 08:13:57PM +0530, Satya Priya Kakitapalli (Temp) wrote:
>> On 11/25/2021 9:15 PM, Mark Brown wrote:
>>> On Fri, Nov 19, 2021 at 03:12:31PM +0530, Satya Priya wrote:
>>>> + child_node = of_get_child_by_name(parent_node, reg->name);
>>>> + if (!child_node) {
>>>> + dev_err(dev, "child node %s not found\n", reg->name);
>>>> + return -ENODEV;
>>>> + }
>>> This could be pulled out of the array.
>> Not sure what you meant here. could you elaborate a bit?
> Why is this in every iteration of the loop?
Getting the child node here is not required anymore. This got carried
from previous versions, I'll remove this.
next prev parent reply other threads:[~2021-12-20 10:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 9:42 [PATCH V4 0/6] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2021-11-19 9:42 ` [PATCH V4 1/6] dt-bindings: regulator: Add "regulator-min-dropout-voltage-microvolt" Satya Priya
2021-11-25 15:17 ` Mark Brown
2021-12-06 13:03 ` Satya Priya Kakitapalli (Temp)
2021-12-06 18:25 ` Mark Brown
2021-12-07 15:06 ` Satya Priya Kakitapalli (Temp)
2021-12-07 15:19 ` Mark Brown
2021-12-09 0:56 ` David Collins
2021-12-10 21:11 ` Mark Brown
2022-01-03 14:35 ` Satya Priya Kakitapalli (Temp)
2022-01-04 14:54 ` Mark Brown
2021-11-19 9:42 ` [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator bindings Satya Priya
2021-11-25 15:24 ` Mark Brown
2021-12-06 13:43 ` Satya Priya Kakitapalli (Temp)
2021-12-06 13:47 ` Mark Brown
2021-12-20 12:44 ` Satya Priya Kakitapalli (Temp)
[not found] ` <07dc5ba4-790b-0cb2-bc3e-2ce8d7e3e09d@quicinc.com>
2022-01-10 14:21 ` Mark Brown
2022-01-11 12:15 ` Satya Priya Kakitapalli (Temp)
2022-01-11 13:59 ` Mark Brown
2021-11-19 9:42 ` [PATCH V4 3/6] dt-bindings: mfd: pm8008: Add pm8008 regulator node Satya Priya
2021-11-19 9:42 ` [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2021-11-25 15:45 ` Mark Brown
2021-12-06 14:43 ` Satya Priya Kakitapalli (Temp)
2021-12-06 15:09 ` Mark Brown
2021-12-20 10:44 ` Satya Priya Kakitapalli (Temp) [this message]
2021-11-19 9:42 ` [PATCH V4 5/6] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2021-11-19 9:42 ` [PATCH V4 6/6] arm64: dts: qcom: sc7280: Add pm8008 regulators support for sc7280-idp Satya Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9eddf5-aba2-d63b-0e39-1a3d5bda3ce9@quicinc.com \
--to=quic_c_skakit@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).