From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C55CC77B7C for ; Wed, 31 May 2023 07:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234952AbjEaHzn (ORCPT ); Wed, 31 May 2023 03:55:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235258AbjEaHz1 (ORCPT ); Wed, 31 May 2023 03:55:27 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75763172A for ; Wed, 31 May 2023 00:54:04 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-51496f57e59so5234788a12.2 for ; Wed, 31 May 2023 00:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685519640; x=1688111640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=suMN4n1BQ2Z7VU4EicsbwuyOBR1pEV+6Sounu4iuM0U=; b=A+dncCJbXSV6kSVPSolkbyxdvYQgh78/2P6Mxm5SwqhtgIwtPGJcWPOCn2HHPS8CZU 5Wm6uBWJvU48wgmG5ogwKoX1rNY5Z4RvNjhYSfdKVup3NWmYut1ny6EzBC/0KBEdFYZG xojVvnM2ROqLlEAcS9yaN4/6x6eWoBszGXQOpJIHAvRGhkMWrxnPPLFGhWYVSsSGeEN9 2H039xpBhxvO9MhPMs3niA9LdSl3yS9GN3cvnO02PehmLZyf7Z3iF22kZ2fJ0LQ6a+6r o7q7EgJVKnuR6VScDRFC0YASfU8S/WZdZZm5f5DystD06dKFWoX6h19/bkbktB7qdXFQ NluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519640; x=1688111640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suMN4n1BQ2Z7VU4EicsbwuyOBR1pEV+6Sounu4iuM0U=; b=XEtuilQBV0HTAz8ewj+nTxJqrQHOnh063pIG0KuCJC4IAQQYg/22xJJS9VI3WAcDHP RudUKSX4I+liA16m/vS3XOy5D0y+6se2iy9WIcDDwHlQxUeT4s8CVTsWTc4eSgqBkY2x 6xxVtukeYmEiPnePsrTfeOlEZs/ZsPEttd1O/aRm/6R5BSy43wyhyJB8ZP55+vlVIueJ bJGXw6NDTV6JRORDRVaW07VZdBnJJxqQoXAOuFUumvLFK7HCocHKP3/hVIOzqJDe2GMa lrtCSzvFyPbNMG0PIW4C6i8j8UiCfaxrR7j1Xv4un4H0yDSpPrOmVkM46+jZAtsPnATl H0gQ== X-Gm-Message-State: AC+VfDxZUnVCZFGH1OqpxYA7WeAPsfktPTurYUM0eOCqO0q7YMDELZld 4fmwEk4+ZI48LX2gvqVDFPhgQA== X-Google-Smtp-Source: ACHHUZ7i7M8zh8gh6sQ1ZK5S6VAQvpJeaDVE/ihPO9ya44BVZ1jGFqvdF+9ycji5LoT7N7p0i74PDw== X-Received: by 2002:a17:907:d8a:b0:973:d1ce:dbe8 with SMTP id go10-20020a1709070d8a00b00973d1cedbe8mr5163876ejc.46.1685519640052; Wed, 31 May 2023 00:54:00 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id ce23-20020a170906b25700b0096f8bb60c96sm8511314ejb.100.2023.05.31.00.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 00:53:59 -0700 (PDT) Message-ID: Date: Wed, 31 May 2023 09:53:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding to yaml To: Conor Dooley , matthias.bgg@kernel.org Cc: rafael@kernel.org, Daniel Lezcano , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, Amit Kucheria , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Zhang Rui , linux-arm-kernel@lists.infradead.org, Matthias Brugger References: <20230530150413.12918-1-matthias.bgg@kernel.org> <20230530-thaw-unpaved-a1708d46eb5a@spud> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230530-thaw-unpaved-a1708d46eb5a@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/05/2023 00:02, Conor Dooley wrote: > Hey Matthias, > > On Tue, May 30, 2023 at 05:04:12PM +0200, matthias.bgg@kernel.org wrote: > >> + The MediaTek thermal controller measures the on-SoC temperatures. >> + This device does not have its own ADC, instead it directly controls >> + the AUXADC via AHB bus accesses. For this reason this device needs >> + phandles to the AUXADC. Also it controls a mux in the apmixedsys >> + register space via AHB bus accesses, so a phandle to the APMIXEDSYS >> + is also needed. > > That double "also" bothers my OCD greatly, but it is a faithful > conversion. > >> + "#thermal-sensor-cells": >> + const: 1 > >> -- #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description. > > How come this has changed? I didn't see an explanation for it in either > of the patches. Yep. Please mention the deviations from pure conversion and if not obvious - justify them. Best regards, Krzysztof