From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE8C31196B for ; Thu, 28 Aug 2025 13:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756387509; cv=none; b=H/A/bBPhpbLLtQmkxgxS/ESgoNd5W+02FwhzIVPZJJQ5V2V/lv00R0u90lT4VHUTVGzOmxNQ7MnnS9zn9zW8WApuplNu93x7P+rztymJ1va7/t5j+dAp3clfLNoKHU7ZTAkdXQ88fSgTb4QSMNG0LgkMRkDjsFjOXNC6Ej4BBfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756387509; c=relaxed/simple; bh=Hx62hC2efafCdbQDxHi2B7OiIdyW02BYTfvtgOt7YqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q2fNlk1t5bzU+tryjMmvmNGtBiK5Z+e8N4Gu9ic8MVNhodAi6SHscJbWXwWRFWfimTOSSTU1CW2xN8k3FQ1HT7NakgHAYpGs/ibEl4LBmZtMPKpaS4aig5DtrwAPJZ7glOLiSUHQBfLQ37zIpgHnM/AzBz8AR+P3E7L3UrzJwsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bAZTLsHO; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bAZTLsHO" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-afcb7a8dd3dso63442066b.3 for ; Thu, 28 Aug 2025 06:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756387506; x=1756992306; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=bAZTLsHO/Ek0iJUlU9+BwBvPmcc66TMQHGAezBrvw612q33DXdmoSIsAgzm4j3dlkm p7HtmNg6Lupz32URTUJBZSODp/eWybdEK3dIAHP+PkhxCRPGqZaxLRyDcOfC8/CWTNFK I35rFlORfP8G4dYCd+i+oo6L7MDidxJcbJrj8aj1YfWyUODCRgbqh1Swmj94DUmhEcGa OeSrPfiNxZ4Bg6pJJpW1OB8F+e2dWeoQCJGqjJlKSOcKFF8wuU07AoHV0zh50ufGqSIw /9r9no2ATg2pudkbron5FcNnVhwF2WH0EPB9v8xo9cFvX7Sskm8+x1UrtHdR3yQ5k2fI Yoxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756387506; x=1756992306; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KP6GeI4QNlyVzRWNe4PL6HeP+siA3vt2wqk6FJm5c6M=; b=ZEo+VdGaeDxC5IXApT/VhwETUzfkLpkW24/oiEZ0a5Khvei1nxF/LKCSEk/4JqbdeA DM4HmwlnL7wkWRyy4LSPK+kiZb+aNdjt3dPeDlsi9eI7mtFLp1te4cEDhxHFBvq8Ot6H R7TgsBOmHbgumAe8+SnfUWq/Mrx75o6rrGWPsLuAeYKmK4+OeAxZ71VhndVhfWlSADvJ RzjBCOuCsV56BUc9lnCIbP/XRJbSAW6X7KrNmVvlXsZ845lmnfqU+gspw26CXBr1JYEU M/e0gRhfWTp9hEb2gOBaptbJG44Ktrv6w8XDnjwKXbYLncdmMz93B/yXfAzDpixHR84M 2Mlw== X-Forwarded-Encrypted: i=1; AJvYcCVUWGU591ci3ArNedarLWNfjJPAnQY1vj09HKIN1dl098IAOzhacVFcTiI6KZ6zH1FihLCILCX7nMFs@vger.kernel.org X-Gm-Message-State: AOJu0YwrVnSNQ6nLnSNuE834UHWq1Ktt0AuVJNGC+fZ2YNqPrJLWJJMi NWTuUPGs6qmjP2ZTgVtCO+skQ5vAX1YC3ggIKXF7dvgVNmzQnJiU3mOxeHKBpNmzdL4= X-Gm-Gg: ASbGncvp9w/WA25TSrZNOpGxuTeyIH53KluQ5IeH8D6KT9GFQLdJ3Ia0tRPpEOwgk6V GkI1AfGMXWzHCxa/TnAaebmeYTi2AoglG4gZLHGbmRA/CQVZ+BqnsYlJlRnr/Gudkpuq1jWh/2A ZT9POVbfgSG2IdgwFs68ajE7Doi+zikPqKGnImI1EJ4x2D9W4RUTBaTYVhwdV5r+WhpBFdk3LX8 okTp7TizhbtjM3bD5pIfx+r5DSx1C3/nq/8/He1KYhR+kJPieo0HDGmkcEMurONafr/os60+wXr am0iadFxj/OIFQISl+CPkvNIjPc9gUhkqP90+cfOoufxgP/XjnfMQ3Z7E+6o3exyTFKkdMMEtmE 32KKyyVyUbU/nTENVdftVGYK3H+lXJCusKIhSGJ/JuVUPnSJbevKeSHfs2JrUXEtmwpFdfXrt1P iiiw== X-Google-Smtp-Source: AGHT+IHnstlza8K9C5w6vOWcSWmYNQEhQr+qMHGXGhuf3pnVngAd6eVaQO3IZGsyPfF2zyp3aTQhtA== X-Received: by 2002:a17:907:968c:b0:afd:d9e4:51e7 with SMTP id a640c23a62f3a-afe296bceabmr2217290166b.63.1756387505863; Thu, 28 Aug 2025 06:25:05 -0700 (PDT) Received: from [10.41.150.230] ([77.241.232.9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe79fba62dsm926560266b.100.2025.08.28.06.25.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Aug 2025 06:25:04 -0700 (PDT) Message-ID: Date: Thu, 28 Aug 2025 15:25:03 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 10/13] arm64: dts: rockchip: add the vip node to px30 To: michael.riesch@collabora.com, Mehdi Djait , Maxime Chevallier , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Thomas Petazzoni , Gerald Loacker , Markus Elfring , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Philipp Zabel , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Mehdi Djait References: <20240220-rk3568-vicap-v10-0-62d8a7b209b4@collabora.com> <20240220-rk3568-vicap-v10-10-62d8a7b209b4@collabora.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20240220-rk3568-vicap-v10-10-62d8a7b209b4@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/08/2025 01:26, Michael Riesch via B4 Relay wrote: > From: Mehdi Djait > > Add the device tree node for the PX30 Video Input Processor (VIP). > > Signed-off-by: Mehdi Djait > [added cosmetic changes] > Signed-off-by: Michael Riesch > Signed-off-by: Michael Riesch > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index 46f64cd33b9b..ef52879d6a73 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -1280,6 +1280,18 @@ isp_mmu: iommu@ff4a8000 { > #iommu-cells = <0>; > }; > > + cif: video-capture@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>; > + clock-names = "aclk", "hclk", "pclk"; > + power-domains = <&power PX30_PD_VI>; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + status = "disabled"; > + }; > + > qos_gmac: qos@ff518000 { > compatible = "rockchip,px30-qos", "syscon"; > reg = <0x0 0xff518000 0x0 0x20>; > Now that I look at the rockchip dtsi it appears newline scarcity is the norm, you can disregard my suggestion for your example in the previous patch so. Reviewed-by: Bryan O'Donoghue