Re: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support

["Xu, Baojun" <baojun.xu@ti.com>]

> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 10 November 2025 01:17
> To: Xu, Baojun
> Cc: broonie@kernel.org; tiwai@suse.de; andriy.shevchenko@linux.intel.com; 13916275206@139.com; Ding, Shenghao; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org; lgirdwood@gmail.com; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org; Yi, Ken; Lo, Henry; Chen, Robin; Ji, Jesse; Wang, Will; jim.shil@goertek.com; toastcheng@google.com; chinkaiting@google.com
> Subject: [EXTERNAL] Re: [PATCH v1 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/5806M/5806MD/5830 support
> 
> On Sat, Nov 08, 2025 at 07:07:59PM +0800, Baojun Xu wrote:
> > TAS5806M, TAS5806MD and TAS5830 is in same family with TAS58XX.
> > TAS2568 is in family with TAS257X.
> > 
> > Signed-off-by: Baojun Xu <baojun.xu@ti.com>
> > ---
> >  .../devicetree/bindings/sound/ti,tas2781.yaml | 25 +++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> 
> Please organize the patch documenting compatible (DT bindings) before their user.
> See also: https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst*L46__;Iw!!G3vK!SQ5aH9VZhZ2QzKdtYIs5BX7OarVmt1XzwB9XxqFgAGN0ONvsEoAjHsuoZWrrmetzH_xlxeSfWA$

Hi Krzysztof,

Thanks for your review.
Do you mean I need to add a text file,
for example "ti,tas2781.txt", include the required properties,
and the example of the devicetree node?

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 
Best Regards
Jim