From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE19C83F11 for ; Mon, 28 Aug 2023 07:11:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229455AbjH1HLH (ORCPT ); Mon, 28 Aug 2023 03:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbjH1HLB (ORCPT ); Mon, 28 Aug 2023 03:11:01 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2406E1 for ; Mon, 28 Aug 2023 00:10:57 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-98377c5d53eso359613166b.0 for ; Mon, 28 Aug 2023 00:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693206656; x=1693811456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zWhn4TLCrD9nnYOeDxCtGtHbvSHL8FcsnQppWoyo1ZQ=; b=gz6VYD7cQSaCPEwUNZgwzM/ul0NvtDfRQCO3N4xGbmGYLoyXrp30hzbcCCSi1GbHv1 fo229owV2HnlbLRnnAdtpMlHtwF+Bnkc1J2rsT0ae/U7CR9jT7iCvkeIFKLM7w4BKFT3 WLWt0heF6JIgS1Tq96QJXN7NagjUdzAZr1my5Ao2JYFO/rgMTzB/DfPy2Y1iNVSo1JfC Lb8+5ocFBN7aPl0/ZSBtQWgYttYD1jsg77tW0mgnvt7m28oBVezXqjEF+KuGYL4WFsOf cLUup4wUViblHcreJJYwYY0SJfIL2dzCY51behwy3ny2qK9AHR43qeKMzRsJBgacDbJc elRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693206656; x=1693811456; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zWhn4TLCrD9nnYOeDxCtGtHbvSHL8FcsnQppWoyo1ZQ=; b=ge+Q+YYRpv41X42HBhcVoODFj/kse4vhGk2pR0t+8LW6tx7plsrEJmsA97BDR3V2gX Sa+kAcMmSF/O2rde3eQzvRWPIRK2GLIURQ5yXqQbt4a9DjU7xOcX2WXxu+4vm8IMRtGV 4sNpdXSb0NvqPIqQhPJEg6KsJrjokRCaoRcYGwKRQPJ4ikVS1F46LUGTPk29ZpbTqmz7 IYUicU4kKipLeppqqKQjOuzR3Zle8/PGUYJiz+FMJM5IH1RHL9N//EVcEF/R1uKWciAB AHolCFcJGRyrhJTjrA4LzeYg3I2coVgOLwDiGpTqZsAf8yy5DO7vuk2fdAzxwCy2dNPR aGbQ== X-Gm-Message-State: AOJu0YwesuCPjge+HWijU9sCJt719+JjlIV9T1GWvFmkqvOJGpi9fNUd 4ct3dRIE0EfUAK1gELpJlim9UQ== X-Google-Smtp-Source: AGHT+IEaCRRwj6SO7Oi8ML0+d8UnRRo5zK1JU0aNPKESlrbjf2ZzvRCrS2h+a1pGRnqMm/7ZRhUQGw== X-Received: by 2002:a17:906:7391:b0:9a1:c659:7c62 with SMTP id f17-20020a170906739100b009a1c6597c62mr11455127ejl.66.1693206656333; Mon, 28 Aug 2023 00:10:56 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id h1-20020a1709062dc100b0098921e1b064sm4269753eji.181.2023.08.28.00.10.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 00:10:55 -0700 (PDT) Message-ID: Date: Mon, 28 Aug 2023 09:10:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v6 1/2] dt-binding: pinctrl: Add NPCM8XX pinctrl and GPIO documentation Content-Language: en-US To: Tomer Maimon , linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, j.neuschaefer@gmx.net Cc: openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring References: <20230827203612.173562-1-tmaimon77@gmail.com> <20230827203612.173562-2-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230827203612.173562-2-tmaimon77@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/08/2023 22:36, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton Arbel BMC NPCM8XX > pinmux and GPIO controller. > > Signed-off-by: Tomer Maimon > Reviewed-by: Rob Herring > --- > + '^pin': > + $ref: pincfg-node.yaml# > + > + properties: > + pins: > + description: > + A list of pins to configure in certain ways, such as enabling > + debouncing What pin names are allowed? > + > + bias-disable: true > + > + bias-pull-up: true > + > + bias-pull-down: true > + > + input-enable: true > + > + output-low: true > + > + output-high: true > + > + drive-push-pull: true > + > + drive-open-drain: true > + > + input-debounce: > + description: > + Debouncing periods in microseconds, one period per interrupt > + bank found in the controller > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 4 > + > + slew-rate: > + description: | > + 0: Low rate > + 1: High rate > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1] > + > + drive-strength: > + enum: [ 0, 1, 2, 4, 8, 12 ] > + > + additionalProperties: false > + > +allOf: > + - $ref: pinctrl.yaml# > + > +required: > + - compatible > + - ranges > + - '#address-cells' > + - '#size-cells' > + - nuvoton,sysgcr > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pinctrl: pinctrl@f0800260 { Nothing improved here. Test your DTS. This is being reported - I checked. > + compatible = "nuvoton,npcm845-pinctrl"; > + ranges = <0x0 0x0 0xf0010000 0x8000>; > + #address-cells = <1>; > + #size-cells = <1>; > + nuvoton,sysgcr = <&gcr>; > + > + gpio0: gpio@0 { > + gpio-controller; > + #gpio-cells = <2>; > + reg = <0x0 0xB0>; Keep lowercase hex. Best regards, Krzysztof