From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>, Suneel Garapati <suneelg@nvidia.com>
Cc: dipenp@nvidia.com, thierry.reding@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, amhetre@nvidia.com, sheetal@nvidia.com,
kkartik@nvidia.com, robh@kernel.org, pshete@nvidia.com,
timestamp@list.linux.dev, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: timestamp: Add Tegra264 support
Date: Thu, 2 Apr 2026 12:24:05 +0200 [thread overview]
Message-ID: <ecd05856-60dc-42b7-93e9-5e32989008d4@kernel.org> (raw)
In-Reply-To: <5ea58a03-a349-49be-9549-0836d4bc3254@nvidia.com>
On 02/04/2026 12:21, Jon Hunter wrote:
>
> On 02/04/2026 10:53, Krzysztof Kozlowski wrote:
>> On 02/04/2026 11:49, Jon Hunter wrote:
>>>
>>> On 02/04/2026 09:47, Krzysztof Kozlowski wrote:
>>>> On 02/04/2026 10:47, Krzysztof Kozlowski wrote:
>>>>> On Wed, Apr 01, 2026 at 09:38:29PM +0000, Suneel Garapati wrote:
>>>>>> reg:
>>>>>> maxItems: 1
>>>>>> @@ -112,6 +114,7 @@ allOf:
>>>>>> contains:
>>>>>> enum:
>>>>>> - nvidia,tegra234-gte-aon
>>>>>> + - nvidia,tegra264-gte-aon
>>>>>
>>>>> And why exactly the slices are variable here? Explain that in commit
>>>>> msg.
>>>>
>>>> s/Explain/Shortly describe/
>>>
>>> So this is not related to slices, but indicating the
>>> 'nvidia,gpio-controller' property is required for the AON controller.
>>> However, maybe your comment still applies and you want the commit
>>> message to be explicit that for the AON instance the
>>> 'nvidia,gpio-controller' is needed?
>>
>> You have two devices there - AON and LIC - and variable properties. I
>> want answer why things are variable. HW is rarely variable. It is
>> opposite of variable - afixed.
>
> So note that 'nvidia,slices' is a deprecated property ...
>
> 1815e37b6e67 ("dt-bindings: timestamp: Deprecate nvidia,slices property")
>
> I am guessing we did not bother to specify the slices for Tegra264
> because this is no longer being used/supported. And yes, we should have
> made this clear in the commit message :-)
>
Deprecated properties should not be allowed by the schema for new devices.
> Do you want the commit message updated?
It's enough to disallow the property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-02 10:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 21:38 [PATCH 0/3] Add Tegra264 HTE provider Suneel Garapati
2026-04-01 21:38 ` [PATCH 1/3] dt-bindings: timestamp: Add Tegra264 support Suneel Garapati
2026-04-02 8:47 ` Krzysztof Kozlowski
2026-04-02 8:47 ` Krzysztof Kozlowski
2026-04-02 9:49 ` Jon Hunter
2026-04-02 9:53 ` Krzysztof Kozlowski
2026-04-02 10:21 ` Jon Hunter
2026-04-02 10:24 ` Krzysztof Kozlowski [this message]
2026-04-01 21:38 ` [PATCH 2/3] hte: tegra194: Add Tegra264 GTE support Suneel Garapati
2026-04-01 21:38 ` [PATCH 3/3] arm64: tegra: Add GTE nodes for Tegra264 Suneel Garapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd05856-60dc-42b7-93e9-5e32989008d4@kernel.org \
--to=krzk@kernel.org \
--cc=amhetre@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robh@kernel.org \
--cc=sheetal@nvidia.com \
--cc=suneelg@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=timestamp@list.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox