From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <quic_jingyw@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Andy Gross <agross@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Robert Marko <robimarko@gmail.com>,
Das Srinagesh <quic_gurus@quicinc.com>,
Jassi Brar <jassisinghbrar@gmail.com>, Lee Jones <lee@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, Xin Liu <quic_liuxin@quicinc.com>
Subject: Re: [PATCH 02/19] remoteproc: qcom: pas: Add QCS8300 remoteproc support
Date: Wed, 4 Sep 2024 11:36:08 +0200 [thread overview]
Message-ID: <ecd95f82-ea98-4279-ad01-dc73d361180a@kernel.org> (raw)
In-Reply-To: <20240904-qcs8300_initial_dtsi-v1-2-d0ea9afdc007@quicinc.com>
On 04/09/2024 10:33, Jingyi Wang wrote:
> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300
> platform.
>
> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index ef82835e98a4..f92ccd4921b7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1416,6 +1416,9 @@ static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
> { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
> { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
> + { .compatible = "qcom,qcs8300-adsp-pas", .data = &sa8775p_adsp_resource},
> + { .compatible = "qcom,qcs8300-cdsp-pas", .data = &sa8775p_cdsp0_resource},
> + { .compatible = "qcom,qcs8300-gpdsp-pas", .data = &sa8775p_gpdsp0_resource},
What's the point of this? You have entire commit msg to explain such
weird duplication. Otherwise sorry, don't duplicate unnecessarily.
Devices are compatible, aren't they?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-04 9:36 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 8:33 [PATCH 00/19] Add initial support for QCS8300 Jingyi Wang
2024-09-04 8:33 ` [PATCH 01/19] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc Jingyi Wang
2024-09-04 8:33 ` [PATCH 02/19] remoteproc: qcom: pas: Add QCS8300 remoteproc support Jingyi Wang
2024-09-04 9:36 ` Krzysztof Kozlowski [this message]
2024-09-05 4:30 ` Jingyi Wang
2024-09-05 6:24 ` Krzysztof Kozlowski
2024-09-06 5:33 ` Jingyi Wang
2024-09-04 8:33 ` [PATCH 03/19] dt-bindings: phy: Add QMP UFS PHY comptible for QCS8300 Jingyi Wang
2024-09-04 10:55 ` Dmitry Baryshkov
2024-09-05 2:37 ` Jingyi Wang
2024-09-04 8:33 ` [PATCH 04/19] dt-bindings: ufs: qcom: Document the QCS8300 UFS Controller Jingyi Wang
2024-09-04 8:33 ` [PATCH 05/19] phy: qcom-qmp-ufs: Add support for QCS8300 Jingyi Wang
2024-09-04 9:36 ` Krzysztof Kozlowski
2024-09-05 4:33 ` Jingyi Wang
2024-09-04 8:33 ` [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains Jingyi Wang
2024-09-05 11:30 ` Konrad Dybcio
2024-09-05 11:31 ` Konrad Dybcio
2024-09-04 8:33 ` [PATCH 07/19] pmdomain: qcom: rpmhpd: " Jingyi Wang
2024-09-04 8:33 ` [PATCH 08/19] dt-bindings: qcom,pdc: document QCS8300 Power Domain Controller Jingyi Wang
2024-09-04 8:33 ` [PATCH 09/19] dt-bindings: arm-smmu: Add compatible for QCS8300 SoC Jingyi Wang
2024-09-04 8:33 ` [PATCH 10/19] dt-bindings: firmware: qcom,scm: document SCM on QCS8300 SoCs Jingyi Wang
2024-09-04 8:33 ` [PATCH 11/19] dt-bindings: soc: qcom: add qcom,qcs8300-imem compatible Jingyi Wang
2024-09-04 8:33 ` [PATCH 12/19] dt-bindings: mailbox: qcom-ipcc: Document QCS8300 IPCC Jingyi Wang
2024-09-04 8:33 ` [PATCH 13/19] dt-bindings: mfd: qcom,tcsr: Add compatible for QCS8300 Jingyi Wang
2024-09-04 8:33 ` [PATCH 14/19] dt-bindings: nvmem: qfprom: " Jingyi Wang
2024-09-04 8:33 ` [PATCH 15/19] dt-bindings: soc: qcom,aoss-qmp: Document the QCS8300 AOSS channel Jingyi Wang
2024-09-04 8:33 ` [PATCH 16/19] dt-bindings: arm: qcom: document QCS8275/QCS8300 SoC and reference board Jingyi Wang
2024-09-04 9:38 ` Krzysztof Kozlowski
2024-09-05 4:42 ` Jingyi Wang
2024-09-05 6:26 ` Krzysztof Kozlowski
2024-09-04 8:33 ` [PATCH 17/19] arm64: defconfig: enable clock controller, interconnect and pinctrl for QCS8300 Jingyi Wang
2024-09-04 9:39 ` Krzysztof Kozlowski
2024-09-05 4:54 ` Jingyi Wang
2024-09-06 3:18 ` Dmitry Baryshkov
2024-09-06 6:15 ` Jingyi Wang
2024-09-06 9:36 ` Dmitry Baryshkov
2024-09-04 8:33 ` [PATCH 18/19] arm64: dts: qcom: add initial support for QCS8300 DTSI Jingyi Wang
2024-09-04 9:41 ` Krzysztof Kozlowski
2024-09-05 4:56 ` Jingyi Wang
2024-09-04 8:34 ` [PATCH 19/19] arm64: dts: qcom: add base QCS8300 RIDE dts Jingyi Wang
2024-09-07 23:22 ` kernel test robot
2024-09-04 9:34 ` [PATCH 00/19] Add initial support for QCS8300 Krzysztof Kozlowski
2024-09-04 10:19 ` Krzysztof Kozlowski
2024-09-05 5:08 ` Jingyi Wang
2024-09-05 11:33 ` Konrad Dybcio
2024-09-04 13:36 ` Rob Herring (Arm)
2024-09-05 2:45 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd95f82-ea98-4279-ad01-dc73d361180a@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bvanassche@acm.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=jassisinghbrar@gmail.com \
--cc=joro@8bytes.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_gurus@quicinc.com \
--cc=quic_jingyw@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).