From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 737E81465A4 for ; Thu, 11 Apr 2024 10:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830803; cv=none; b=dw0U3zJdCAuQ9EakWWbj6JCedAvVV2wznJZiTG49Ul9PKyoR0T9f3nS1TgSMmjHLph/1MCyWlArxI42OW4MYTF2G8tYnnfOWrzIMy9UherjVLAt5b7jbT+sHQrUg1hXr2y3Z+2eWl/9UQsa0Ca16j0VvKyrCra17IDYLEE2PDX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830803; c=relaxed/simple; bh=7neA6WW4WRLl7mKNbn+9gp5ybC0OC4IaScQHI4tz2eg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fHVd5lAx1279+9VdWZbvRGTkJUmnNQdDBzwz9BDDfZ8pJB+ca6Xow7Tqz0JiFL+IPk5IPXMUIocQJA0jz9NfKvYyXXb1gkNivLpI97gJvWDPEobZV8rM4zjbkPVTYnsAVzIjquAjigJokDSj4X7ZPFOLaSYPWNLp3G5vkneYJIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Uw6+JLhI; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Uw6+JLhI" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3455ff1339dso3275734f8f.0 for ; Thu, 11 Apr 2024 03:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712830800; x=1713435600; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ahLDsVjiZ+H2VO47WR5tZ5Ke+e0FYqnQEaGeYBSthJ0=; b=Uw6+JLhImv03AFnUzJnF0q67LwiUKCnq0+KFCSGkgOUUAWLgEkkPiayhUPqMYMkQZ9 pIT77T0wVjDXe5IlPw/RHHvJC5p03/hc79F0KuprDdURuQoLg3ByODG5iCO2R/U3KgUr +6S4p97Pz7U/bSteNLbJWtIO2CrtqLeGzYZLB8mimdZAzyG2Jy0OOCGYT/PjgGyMf2Vi Ehcc/yfF1VG9VDXTtVdYujkFvRhgVbl0DgHfewAopV/GE+iI6vHw/aqubUiEkrzFS+Yu OBYGUlb0fjJuNZafhdpj8zX6IwcEe5GmNvT4IBrUQIIyabWGP+WkFtARiPs/k4LquVuu mtIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712830800; x=1713435600; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ahLDsVjiZ+H2VO47WR5tZ5Ke+e0FYqnQEaGeYBSthJ0=; b=wlP5vvVrY+5ju2mEH5qI0rrGRzrdFlOhTyEUUINuR/6V7PAT9lSvDRk+gWKlbETAN2 2cEFwl1qaqPKgHGm6kgh7UIQiAaw8oVHTEfn2WXyxx+OOeNbRXFULlNmPap211W8LcHO 1iIcLILtmRSZypQOptHFpYLfl9dzmbsqXKwesMy/ahvzfGSE3DlV2KYgZ4ZIILInOZEW nZcf9YD0yj8BMnAS+x0Z23WuFr7BQXdlxmbhSTVpkFeEzzxdN5JSjaObAtYkupBPeajt 81KA1FTDrn6aQ3hXWEgkMftu1zs2//8iP42jlAsQMnNFtO4DTfXlq84ZhUDdv1Y2wqpG svNg== X-Forwarded-Encrypted: i=1; AJvYcCWr6rE1/+gJpGyueHDTaMfRVW1FnonZn241XCBA+1hCRQSz4k4TBiHYvxzOwrT0wUJPfYDu1v+ar+QXwpgzeeASatBLuXH6zzSAZg== X-Gm-Message-State: AOJu0Yyrf+jujWGac4TGSy5Cl6uO6j/dZwZRVtgQPb8DTdgFvSHgcJ+R KExRFobk3XfY0Ygtv7FPIFuB9vCKDfZvxybfTl5lErNbb9BreT2GLWFHZfyRYnQ= X-Google-Smtp-Source: AGHT+IFINgr6EUAWs13ks5LI2HK47oRZIKXdHnT3h1ag5Th5XQgYBXvR3y7Lh0ftwWncvt9aq6D2iA== X-Received: by 2002:adf:ce05:0:b0:343:9f03:ccf9 with SMTP id p5-20020adfce05000000b003439f03ccf9mr4467650wrn.22.1712830799792; Thu, 11 Apr 2024 03:19:59 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id z11-20020a5d44cb000000b00345920fcb45sm1432517wrr.13.2024.04.11.03.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 03:19:59 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 11:19:58 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8650: add description of CCI controllers To: Vladimir Zapolskiy , Bjorn Andersson , Konrad Dybcio , Jagadeesh Kona Cc: Krzysztof Kozlowski , Neil Armstrong , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240410074951.447898-1-vladimir.zapolskiy@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240410074951.447898-1-vladimir.zapolskiy@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/04/2024 08:49, Vladimir Zapolskiy wrote: > + clocks = <&camcc CAM_CC_CAMNOC_AXI_NRT_CLK>, > + <&camcc CAM_CC_SLOW_AHB_CLK_SRC>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CCI_0_CLK>; > + clock-names = "camnoc_axi", > + "slow_ahb_src", > + "cpas_ahb", > + "cci"; So.. You still need a new compat for this clock list right ? Current options for clocks which need camnoc_axi are - if: properties: compatible: contains: enum: - qcom,sdm845-cci - qcom,sm6350-cci then: properties: clocks: minItems: 6 clock-names: items: - const: camnoc_axi - const: soc_ahb - const: slow_ahb_src - const: cpas_ahb - const: cci - const: cci_src and - if: properties: compatible: contains: enum: - qcom,sc7280-cci - qcom,sm8250-cci - qcom,sm8450-cci then: properties: clocks: minItems: 5 maxItems: 5 clock-names: items: - const: camnoc_axi - const: slow_ahb_src - const: cpas_ahb - const: cci - const: cci_src Also suggest you should look into dropping slow_ahb_src cci_src May not be technically feasible though I accept. --- bod