From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1639EC433F5 for ; Tue, 10 May 2022 10:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239686AbiEJKSc (ORCPT ); Tue, 10 May 2022 06:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239655AbiEJKSb (ORCPT ); Tue, 10 May 2022 06:18:31 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0FBB2AC0D8 for ; Tue, 10 May 2022 03:14:30 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id j6so31902536ejc.13 for ; Tue, 10 May 2022 03:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=dbb/ygIPwle8pAxWJvLtaKiiriFkDuqy8P36ttqmEG8=; b=yycP2wQZ9HF/b/5FrlR8y2OYTYX3t/FNxIguneIPCWzzxuMa0ywg/+isW+/xZ0N47N ftjZJcdDRDFJt1uCggycsLqPYeBjkUN247gzZUe+mmvza6I/+tCsx32K2B9ZCr3V9yF6 RKrYdcQT01qPTOa5mRH+Po281aWca4Ubd245sIIXjuRV7GQt03eS85g1ST1oyMq9hc8O fDegD87KKu4LBgM39oiCem643VRaY9frJPO784Rv7P/OOIklEqi9CCoMsaGLPvvAIAwK Si7cnMCsNwVQqMN4rRFLobj8ZoLw1qSoG04rGJKd4aktEiJJNk5jvixFdKG+0fFl6ZpQ lDBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dbb/ygIPwle8pAxWJvLtaKiiriFkDuqy8P36ttqmEG8=; b=gCzS6aj37etZ8Rm5VvuXVpbisfkOpCA5Nd31iPCd5mRWrpElimN1Z0DodrMJmPPFS+ F5tp/kML+pnm3OMOQPOXTF8b6JpKxvsrcbgtR8RvjdGPsgj7uIIk2lIf+A90rnc+yw+C nox+JX+FBFWxVfis6S53yXd1VWeOLuxTFOSZQWLBCkf8kQbkzNQHtjEGIJUYeVjtbp87 TSetbz+VSVO6d7ub24DTpRIJXiZrVycO7zdSKLfsNrlRLNjFD7M4ukCrAUv/bKf4VNQF 8g3LND6RHQrwoT5XUwwkh+vUVXC7XKEbk4Qc3hIV2bCCP0ApiWdBSlYMLwNBfrYE1i4r x22w== X-Gm-Message-State: AOAM530flL+vhQJYGm4gBxMpVUjCAWsV4ruyDf+7oTo1aerMRjFFsdsU +YMzj/syjsf8Kh5uXXw0aFqadg== X-Google-Smtp-Source: ABdhPJydVj8m9S+WzagJO2lkw35EdeHC09Xmn2fKUVMjIUdi8GsSf/3KkrMZdALGKxBPh4z0+VaMZw== X-Received: by 2002:a17:907:1c8a:b0:6e9:2a0d:d7b7 with SMTP id nb10-20020a1709071c8a00b006e92a0dd7b7mr18248840ejc.572.1652177669239; Tue, 10 May 2022 03:14:29 -0700 (PDT) Received: from [192.168.0.251] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id w1-20020a1709064a0100b006f3ef214db4sm5972354eju.26.2022.05.10.03.14.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 03:14:28 -0700 (PDT) Message-ID: Date: Tue, 10 May 2022 12:14:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] dt-bindings: pmic: mt6366: add binding document Content-Language: en-US To: Zhiyong Tao , lee.jones@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, eddie.huang@mediatek.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, fshao@chromium.org Cc: srv_heupstream@mediatek.com, hui.liu@mediatek.com, tinghan.shen@mediatek.com, hsin-hsiung.wang@mediatek.com, sean.wang@mediatek.com, macpaul.lin@mediatek.com, wen.su@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220510064603.15920-1-zhiyong.tao@mediatek.com> <20220510064603.15920-2-zhiyong.tao@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220510064603.15920-2-zhiyong.tao@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/05/2022 08:46, Zhiyong Tao wrote: > From: "Zhiyong.Tao" > > The commit adds mt6366 binding document. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Zhiyong.Tao > --- > .../bindings/regulator/mt6366-regulator.yaml | 405 ++++++++++++++++++ > 1 file changed, 405 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml > > diff --git a/Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml > new file mode 100644 > index 000000000000..1f125f5ba860 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mt6366-regulator.yaml Filename with vendor, so "mediatek,mt6366-regulator.yaml" > @@ -0,0 +1,405 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mt6366-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MT6366 Regulator from MediaTek Integrated > + > +maintainers: > + - Hsin-Hsiung Wang > + > +description: | > + List of regulators provided by this controller. It is named > + according to its regulator type, buck_ and ldo_. > + MT6366 regulators node should be sub node of the MT6397 MFD node. > + Missing properties node, missing compatible. How is it supposed to match? If you plan to use it as part of other binding, please send entire patchset (including the binding which uses this one). In current form this looks untestable, unusable. > +patternProperties: > + "^buck_v(dram1|core|pa|proc11|proc12|gpu|s2|modem|s1)$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(dram1|core|pa|proc11|proc12|gpu|s2|modem|s1)$" > + > + unevaluatedProperties: false Put this one after $ref (other places as well). Makes it more readable. > + > + "^ldo_v(ibr|rf12|usb|camio|efuse|xo22)$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(ibr|rf12|usb|camio|efuse|xo22)$" > + > + unevaluatedProperties: false > + > + "^ldo_v(rfck|emc|a12|a09|ufs|bbck)$": > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^v(rfck|emc|a12|a09|ufs|bbck)$" > + > + unevaluatedProperties: false > + > + "^ldo_vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$": No underscores in node names. > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$" > + > + unevaluatedProperties: false > + > + "^ldo_vsram_(proc2|others|md|proc1|others_sshub)$": No underscores in node names, in all places. > + type: object > + $ref: "regulator.yaml#" > + > + properties: > + regulator-name: > + pattern: "^vsram_(proc2|others|md|proc1|others_sshub)$" > + > + unevaluatedProperties: false > + Best regards, Krzysztof