From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6A2C7EE25 for ; Tue, 16 May 2023 15:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233480AbjEPPVI (ORCPT ); Tue, 16 May 2023 11:21:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233937AbjEPPUv (ORCPT ); Tue, 16 May 2023 11:20:51 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05EE97D88 for ; Tue, 16 May 2023 08:20:50 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f1fe1208a4so13514763e87.2 for ; Tue, 16 May 2023 08:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684250448; x=1686842448; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8AWKpnwAVSZF0RZwgYNJ8KCTEC9gSaQ9TieU/3HHmrk=; b=AnsdaeP4dmnBP43DGnvBvHTNFMtmfhFQFiLK/08atFTSAN+VloaXOkeBJc4bCM8qhP V3Hr6A/9CyI37N7c2VZyW4Biz8gcVK8yDgkIl5W4NJbLTL3C8e7NrcBiAgw0tjRgMxrt 5VI+oM5HaItWJdAs7jk9E6oRMn8p9CVmVFgODj2oqR6ybB8AZMwmFfltQhNkC528Rol3 Krl+vv6/e3zVuoPB674IOboe6f8d8wcjlR/RjGq0H+PqU3UgjHfAGgUbZZArjN4J8Pv+ aa+ICsS/nYtBToxtxgnvbsITNxz4uaCK/bZNdKgAinydyAxU+fIMWgQI1wZUrxSgpndx slyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684250448; x=1686842448; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8AWKpnwAVSZF0RZwgYNJ8KCTEC9gSaQ9TieU/3HHmrk=; b=cR0Uyno4QmxtVWnug5gRMUth5T/+dwcXhNDiHMYyP5cDsIrEzvSxMDHju5PGhaQGdq iLeHpiieMxoXiVUfpfHpiBMoWKdZXGEGhnc9KFw6z09TcNG4Ae3KAA31c+cvyW4H+PVB ivk644PBamPktXzZ/5be1m4lnJLk7/cNkBGs3CoY+dlstB/yl1zOGtt9VBJ+NhoRrEXo YLX2d6nr0rsweFNjba6d/dV/JNztxU2v1bquZRcVt0HKEa53cG8Tjg2PC/sKs66kIQji DFAVic81BaaXfhcE3wtClE39pJ3C1YWbbxRyAXTPuijXVo1GM5oAkMGr42mXPNWtGI/I DKLA== X-Gm-Message-State: AC+VfDya1R2zyTXZWNg/qi5XvyF2fBgEj9crTZ8P7/8d5O02M7aVnikC +3+7ouaeKCdf3jdDRVCI56cgeQ== X-Google-Smtp-Source: ACHHUZ6G+XLqcLw33b1steb9Qp3niR/qMasK+d1jeR1V41r8rEkIjoPng8pZOKr/AFkIdQutysToLA== X-Received: by 2002:ac2:4d0b:0:b0:4f1:223c:dc83 with SMTP id r11-20020ac24d0b000000b004f1223cdc83mr6672497lfi.48.1684250448249; Tue, 16 May 2023 08:20:48 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id w17-20020a05651204d100b004f14898d18esm2959685lfq.85.2023.05.16.08.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 08:20:47 -0700 (PDT) Message-ID: Date: Tue, 16 May 2023 17:20:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] arm64: dts: qcom: sm8550-qrd: add display and panel Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Neil Armstrong , "Signed-off-by : Abel Vesa" References: <20230516151708.213744-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20230516151708.213744-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16.05.2023 17:17, Krzysztof Kozlowski wrote: > Enable Display Subsystem with Visionox VTDR6130 Panel (same as on > MTP8550). > > Signed-off-by: Krzysztof Kozlowski > > --- > > Context in the patch depends on: > 1. https://lore.kernel.org/linux-arm-msm/20230516133011.108093-1-krzysztof.kozlowski@linaro.org/T/#t > 2. https://lore.kernel.org/linux-arm-msm/20230512160452.206585-1-krzysztof.kozlowski@linaro.org/ > --- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 76 +++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index 30b36a149125..03bf6bc2db4d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -420,6 +420,10 @@ vreg_l3g_1p2: ldo3 { > }; > }; > > +&dispcc { > + status = "okay"; > +}; Missed this in the bigpatchdrop review.. It makes no sense to keep dispcc disabled by default (other than for lazily "solving" UEFI framebuffer being shut down) > + > &gcc { > clocks = <&bi_tcxo_div2>, <&sleep_clk>, > <&pcie0_phy>, > @@ -431,6 +435,50 @@ &gcc { > <&usb_dp_qmpphy QMP_USB43DP_USB3_PIPE_CLK>; > }; > > +&mdss { > + status = "okay"; > +}; > + > +&mdss_dsi0 { > + vdda-supply = <&vreg_l3e_1p2>; > + status = "okay"; > + > + panel@0 { > + compatible = "visionox,vtdr6130"; > + reg = <0>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>; > + pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>; property-n property-names > + > + vddio-supply = <&vreg_l12b_1p8>; > + vci-supply = <&vreg_l13b_3p0>; > + vdd-supply = <&vreg_l11b_1p2>; > + > + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&mdss_dsi0_out>; > + }; > + }; > + }; > +}; > + > +&mdss_dsi0_out { > + remote-endpoint = <&panel0_in>; > + data-lanes = <0 1 2 3>; > +}; > + > +&mdss_dsi0_phy { > + vdds-supply = <&vreg_l1e_0p88>; > + status = "okay"; > +}; > + > +&mdss_mdp { > + status = "okay"; > +}; This should also be enabled by default, MDSS is useless when MDP is disabled. lgtm otherwise Konrad > + > &pcie_1_phy_aux_clk { > status = "disabled"; > }; > @@ -532,6 +580,34 @@ wcd_tx: codec@0,3 { > &tlmm { > gpio-reserved-ranges = <32 8>; > > + sde_dsi_active: sde-dsi-active-state { > + pins = "gpio133"; > + function = "gpio"; > + drive-strength = <8>; > + bias-disable; > + }; > + > + sde_dsi_suspend: sde-dsi-suspend-state { > + pins = "gpio133"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + sde_te_active: sde-te-active-state { > + pins = "gpio86"; > + function = "mdp_vsync"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + sde_te_suspend: sde-te-suspend-state { > + pins = "gpio86"; > + function = "mdp_vsync"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > wcd_default: wcd-reset-n-active-state { > pins = "gpio108"; > function = "gpio";