From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24BEC433EF for ; Tue, 15 Feb 2022 12:17:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237572AbiBOMRj (ORCPT ); Tue, 15 Feb 2022 07:17:39 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233984AbiBOMRj (ORCPT ); Tue, 15 Feb 2022 07:17:39 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C750A1074E1 for ; Tue, 15 Feb 2022 04:17:29 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 913601480; Tue, 15 Feb 2022 04:17:29 -0800 (PST) Received: from [10.57.70.89] (unknown [10.57.70.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9269D3F718; Tue, 15 Feb 2022 04:17:28 -0800 (PST) Message-ID: Date: Tue, 15 Feb 2022 12:17:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 1/9] dt-bindings: Add arm,mali-valhall compatible Content-Language: en-GB To: alyssa.rosenzweig@collabora.com, dri-devel@lists.freedesktop.org Cc: tomeu.vizoso@collabora.com, devicetree@vger.kernel.org, airlied@linux.ie, steven.price@arm.com References: <20220211202728.6146-1-alyssa.rosenzweig@collabora.com> <20220211202728.6146-2-alyssa.rosenzweig@collabora.com> From: Robin Murphy In-Reply-To: <20220211202728.6146-2-alyssa.rosenzweig@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-02-11 20:27, alyssa.rosenzweig@collabora.com wrote: > From: Alyssa Rosenzweig > > From the kernel's perspective, pre-CSF Valhall is more or less > compatible with Bifrost, although they differ to userspace. Add a > compatible for Valhall to the existing Bifrost bindings documentation. > > Signed-off-by: Alyssa Rosenzweig > Cc: devicetree@vger.kernel.org > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 63a08f3f321d..48aeabd2ed68 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -23,6 +23,7 @@ properties: > - rockchip,px30-mali > - rockchip,rk3568-mali > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > + - const: arm,mali-valhall # Mali Valhall GPU model/revision is fully discoverable This requires all existing Bifrost users to add the Valhall compatible as well - I don't think that's what you want. From what we tossed about on IRC the other week, I'd imagined something more in the shape of: compatible: oneOf: - items: - enum: - vendor,soc-mali - ... - const: arm,mali-bifrost - items: - enum: - vendor,soc-mali - ... - const: arm,mali-valhall - const: arm,mali-bifrost #or not, depending on forward-compatibility preferences Cheers, Robin.