From: Krzysztof Kozlowski <krzk@kernel.org>
To: Matthias Fend <matthias.fend@emfend.at>, Conor Dooley <conor@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH 1/2] dt-bindings: leds: add Texas Instruments TPS6131x flash LED driver
Date: Mon, 10 Mar 2025 08:43:06 +0100 [thread overview]
Message-ID: <ed09c9c5-f4d9-4b09-a272-f3946e971230@kernel.org> (raw)
In-Reply-To: <025cf7b9-2aa5-4651-91f5-d4b596d654ed@emfend.at>
On 10/03/2025 08:20, Matthias Fend wrote:
> Hi Conor,
>
> Am 28.02.2025 um 19:24 schrieb Conor Dooley:
>> On Fri, Feb 28, 2025 at 11:31:23AM +0100, Matthias Fend wrote:
>>> Document Texas Instruments TPS61310/TPS61311 flash LED driver devicetree
>>> bindings.
>>>
>>> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
>>> ---
>>> .../devicetree/bindings/leds/ti,tps6131x.yaml | 123 +++++++++++++++++++++
>>> 1 file changed, 123 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml b/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..c08b3cef7abcec07237d3271456ff1f888b2b809
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/leds/ti,tps6131x.yaml
>>
>> With a filename matching one of the compatibles in the file,
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> thank you very much for your feedback.
> Since I found different variants in the LED bindings, I wasn't quite
> sure here.
> So is it okay if I simply rename the file to 'ti,tps61310.yaml', even
> though there are multiple compatible strings and the driver is called
> leds-tps6131x?
>
I think that was exactly the review comment you got.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-10 7:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 10:31 [PATCH 0/2] Support for Texas Instruments TPS6131X flash LED driver Matthias Fend
2025-02-28 10:31 ` [PATCH 1/2] dt-bindings: leds: add Texas Instruments TPS6131x " Matthias Fend
2025-02-28 18:24 ` Conor Dooley
2025-03-10 7:20 ` Matthias Fend
2025-03-10 7:43 ` Krzysztof Kozlowski [this message]
2025-03-10 7:49 ` Krzysztof Kozlowski
2025-03-10 8:40 ` Matthias Fend
2025-03-10 11:45 ` Krzysztof Kozlowski
2025-02-28 10:31 ` [PATCH 2/2] leds: tps6131x: add support for Texas Instruments TPS6131X " Matthias Fend
2025-03-10 7:46 ` Krzysztof Kozlowski
2025-03-10 8:04 ` Matthias Fend
2025-03-10 11:46 ` Krzysztof Kozlowski
2025-03-10 14:49 ` Lee Jones
2025-03-14 8:28 ` Matthias Fend
2025-03-14 10:52 ` Lee Jones
2025-03-14 11:27 ` Matthias Fend
2025-03-14 11:45 ` Lee Jones
2025-03-14 12:38 ` Matthias Fend
2025-03-14 14:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed09c9c5-f4d9-4b09-a272-f3946e971230@kernel.org \
--to=krzk@kernel.org \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=matthias.fend@emfend.at \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).