From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54CD91DC9BE for ; Tue, 10 Dec 2024 09:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733824606; cv=none; b=rI10ZGQf+g6YfoJLX+ZsEIUPpTfmDI5KWQcWug9aBxFR19nlQWSlQZL2CB6H3sOQI3PPD3y11LgN65cL6NuQxoREHsUoYZLq5iVfV1pf8Dnwgc8tVNZ93wsdS++q/9IekY+wE6fUNE3DZPhJV9EmoTv6a8/8pFXkkHvWlXC7/YY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733824606; c=relaxed/simple; bh=kOBH0vMe0xTQDXgWPorv7i1vsjSVrIhgJ0QqbJFZGP4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qsxde8ZCO+RRLheeUgJI/J9VzaGSMszSVTlRHBAaMcTnwW9IQC81Ono0ItaFsjJM8SmRyqmGPSuSXrRtXWhoPSgIF+CC+NKcgFTCKxacO5Bkzl1DR6i/kFF8fcggnoeh7cHxyA4K4SwJ1zkqIVK0OkUSj9rEpKhjP6gz815j55U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=E3hp/VzP; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="E3hp/VzP" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3862a4b8ec2so2116666f8f.1 for ; Tue, 10 Dec 2024 01:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733824602; x=1734429402; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kOBH0vMe0xTQDXgWPorv7i1vsjSVrIhgJ0QqbJFZGP4=; b=E3hp/VzPKLaBQJc1w6MPAgYZfc+1H0YB+8+rJ9EWrPGFWPT0kztjQZSoiyATSyUr0i KcKWcx+yWush0dy/9+4PGpr3fBbZoTMu1OYglSVIyB5OZ48/+rXqyat1oaAR53cpDXw5 Yi33RHKyuCPGSiNqz5vAa2VpcN469IMWx4kXi8jr20d18DDyQtNe7u5uJ2LaZ11vWqTR bDxUU3JWcEu+x2xQqtRb9HVrkGtzRb2/cVHZlFZBh46kvDe1qi8/ytwZ0n2iwseJYqEJ 99s09Sp6TjtT7UUq5q48TdGZ4lBWrFjUNucASTgDO0h7RTtiTQ2z+dxnPoOXgcbDivrG 6bfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733824602; x=1734429402; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kOBH0vMe0xTQDXgWPorv7i1vsjSVrIhgJ0QqbJFZGP4=; b=aGBl26oAd0gQQRnilRaxh5UrAg4XnrnPpGeHl9R+TGhah/x83aFGwripyL+IJzEIcX HVMB8Bz7rxIhf1r/K2KYoVDKPYdsiqsRASofKo2n0xtiV4Ya2zOhVexB+cbh2bO2alnw MWv64lroDXGUHxckLRn7j9Py/wruuD7jDyVfSeY8fVV6+o2D+HtTV79Xm85SI7n500BP 6EFD95utFCXOf0kxZvx149GzqiEtEijd4aI3uxUluxBUJWzhHrZ2RowMmXapRJE5QO8b BSU5SQToTBo2ilAhI2foUcrWGWTwNl0ZvtVhw3EGx/K9zo1L579PO+8uG1Ke8LnMfE+t LMNg== X-Forwarded-Encrypted: i=1; AJvYcCX1ZE3b9xwoik4tdHTJTGR5A9WSnoqv8oVf6urrvSbBNiI8wk2kuYK6yxtyHEWIwvYISGomH+ScIR/N@vger.kernel.org X-Gm-Message-State: AOJu0YwL2Xi5rTi4C0eAuekNrXhbA661do01ugVSRO8sUVM6IoLPjrsJ 3YFg2vcjAOLr5qiPy12li2lzUnfXQsVrNDPHj/WuRUmPClgV0PZQIOoYkTLWH5c= X-Gm-Gg: ASbGncu0yfXUx+fjUAXZNVtZJrQNUfmTk+JL1JiMUrhb6Oi1pSeETVqTUtzln4bloCV lPpLQSZiMBf4oward8nvTdKTDk9JzS72YIfi/WutOdsRI7WBgAoLSS85dp8bK/1E9PVXEJvmMwb rGLGeIgKmn6k2/rzJyoAhkQC24BrqChXqBZoremzUBLeCOLS7JT0ZamurdDwoTpBhOzVXqSTSW0 CGgmoH+LedKxs30reZa8NwithwODlV9435zuM8+IZbXDflaNUzmrYbI/7crk3k= X-Google-Smtp-Source: AGHT+IGBn3J/kwjMkMOumD3GgGk3HgegGtxShYE8MGa5RyAHXgSBmzxZuUlRrYhXtKyrcLpn+/1Lzg== X-Received: by 2002:a5d:6c6d:0:b0:382:4926:98fa with SMTP id ffacd0b85a97d-386453fe979mr2475238f8f.40.1733824602299; Tue, 10 Dec 2024 01:56:42 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3862190989fsm15684319f8f.73.2024.12.10.01.56.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Dec 2024 01:56:41 -0800 (PST) Message-ID: Date: Tue, 10 Dec 2024 11:56:39 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/25] ASoC: renesas: rz-ssi: Use goto label names that specify their actions Content-Language: en-US To: Geert Uytterhoeven Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, linus.walleij@linaro.org, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, Claudiu Beznea References: <20241113133540.2005850-1-claudiu.beznea.uj@bp.renesas.com> <20241113133540.2005850-15-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Geert, On 09.12.2024 15:51, Geert Uytterhoeven wrote: > Inside this block there are several return statements. > As we know DMA is not available when we get here, these do not > need to call rz_ssi_release_dma_channels() hence do not use > "goto err_release_dma_chs". > However, this may be missed when making future changes. > So perhaps it may be prudent to make this safer, by moving this inside > the failure branch of the rz_ssi_dma_request() check above? I agree! As this series is already big enough I would prefer to handle it after it is integrated. Keeping it like this doesn't impact the RZ/G3S support. Are you OK with this approach? Thank you for your review, Claudiu