Devicetree
 help / color / mirror / Atom feed
From: Ben Levinsky <blevinsk@amd.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
	Ben Levinsky <ben.levinsky@amd.com>
Cc: jassisinghbrar@gmail.com, andersson@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, michal.simek@amd.com,
	tanmay.shah@amd.com, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] remoteproc: amd_mbv_bram: Bound device name formatting
Date: Thu, 19 Nov 2026 08:29:15 -0800	[thread overview]
Message-ID: <ed41c398-3476-4160-8c8e-d7b85e3b32c3@amd.com> (raw)
In-Reply-To: <av8gg6d7eKwpfcTQ@p14s>



On 11/19/26 8:14 AM, Mathieu Poirier wrote:
> On Wed, Nov 04, 2026 at 09:18:57PM -0800, Ben Levinsky wrote:
>> rproc_mem_entry_init() interprets its name argument as a printf format
>> string. Passing the device name directly allows percent conversions in a
>> DT-derived platform device name to consume nonexistent variadic arguments.
>>
> 
> I read the last sentence of the above paragraph 6 times and I still don't
> understand the problem you are describing.  I'm guessing it was generated
> by an AI.  Please refactor.

  Hi Mathieu,

  You're right, and sorry for the noise. The changelog was written with
  AI assistance and I should have disclosed that on this patch as I did
  on the rest of the series.

  The concern was only that dev_name() ends up as the format argument of
  rproc_mem_entry_init(). In practice, the name of an OF platform device
  is built from the unit address and node name, and dtc does not accept
  '%' in node names, so I can't point to a real case where this goes
  wrong.
> 
>  
>> Pass the device name through a constant format so it is always handled as
>> data. Limit the formatted name to 31 characters to match the space
>> available in rproc_mem_entry::name while leaving room for its terminating
>> null byte.
> 
> What to you mean by "handled as data"?  Moreover, the size of
> rproc_mem_entry::name is handled properly in rproc_mem_entry_init().  What am I
> missing?  I also suspect this was AI generated.

  You're not missing anything. rproc_mem_entry_init() already limits the
  name to sizeof(mem->name) through vsnprintf(), so the "%.31s" adds
  nothing.

  Since the patch doesn't fix a real problem, I'll drop it from v2 along
  with the Fixes: tag. I'll also rework the changelogs of the remaining
  patches so they describe the observed problem and the change in plain
  terms.

  Thanks,
  Ben

> 
>>
>> Fixes: f87b4998994e ("remoteproc: Add AMD MicroBlaze/V BRAM-based remote processor driver")
>> Reviewed-by: Tanmay Shah <tanmay.shah@amd.com>
>> Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
>> ---
>>  drivers/remoteproc/amd_mbv_bram_rproc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/amd_mbv_bram_rproc.c b/drivers/remoteproc/amd_mbv_bram_rproc.c
>> index e4a103cf8455..6cf33c7b7e64 100644
>> --- a/drivers/remoteproc/amd_mbv_bram_rproc.c
>> +++ b/drivers/remoteproc/amd_mbv_bram_rproc.c
>> @@ -72,7 +72,7 @@ static int amd_bram_rproc_prepare(struct rproc *rproc)
>>  				   resource_size(&res), da,
>>  				   rproc_mem_entry_ioremap_wc,
>>  				   rproc_mem_entry_iounmap,
>> -				   dev_name(priv->dev));
>> +				   "%.31s", dev_name(priv->dev));
>>  	if (!mem)
>>  		return -ENOMEM;
>>  
>> -- 
>> 2.34.1
>>


  reply	other threads:[~2026-11-19 16:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  5:18 [PATCH v2 0/6] Add AMD PL Mailbox and RPMsg support for the AMD BRAM remoteproc Ben Levinsky
2026-11-05  5:18 ` [PATCH v2 1/6] remoteproc: amd_mbv_bram: Bound device name formatting Ben Levinsky
2026-11-19 16:14   ` Mathieu Poirier
2026-11-19 16:29     ` Ben Levinsky [this message]
2026-11-05  5:18 ` [PATCH v2 2/6] remoteproc: amd_mbv_bram: Restore reset GPIO direction after PL reconfig Ben Levinsky
2026-11-05  5:29   ` sashiko-bot
2026-11-19 16:44   ` Mathieu Poirier
2026-11-05  5:18 ` [PATCH v2 3/6] dt-bindings: mailbox: Add AMD PL Mailbox IP Ben Levinsky
2026-11-05  5:19 ` [PATCH v2 4/6] mailbox: Add AMD PL Mailbox soft IP controller Ben Levinsky
2026-11-05  5:31   ` sashiko-bot
2026-11-05  5:19 ` [PATCH v2 5/6] dt-bindings: remoteproc: Add RPMsg resources to AMD BRAM rproc Ben Levinsky
2026-11-05  5:19 ` [PATCH v2 6/6] remoteproc: amd_mbv_bram: Add RPMsg support Ben Levinsky
2026-11-05  5:39   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed41c398-3476-4160-8c8e-d7b85e3b32c3@amd.com \
    --to=blevinsk@amd.com \
    --cc=andersson@kernel.org \
    --cc=ben.levinsky@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=michal.simek@amd.com \
    --cc=robh@kernel.org \
    --cc=tanmay.shah@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox