devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] dt-bindings: Add ISL69260 voltage regulator device
@ 2024-08-01 15:34 Peter Yin
  2024-08-02  7:27 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Yin @ 2024-08-01 15:34 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
	Noah Wang, Javier Carrasco, Patrick Rudolph, Lukas Wunner,
	Bjorn Helgaas, devicetree, linux-kernel

The ISL69260 is a digital dual output multiphase
with Intel VR13, VR13.HC, and VR14 specifications.

Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 7913ca9b6b54..6ec8b4cc9e56 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -164,6 +164,8 @@ properties:
           - isil,isl29030
             # Intersil ISL68137 Digital Output Configurable PWM Controller
           - isil,isl68137
+            # Intersil ISL69260 PMBus Voltage Regulator
+          - isil,isl69260
             # Intersil ISL69269 PMBus Voltage Regulator
           - isil,isl69269
             # Intersil ISL76682 Ambient Light Sensor
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] dt-bindings: Add ISL69260 voltage regulator device
  2024-08-01 15:34 [PATCH v1] dt-bindings: Add ISL69260 voltage regulator device Peter Yin
@ 2024-08-02  7:27 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-02  7:27 UTC (permalink / raw)
  To: Peter Yin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Guenter Roeck, Noah Wang, Javier Carrasco, Patrick Rudolph,
	Lukas Wunner, Bjorn Helgaas, devicetree, linux-kernel

On 01/08/2024 17:34, Peter Yin wrote:
> The ISL69260 is a digital dual output multiphase
> with Intel VR13, VR13.HC, and VR14 specifications.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Commit msg: You should also say that you document a compatible already
used in DTS.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-02  7:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 15:34 [PATCH v1] dt-bindings: Add ISL69260 voltage regulator device Peter Yin
2024-08-02  7:27 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).