* [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
@ 2024-01-08 13:12 Krzysztof Kozlowski
2024-01-08 13:12 ` [PATCH 2/2] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-08 13:12 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vinod Koul, Bhupesh Sharma, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
name for the pin:
sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
Fixes: 4a657c264b78 ("arm64: dts: qcom: db845c: Enable PCIe controllers")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index ab6220456513..1f517328199b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -580,7 +580,7 @@ &mss_pil {
&pcie0 {
status = "okay";
perst-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
- enable-gpio = <&tlmm 134 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>;
vddpe-3v3-supply = <&pcie0_3p3v_dual>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios
2024-01-08 13:12 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios Krzysztof Kozlowski
@ 2024-01-08 13:12 ` Krzysztof Kozlowski
2024-01-08 13:15 ` Konrad Dybcio
2024-01-08 13:15 ` [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: " Konrad Dybcio
2024-02-16 23:10 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-08 13:12 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vinod Koul, Bhupesh Sharma, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
name for the pin:
sa8155p-adp.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
Fixes: a1c86c680533 ("arm64: dts: qcom: sm8150: Add PCIe nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 031acef259e9..53c78c126ded 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1881,7 +1881,7 @@ pcie0: pcie@1c00000 {
phy-names = "pciephy";
perst-gpios = <&tlmm 35 GPIO_ACTIVE_HIGH>;
- enable-gpio = <&tlmm 37 GPIO_ACTIVE_HIGH>;
+ wake-gpios = <&tlmm 37 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pcie0_default_state>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios
2024-01-08 13:12 ` [PATCH 2/2] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
@ 2024-01-08 13:15 ` Konrad Dybcio
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-01-08 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Bhupesh Sharma,
linux-arm-msm, devicetree, linux-kernel
On 8.01.2024 14:12, Krzysztof Kozlowski wrote:
> Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
> name for the pin:
>
> sa8155p-adp.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
>
> Fixes: a1c86c680533 ("arm64: dts: qcom: sm8150: Add PCIe nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
2024-01-08 13:12 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios Krzysztof Kozlowski
2024-01-08 13:12 ` [PATCH 2/2] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
@ 2024-01-08 13:15 ` Konrad Dybcio
2024-02-16 23:10 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2024-01-08 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Vinod Koul, Bhupesh Sharma,
linux-arm-msm, devicetree, linux-kernel
On 8.01.2024 14:12, Krzysztof Kozlowski wrote:
> Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
> name for the pin:
>
> sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
>
> Fixes: 4a657c264b78 ("arm64: dts: qcom: db845c: Enable PCIe controllers")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: (subset) [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
2024-01-08 13:12 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios Krzysztof Kozlowski
2024-01-08 13:12 ` [PATCH 2/2] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2024-01-08 13:15 ` [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: " Konrad Dybcio
@ 2024-02-16 23:10 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2024-02-16 23:10 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Bhupesh Sharma, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski
On Mon, 08 Jan 2024 14:12:15 +0100, Krzysztof Kozlowski wrote:
> Bindings allow a "wake", not "enable", GPIO. Schematics also use WAKE
> name for the pin:
>
> sdm845-db845c.dtb: pcie@1c00000: Unevaluated properties are not allowed ('enable-gpio' was unexpected)
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios
commit: 584a327c5cffc36369b2a8953d9448826240f1ac
[2/2] arm64: dts: qcom: sm8150: correct PCIe wake-gpios
commit: 7c38989d0f7a35c83e7c4781271d42662903fa8d
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-16 23:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-08 13:12 [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: correct PCIe wake-gpios Krzysztof Kozlowski
2024-01-08 13:12 ` [PATCH 2/2] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2024-01-08 13:15 ` Konrad Dybcio
2024-01-08 13:15 ` [PATCH 1/2] arm64: dts: qcom: sdm845-db845c: " Konrad Dybcio
2024-02-16 23:10 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).