From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
alistair@alistair23.me, anarsoul@gmail.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, max.chou@realtek.com, hildawu@realtek.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH RFC 1/2] dt-bindings: net: realtek-bluetooth: Add RTL8821CS
Date: Fri, 27 Jan 2023 17:53:49 +0100 [thread overview]
Message-ID: <ed5fec12-1c86-d235-718f-f812e7461d94@linaro.org> (raw)
In-Reply-To: <63d3fff7.050a0220.db92.7af4@mx.google.com>
On 27/01/2023 17:46, Chris Morgan wrote:
> On Fri, Jan 27, 2023 at 11:24:03AM +0100, Krzysztof Kozlowski wrote:
>> On 26/01/2023 17:55, Chris Morgan wrote:
>>> From: Chris Morgan <macromorgan@hotmail.com>
>>>
>>> Add compatible string for RTL8821CS for existing Realtek Bluetooth
>>> driver.
>>>
>>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>>> ---
>>> Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>
>> Based on your driver it is compatible with rtl8822cs, so you can
>> indicate it in the binding and use just one of_device_id entry.
>
> It's very similar, and uses some of the same constants, but has a
> different firmware. I assumed the firmware difference is enough to
> require it to be differentiated, but I wasn't sure. You are saying
> it does not? I just want to be clear.
If by "differentiated" you mean "incompatible", then depends:
1. You have firmware-name property to indicate the firmware to load and
then you can use one compatible to bind and just load different firmware,
2. If device variant is autodectable, it's compatible.
realtek,rtl8723ds-bt also was added to the driver uselessly...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-27 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 16:55 [PATCH RFC 0/2] Bluetooth: Add support for RTL8821CS Chris Morgan
2023-01-26 16:55 ` [PATCH RFC 1/2] dt-bindings: net: realtek-bluetooth: Add RTL8821CS Chris Morgan
2023-01-27 10:24 ` Krzysztof Kozlowski
2023-01-27 16:46 ` Chris Morgan
2023-01-27 16:53 ` Krzysztof Kozlowski [this message]
2023-01-27 17:00 ` Chris Morgan
2023-01-27 17:02 ` Krzysztof Kozlowski
2023-01-26 16:55 ` [PATCH RFC 2/2] Bluetooth: hci_h5: btrtl: Add support for RTL8821CS Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed5fec12-1c86-d235-718f-f812e7461d94@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alistair@alistair23.me \
--cc=anarsoul@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hildawu@realtek.com \
--cc=johan.hedberg@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=marcel@holtmann.org \
--cc=max.chou@realtek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).