From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733BFC433EF for ; Fri, 4 Feb 2022 08:52:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240645AbiBDIwP (ORCPT ); Fri, 4 Feb 2022 03:52:15 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:36836 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357202AbiBDIwO (ORCPT ); Fri, 4 Feb 2022 03:52:14 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 3C6263F32B for ; Fri, 4 Feb 2022 08:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1643964733; bh=iqZrLHxxMKYXcwDk+JH/xBRKoG0uPSeGw2pYz3/v6kY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eBIHCkKi09tjJqdWDZBoh6iZZuDeagxiGhsi8PTmN4ZBY1JFJ1plEen9alndKBpaa rZa25r7WemVcr/Bx6NCtnLoPmcYSswxky+lK1Vprp5zULdncJTDlsj1jhr9unEL+37 CgMZr3cuaInfjFgXPkhtTMkhf90SGkA4DcHjETpJOlai5o6oC6dhVu5GCEn7VKpEjI em2yORSiXEHkXjyJWrN9LxinOyu8AyEXoRk1zfMSqqqEq9EL0xS4kzuezxyQSLbgmG RXKUWjiTX6UVV2h+jy9Q48+0w78TVhk0SnYeH1JBQPaASjUrgyx5Z+aTKPi3YAcZ2c 67T+4OKW7Zwzw== Received: by mail-ed1-f71.google.com with SMTP id k5-20020a508ac5000000b00408dec8390aso2899616edk.13 for ; Fri, 04 Feb 2022 00:52:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iqZrLHxxMKYXcwDk+JH/xBRKoG0uPSeGw2pYz3/v6kY=; b=lADd+rHpVjCGqB/bSQjV9fGZf9uBGFg3nGp+0o2d6sZyDpRM9FHfOajaWH4yQjBNjA gimKF++tx1HTQVd8LnDEJhOLMmtWqCy1fVF2hb01l1so2T0wvpFHj6VOUdf7F9hH3/VZ lxBEWM3bl2jxV14ysXJ0qMcKlvJ/syCP78chnm3d5kWlqte7noGihySO/wLm9tEI4vsM syZhkCCI1QLKQilkY8LEMVbx/QL9KzoMnH6aabsG0Ds690h92sYgicvYg7MdJ4eoqQi4 u6NRbgOrtUYYtzxP1CjV8rFXRAA3P9F2qEwm4erQyISoGV1RdLrDEUk3Tcpsk+0y5pH8 Aalw== X-Gm-Message-State: AOAM533z7Nl31C8G2J5Eq/zR6KZ0l03eHHNEXmlOmsovcYHbKEJat0qR C7mhsYsA/J3jztDdsOh9J/TtKBlMxgbzMs65cIAUdQ11pQX3JDy3OJtCxPxStRfrq1V4H16BGoe O7KYo2wXs8X3HwQeLllGtUBnG992xXGK/7hVhQX8= X-Received: by 2002:a05:6402:3492:: with SMTP id v18mr1976617edc.345.1643964732787; Fri, 04 Feb 2022 00:52:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwVcZDvspQCzKUyW5YG8zjDVQmYqY/DEAG3sfjKSfnQIzLHqmc3NlVf9LlkkFskfuUgLPJavA== X-Received: by 2002:a05:6402:3492:: with SMTP id v18mr1976597edc.345.1643964732578; Fri, 04 Feb 2022 00:52:12 -0800 (PST) Received: from [192.168.0.81] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id z8sm418238ejc.197.2022.02.04.00.52.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 00:52:11 -0800 (PST) Message-ID: Date: Fri, 4 Feb 2022 09:52:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] HPE BMC GXP SUPPORT Content-Language: en-US To: "Verdun, Jean-Marie" , Rob Herring , "Hawkins, Nick" Cc: David Airlie , Daniel Vetter , Linus Walleij , Bartosz Golaszewski , Corey Minyard , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "David S. Miller" , Jakub Kicinski , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lee Jones , Greg Kroah-Hartman , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Russell King , Arnd Bergmann , Olof Johansson , SoC Team , Shawn Guo , Stanislav Jakubek , Sam Ravnborg , Hao Fang , "Russell King (Oracle)" , Mark Rutland , Marc Zyngier , Ard Biesheuvel , Anshuman Khandual , Wang Kefeng , Lukas Bulwahn , Masahiro Yamada , dri-devel , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Linux I2C , "openipmi-developer@lists.sourceforge.net" , MTD Maling List , netdev , Linux PWM List , "open list:SERIAL DRIVERS" , linux-spi , "open list:THERMAL" , Linux USB List , LINUX-WATCHDOG , linux-arm-kernel References: <20220202165315.18282-1-nick.hawkins@hpe.com> <1FEAAC19-1DD7-40D7-98FD-30C2659E7C0F@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <1FEAAC19-1DD7-40D7-98FD-30C2659E7C0F@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/02/2022 18:07, Verdun, Jean-Marie wrote: > > > Maybe it does not look like, but this is actually a v2. Nick was asked > > to change the naming for the nodes already in v1. Unfortunately it did > > not happen, so we have vuart, spifi, vic and more. > > > It is a waste of reviewers' time to ask them to perform the same review > > twice or to ignore their comments. > > Hi Krysztof, > > Accept our apologies if you think you lose your time, it is clearly not our > intent. > > This is the first time that we (I mean the team) introduce a new arch into > the linux kernel and I must admit that we had hard time to understand > from which angle we needed to start. > > I will probably write a Documentation afterward, as it is easy to find doc > on how to introduce a patch or a driver, but not when you want to > introduce a new chip. > > We are trying to do our best, and clearly want to follow all of your inputs. > Mistakes happen and they are clearly not intentional and not driven in > a way to make you lose your time. > > Helping others, and teaching something new is definitely a way to > optimize your time and this is what you are currently doing with us. > > We appreciate it and hope you will too. I understand, I also maybe over-reacted on this. Just please go through the comments you got for first submission and either apply them or respond why you disagree. The next submissions (patchset split into several commits) should be a v3, preferably with cover letter (git format-patch --cover-letter -v3 ...) where you can document also changes you did to the patchset. It looks for example like this: https://lore.kernel.org/linux-samsung-soc/31da451b-a36c-74fb-5667-d4193284c6cd@canonical.com/T/#mf98d2ac27a8481dc69dd110f9861c8318cade252 or like this (where changelogs are in each patch, although ordering is not correct because dt-bindings should be the first in the series): https://lore.kernel.org/all/20220103233948.198119-1-Mr.Bossman075@gmail.com/ Best regards, Krzysztof