From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robert Foss <robert.foss@linaro.org>,
robdclark@gmail.com, quic_abhinavk@quicinc.com,
dmitry.baryshkov@linaro.org, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
bjorn.andersson@linaro.org, konrad.dybcio@somainline.org,
quic_kalyant@quicinc.com,
angelogioacchino.delregno@somainline.org,
loic.poulain@linaro.org, swboyd@chromium.org,
quic_vpolimer@quicinc.com, vkoul@kernel.org,
dianders@chromium.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Marek <jonathan@marek.ca>,
vinod.koul@linaro.org, quic_jesszhan@quicinc.com,
andersson@kernel.org
Subject: Re: [PATCH v3 11/11] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge
Date: Mon, 5 Dec 2022 17:47:43 +0100 [thread overview]
Message-ID: <ed8c6ca2-e4e1-52f5-0858-8c774819dd73@linaro.org> (raw)
In-Reply-To: <20221205163754.221139-12-robert.foss@linaro.org>
On 05/12/2022 17:37, Robert Foss wrote:
> The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip.
>
> In order to toggle the board to enable the HDMI output,
> switch #7 & #8 on the rightmost multi-switch package have
> to be toggled to On.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
Thank you for your patch. There is something to discuss/improve.
> +
> &slpi {
> status = "okay";
> firmware-name = "qcom/sm8350/slpi.mbn";
> @@ -544,4 +633,20 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> drive-strength = <2>;
> output-low;
> };
> +
> + lt9611_state: lt9611-state {
> + lt9611_rst_pin {
No underscores in node names.
> + pins = "gpio48";
> + function = "normal";
> +
> + output-high;
> + input-disable;
> + };
> +
> + lt9611_irq_pin {
Ditto
> + pins = "gpio50";
> + function = "gpio";
> + bias-disable;
> + };
> + };
> };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-05 16:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 16:37 [PATCH v3 00/11] Enable Display for SM8350 Robert Foss
2022-12-05 16:37 ` [PATCH v3 01/11] dt-bindings: display: msm: Add qcom,sm8350-dpu binding Robert Foss
2022-12-05 16:37 ` [PATCH v3 02/11] dt-bindings: display: msm: Add qcom,sm8350-mdss binding Robert Foss
2022-12-05 21:08 ` Rob Herring
2022-12-05 16:37 ` [PATCH v3 03/11] drm/msm/dpu: Add SM8350 to hw catalog Robert Foss
2022-12-05 16:43 ` Konrad Dybcio
2022-12-07 23:39 ` Dmitry Baryshkov
2022-12-07 23:42 ` Abhinav Kumar
2022-12-28 9:27 ` Robert Foss
2022-12-05 16:37 ` [PATCH v3 04/11] drm/msm/dpu: Add support for SM8350 Robert Foss
2022-12-07 23:40 ` Dmitry Baryshkov
2022-12-07 23:47 ` Abhinav Kumar
2022-12-05 16:37 ` [PATCH v3 05/11] drm/msm: " Robert Foss
2022-12-05 16:43 ` Konrad Dybcio
2022-12-07 23:50 ` Dmitry Baryshkov
2022-12-19 16:18 ` Robert Foss
2022-12-05 16:37 ` [PATCH v3 06/11] arm64: dts: qcom: sm8350: Add &tlmm gpio-line-names Robert Foss
2022-12-05 16:37 ` [PATCH v3 07/11] arm64: dts: qcom: sm8350: Remove mmxc power-domain-name Robert Foss
2022-12-05 16:37 ` [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells Robert Foss
2022-12-05 19:19 ` Georgi Djakov
2022-12-19 16:15 ` Robert Foss
2022-12-05 16:37 ` [PATCH v3 09/11] arm64: dts: qcom: sm8350: Add display system nodes Robert Foss
2022-12-05 16:43 ` Dmitry Baryshkov
2022-12-05 16:46 ` Krzysztof Kozlowski
2022-12-05 16:49 ` Konrad Dybcio
2022-12-05 16:37 ` [PATCH v3 10/11] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes Robert Foss
2022-12-05 16:44 ` Dmitry Baryshkov
2022-12-19 16:11 ` Robert Foss
2022-12-05 16:37 ` [PATCH v3 11/11] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge Robert Foss
2022-12-05 16:47 ` Krzysztof Kozlowski [this message]
2022-12-28 8:26 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed8c6ca2-e4e1-52f5-0858-8c774819dd73@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).