From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F7D87580C for ; Wed, 13 Mar 2024 18:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710354747; cv=none; b=RCGr0ejT13VyVVMV2SXPIeLvkAY1oA5VkMtVDUVQj/4MkfYsJ5DtmLdcUSlDz99DgaY7ouyxG4uV4D2gYocaFh8K5ziWYzAhXnpGUjlzfWOKTWBviR7pivhVmgLZnXIyO+9MSgnPuHoKCDYCG+OfdXfGGVRhccPOjFpAvLoaM94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710354747; c=relaxed/simple; bh=DmirhLhHmvPnVjPsWgHzgkUR3c2uacOPJ52RQk/Sgu4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JXfrw9HNyq+fB42XdKPrkYmqoJPKr7bPvtQo74hztHH/wwHVr6+7oCvO4mTtybpX5oIgwC1iKYJD3gYo3QK6i6ZAlcuLneuN7kvF4QZ0qjw4imSLwi3MnqypS+NFwffVQJWnKCRBZOi5SSHbXjTIzOXjqVoyXx5KTp5KVnMf9cY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=z4nVMhfz; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="z4nVMhfz" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-512e39226efso208227e87.0 for ; Wed, 13 Mar 2024 11:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710354744; x=1710959544; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c46CXhHIkfJWzpxGuQS1ConTUqzy9VFRi62kx/9tVb0=; b=z4nVMhfzBPR1AXSL9XQenL1ciy1Vz9Un+UqPwvmviYoRe9fTtYcyYgDSIDx01NWG1T IHmjlgnFN/hbnPKuNc+g7M3T9S0rdok/wW02JXi7rae3KJ5WYrcbUS5OHx39J/+AhoKo NjoJgFiXK7UpdQmIi3hKl2le3wqzgfQrc2WEQqe7y3w5ncVtcXb2rlc/A8mfCRWI9FO5 qHXWmFg033csT/MOaEpt4ZGUg8A+oXOnfydMYhDB8gSUY9uIGzwJ3HxhfQfzwFwLSbET E/+03zjrIRWS1D523TyMYhba+3GbmLs8maVAxYaTlPZQfelTs7j/9NNXNjjXl5YOY5+O 44CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710354744; x=1710959544; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c46CXhHIkfJWzpxGuQS1ConTUqzy9VFRi62kx/9tVb0=; b=q4JDy5UcGpUTFf6bk2YLLFMYcjNFbP73WGtGZcsVt77Y9akgE+xhM+373QpzdBqyOa F7AX3TRVV7ZWFM3yi4ChCUdOQf5EeHqJi9VN8d5LFdn3MZ+CZ2RovnDLLzwlQtsDwKKz hUOebmm/NO787q8JRCJ4TyI6BEIM9A00uR10/Zqgp8qSMqq851IFmPZN1+Ol0ZOUfbNR fX4Htu4dnMzPrU9LPqctSpFIFV9GdXNwYnph/wqjmE62RxJk+D/0ckGx0bNJ9JhNivm2 RIp0NXFkWdKoTq3g+Nd8lDM3yplbOX4vtpWqEKAo7Vv2SALwZMqFHflb46diyW+W/7fa 7iuQ== X-Forwarded-Encrypted: i=1; AJvYcCXLXfZfrP6ygjq1FziKULMqe9RYsTh6zw44tZReDgos0h3gSlPwmdeUZqK2QsFVb8ZUyoJi5Z+yTNwaPMVJFWNiFimW2Y12we3d3Q== X-Gm-Message-State: AOJu0Yx1KV07gf2ImLXF3iLmkyDGIvSljit1/WYYshkm0KRbnkD3kZ2O je6VZES5AE3b30acNavv2JB3irqxvgB4WD7fouZsbQVWz5yQcHRtrHs7ldXdn3w= X-Google-Smtp-Source: AGHT+IHf78ai9oWGrDz80Yon9mpdoWYbkk2sC2HWOSooJ207ZNh1Pw6Fq+km1zFujDhy0w0y5k/d+w== X-Received: by 2002:a05:6512:368a:b0:513:c146:fc02 with SMTP id d10-20020a056512368a00b00513c146fc02mr2429517lfs.6.1710354743640; Wed, 13 Mar 2024 11:32:23 -0700 (PDT) Received: from [172.30.205.0] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id a8-20020a056512374800b00513b324cc32sm1113882lfs.268.2024.03.13.11.32.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 11:32:23 -0700 (PDT) Message-ID: Date: Wed, 13 Mar 2024 19:32:20 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: Add initial support for rb5gen2 SOM Content-Language: en-US To: Wasim Nazir , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20240313071238.3290-1-quic_wasimn@quicinc.com> <20240313071238.3290-3-quic_wasimn@quicinc.com> From: Konrad Dybcio In-Reply-To: <20240313071238.3290-3-quic_wasimn@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/13/24 08:12, Wasim Nazir wrote: > Rb5gen2 SOM is based on QCS8550 SoC, used for Rb5gen2 board. > This initial version describes regulators & ufs storage. [...] > + > +&ufs_mem_hc { > + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>; > + vcc-supply = <&vreg_l17b_2p5>; > + vcc-max-microamp = <1300000>; > + vccq-supply = <&vreg_l1g_1p2>; > + vccq-max-microamp = <1200000>; You want regulator-allow-set-mode and regulator-allowed-modes, unless for some reason you want them to be in HPM permanently, in which case you should definitely comment why Konrad