devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML
@ 2024-08-05  7:03 Stanislav Jakubek
  2024-08-05  7:04 ` [PATCH v3 2/2] dt-bindings: nvmem: sprd,ums312-efuse: " Stanislav Jakubek
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Stanislav Jakubek @ 2024-08-05  7:03 UTC (permalink / raw)
  To: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Orson Zhai, Baolin Wang, Baolin Wang, Chunyan Zhang,
	Yanxin Huang, huang yanxin, Wenming Wu
  Cc: devicetree, linux-kernel

Convert the Spreadtrum SC27XX eFuse bindings to DT schema.
Rename the file after the only in-tree user, SC2731.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
Changes in V3:
  - add Conor's R-b
  - rebase on next-20240805
  - add lore links to V1 and V2 to the changelog

Changes in V2:
  - don't merge both SPRD eFuse bindings into one
    (ums312 now has separate bindings, see patch 2)
  - drop now unused clocks, clock-names

Link to V2: https://lore.kernel.org/lkml/9fba73ce66f1f3b7b2a8f46e7c21f60cff5a85f0.1721199034.git.stano.jakubek@gmail.com/
Link to V1: https://lore.kernel.org/lkml/ZpJvRePtbaiG94Te@standask-GA-A55M-S2HP/

 .../bindings/nvmem/sc27xx-efuse.txt           | 52 --------------
 .../bindings/nvmem/sprd,sc2731-efuse.yaml     | 68 +++++++++++++++++++
 2 files changed, 68 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/nvmem/sc27xx-efuse.txt
 create mode 100644 Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml

diff --git a/Documentation/devicetree/bindings/nvmem/sc27xx-efuse.txt b/Documentation/devicetree/bindings/nvmem/sc27xx-efuse.txt
deleted file mode 100644
index 586c08286aa9..000000000000
--- a/Documentation/devicetree/bindings/nvmem/sc27xx-efuse.txt
+++ /dev/null
@@ -1,52 +0,0 @@
-= Spreadtrum SC27XX PMIC eFuse device tree bindings =
-
-Required properties:
-- compatible: Should be one of the following.
-	"sprd,sc2720-efuse"
-	"sprd,sc2721-efuse"
-	"sprd,sc2723-efuse"
-	"sprd,sc2730-efuse"
-	"sprd,sc2731-efuse"
-- reg: Specify the address offset of efuse controller.
-- hwlocks: Reference to a phandle of a hwlock provider node.
-
-= Data cells =
-Are child nodes of eFuse, bindings of which as described in
-bindings/nvmem/nvmem.txt
-
-Example:
-
-	sc2731_pmic: pmic@0 {
-		compatible = "sprd,sc2731";
-		reg = <0>;
-		spi-max-frequency = <26000000>;
-		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-controller;
-		#interrupt-cells = <2>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		efuse@380 {
-			compatible = "sprd,sc2731-efuse";
-			reg = <0x380>;
-			#address-cells = <1>;
-			#size-cells = <1>;
-			hwlocks = <&hwlock 12>;
-
-			/* Data cells */
-			thermal_calib: calib@10 {
-				reg = <0x10 0x2>;
-			};
-		};
-	};
-
-= Data consumers =
-Are device nodes which consume nvmem data cells.
-
-Example:
-
-	thermal {
-		...
-		nvmem-cells = <&thermal_calib>;
-		nvmem-cell-names = "calibration";
-	};
diff --git a/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml b/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml
new file mode 100644
index 000000000000..dc25fe3d1841
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/sprd,sc2731-efuse.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/nvmem/sprd,sc2731-efuse.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Spreadtrum SC27XX PMIC eFuse
+
+maintainers:
+  - Orson Zhai <orsonzhai@gmail.com>
+  - Baolin Wang <baolin.wang7@gmail.com>
+  - Chunyan Zhang <zhang.lyra@gmail.com>
+
+properties:
+  compatible:
+    enum:
+      - sprd,sc2720-efuse
+      - sprd,sc2721-efuse
+      - sprd,sc2723-efuse
+      - sprd,sc2730-efuse
+      - sprd,sc2731-efuse
+
+  reg:
+    maxItems: 1
+
+  hwlocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - hwlocks
+
+allOf:
+  - $ref: nvmem.yaml#
+  - $ref: nvmem-deprecated-cells.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pmic {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      efuse@380 {
+        compatible = "sprd,sc2731-efuse";
+        reg = <0x380>;
+        hwlocks = <&hwlock 12>;
+        #address-cells = <1>;
+        #size-cells = <1>;
+
+        /* Data cells */
+        fgu_calib: calib@6 {
+          reg = <0x6 0x2>;
+          bits = <0 9>;
+        };
+
+        adc_big_scale: calib@24 {
+          reg = <0x24 0x2>;
+        };
+
+        adc_small_scale: calib@26 {
+          reg = <0x26 0x2>;
+        };
+      };
+    };
+...
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/2] dt-bindings: nvmem: sprd,ums312-efuse: convert to YAML
  2024-08-05  7:03 [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML Stanislav Jakubek
@ 2024-08-05  7:04 ` Stanislav Jakubek
  2024-10-05 12:04 ` [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: " Stanislav Jakubek
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Stanislav Jakubek @ 2024-08-05  7:04 UTC (permalink / raw)
  To: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Orson Zhai, Baolin Wang, Baolin Wang, Chunyan Zhang,
	Yanxin Huang, huang yanxin, Wenming Wu
  Cc: devicetree, linux-kernel

Convert the Spreadtrum UMS312 eFuse bindings to DT schema.
Adjust filename to match compatible.

Note: the UMS312 clock bindings include doesn't seem to exist (yet?), so
      the UMS512 one was used for the "CLK_EFUSE_EB" define.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
---
Changes in V3:
  - add Conor's R-b
  - rebase on next-20240805
  - add lore links to V1 and V2 to the changelog

Changes in V2:
  - new patch, split from the merged bindings in V1

Link to V2: https://lore.kernel.org/lkml/17ccb895a54d7754d3ddd6de633ad045a5271b4b.1721199034.git.stano.jakubek@gmail.com/
Link to V1: https://lore.kernel.org/lkml/ZpJvRePtbaiG94Te@standask-GA-A55M-S2HP/

 .../bindings/nvmem/sprd,ums312-efuse.yaml     | 61 +++++++++++++++++++
 .../devicetree/bindings/nvmem/sprd-efuse.txt  | 39 ------------
 2 files changed, 61 insertions(+), 39 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/nvmem/sprd,ums312-efuse.yaml
 delete mode 100644 Documentation/devicetree/bindings/nvmem/sprd-efuse.txt

diff --git a/Documentation/devicetree/bindings/nvmem/sprd,ums312-efuse.yaml b/Documentation/devicetree/bindings/nvmem/sprd,ums312-efuse.yaml
new file mode 100644
index 000000000000..00e0fd1353a3
--- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/sprd,ums312-efuse.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/nvmem/sprd,ums312-efuse.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Spreadtrum UMS312 eFuse
+
+maintainers:
+  - Orson Zhai <orsonzhai@gmail.com>
+  - Baolin Wang <baolin.wang7@gmail.com>
+  - Chunyan Zhang <zhang.lyra@gmail.com>
+
+properties:
+  compatible:
+    const: sprd,ums312-efuse
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: enable
+
+  hwlocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - hwlocks
+
+allOf:
+  - $ref: nvmem.yaml#
+  - $ref: nvmem-deprecated-cells.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/sprd,ums512-clk.h>
+
+    efuse@32240000 {
+      compatible = "sprd,ums312-efuse";
+      reg = <0x32240000 0x10000>;
+      clocks = <&aonapb_gate CLK_EFUSE_EB>;
+      clock-names = "enable";
+      hwlocks = <&hwlock 8>;
+      #address-cells = <1>;
+      #size-cells = <1>;
+
+      /* Data cells */
+      thermal_calib: calib@10 {
+        reg = <0x10 0x2>;
+      };
+    };
+...
diff --git a/Documentation/devicetree/bindings/nvmem/sprd-efuse.txt b/Documentation/devicetree/bindings/nvmem/sprd-efuse.txt
deleted file mode 100644
index 96b6feec27f0..000000000000
--- a/Documentation/devicetree/bindings/nvmem/sprd-efuse.txt
+++ /dev/null
@@ -1,39 +0,0 @@
-= Spreadtrum eFuse device tree bindings =
-
-Required properties:
-- compatible: Should be "sprd,ums312-efuse".
-- reg: Specify the address offset of efuse controller.
-- clock-names: Should be "enable".
-- clocks: The phandle and specifier referencing the controller's clock.
-- hwlocks: Reference to a phandle of a hwlock provider node.
-
-= Data cells =
-Are child nodes of eFuse, bindings of which as described in
-bindings/nvmem/nvmem.txt
-
-Example:
-
-	ap_efuse: efuse@32240000 {
-		compatible = "sprd,ums312-efuse";
-		reg = <0 0x32240000 0 0x10000>;
-		clock-names = "enable";
-		hwlocks = <&hwlock 8>;
-		clocks = <&aonapb_gate CLK_EFUSE_EB>;
-
-		/* Data cells */
-		thermal_calib: calib@10 {
-			reg = <0x10 0x2>;
-		};
-	};
-
-= Data consumers =
-Are device nodes which consume nvmem data cells.
-
-Example:
-
-	thermal {
-		...
-
-		nvmem-cells = <&thermal_calib>;
-		nvmem-cell-names = "calibration";
-	};
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML
  2024-08-05  7:03 [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML Stanislav Jakubek
  2024-08-05  7:04 ` [PATCH v3 2/2] dt-bindings: nvmem: sprd,ums312-efuse: " Stanislav Jakubek
@ 2024-10-05 12:04 ` Stanislav Jakubek
  2024-10-26 11:12 ` Stanislav Jakubek
  2024-10-28 16:01 ` Srinivas Kandagatla
  3 siblings, 0 replies; 5+ messages in thread
From: Stanislav Jakubek @ 2024-10-05 12:04 UTC (permalink / raw)
  To: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Orson Zhai, Baolin Wang, Baolin Wang, Chunyan Zhang,
	Yanxin Huang, huang yanxin, Wenming Wu
  Cc: devicetree, linux-kernel

Gentle reminder about this series.
It's been sitting on the mailing list for ~2 months.

Stanislav

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML
  2024-08-05  7:03 [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML Stanislav Jakubek
  2024-08-05  7:04 ` [PATCH v3 2/2] dt-bindings: nvmem: sprd,ums312-efuse: " Stanislav Jakubek
  2024-10-05 12:04 ` [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: " Stanislav Jakubek
@ 2024-10-26 11:12 ` Stanislav Jakubek
  2024-10-28 16:01 ` Srinivas Kandagatla
  3 siblings, 0 replies; 5+ messages in thread
From: Stanislav Jakubek @ 2024-10-26 11:12 UTC (permalink / raw)
  To: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Orson Zhai, Baolin Wang, Baolin Wang, Chunyan Zhang,
	Yanxin Huang, huang yanxin, Wenming Wu
  Cc: devicetree, linux-kernel

Hi Srini,

anything preventing this from getting merged?

Stanislav

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML
  2024-08-05  7:03 [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML Stanislav Jakubek
                   ` (2 preceding siblings ...)
  2024-10-26 11:12 ` Stanislav Jakubek
@ 2024-10-28 16:01 ` Srinivas Kandagatla
  3 siblings, 0 replies; 5+ messages in thread
From: Srinivas Kandagatla @ 2024-10-28 16:01 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Orson Zhai,
	Baolin Wang, Chunyan Zhang, Yanxin Huang, huang yanxin,
	Wenming Wu, Baolin Wang, Stanislav Jakubek
  Cc: devicetree, linux-kernel


On Mon, 05 Aug 2024 09:03:02 +0200, Stanislav Jakubek wrote:
> Convert the Spreadtrum SC27XX eFuse bindings to DT schema.
> Rename the file after the only in-tree user, SC2731.
> 
> 

Applied, thanks!

[1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML
      commit: 786700e267b0ebe89d72eaa18146f1cc602461a4
[2/2] dt-bindings: nvmem: sprd,ums312-efuse: convert to YAML
      commit: 24c50e7003bf699194f223711f06c1a5fb3eca29

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-10-28 16:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-05  7:03 [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: convert to YAML Stanislav Jakubek
2024-08-05  7:04 ` [PATCH v3 2/2] dt-bindings: nvmem: sprd,ums312-efuse: " Stanislav Jakubek
2024-10-05 12:04 ` [PATCH v3 1/2] dt-bindings: nvmem: sprd,sc2731-efuse: " Stanislav Jakubek
2024-10-26 11:12 ` Stanislav Jakubek
2024-10-28 16:01 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).