From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f11.google.com (mail-pj2-f11.google.com [74.125.227.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C2D415F2E for ; Thu, 3 Sep 2026 07:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788421458; cv=none; b=gkEsG2JrPM0pMdfBUlmZYpozzAsPjxHPl314cDjH1F016KcgozKPEzaU9fsNM0CV9BkT1jwY7P983d8wCPkAj5qoEHoV2zEKYA4MBZQWrOBJ/jlh5fKsdnMvLL0pzgQmC6RZ00IRXr753NUb5+3xmDnn8hy+xBEpGEBJVsKalys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788421458; c=relaxed/simple; bh=3yBQW4M/U3usW5Bkp7d0eQGmzAcbhHS+cvRXVoYulCU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lplnrm2jzw6x1tRWz+J+gQrL1SLHsTJi5YPeGRTZqIRonwyNV7Jfs3LPsCis6CbEVdyJ1eL6lpjn85Otsi2vK1o28FTSYWTaEeC4tOBYV+xRTZ7NYR9Aj0FJEDTZ+OMU/BLVOc337BJnpWhzHifZUNf6A5ne9j1PWg8gkkfocNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xnqrar2n; arc=none smtp.client-ip=74.125.227.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xnqrar2n" Received: by mail-pj2-f11.google.com with SMTP id d9443c01a7336-2ceb5a39c48so5438135ad.1 for ; Thu, 03 Sep 2026 00:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788421452; x=1789026252; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oUbrqLv47LI31OwZX/zERcJxLxOgrZ94RwwzK9bj0r8=; b=Xnqrar2nWev6qOfBQMa1/a9DiIkw6FZjcf2U78Ru2/vPoc3zjssXDHl8Q6nJy/+QEB 0fQ8/bgdLZDoNQtFoBLVwQ2pTHLztek5+iT/pOMUnYCU/Iu96z3PH4HKpUIj+w5ibdoG OeEDu4j1rN/sC4tOU8eU6GijZQW48yIshf+qXdtYoSiaD6N1FVwxSwD+xy03rkVfQ7Yw Kx3WiClILqrxhpAljoizbDp0LABbr9/S7IblaidskNx2J9shVaPy9++bSo3FAUidsIJr RfZ+MwH2gwv49jVbinY5/9Ic9D5gfPfhsqZjLd9WVanRxdAIiPSHxrQD8v8f75ELkpTV 2ofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788421452; x=1789026252; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oUbrqLv47LI31OwZX/zERcJxLxOgrZ94RwwzK9bj0r8=; b=W5WhrW6bPxXgOVNRFSSArSmj7oWihanQ2I/tIEjFZsldiO5iedMHOm4asj/RFlPxGp r4aTWZdJ0ERJFpfRWOXP6f7sXMXVwPc+wAi4azoLVda25urRF0VAA7cWZmKBG4lgCXxO coP4zlZHqBfdkh744P3/JW/t/AhE8Q5XgeDFxp1bZ+F34JZkFMdCY555vkyvOH3NP6VG r/Vx6zkrUO6TS/G/XPNQDHCi8nK8wdnDrD7arVjU04TtKvFS+fsoLBCgZ4uCv0G4xC2T PELcEG9ABX8V9ETyeZLzuFmw4b7I4vkkKeLhfonTQHjGVy5IbogsgZInJX0sY4MRjpLc R3iA== X-Forwarded-Encrypted: i=1; AKwUvBwGDNNj6uFvUXqAmw1qmvwu9JQqk3+BnFl+ENSZ0eWBj3IoE0X/hgWnDe+da185LixWeaDxU85WYkWn@vger.kernel.org X-Gm-Message-State: AFuF++ktW3FC8o6fHqexy7h2LQGqnpdLXDIyhvMDLSxVIv/1zs2b+d+S lrlZleK1SILDUT/yPWp6aY6LLQzpxG+1y+lUm+N40piroFDhu3pvkOFy X-Gm-Gg: AYBFou1XYBG3BT3nFGtQ2sEe0/WFMBOb8bflKJz1iKPDLFVEWw/NhmRqU5BoYo7Vs0Z L7B8mkA9C+gRu0y8EAiXi017iwX/gjtiR5Adt7M7gCytF6Jp+l8OVAmMzL9bdzITuparx+t2HwV W3qr8YnC/YvKDDYOABqWlMySALk9quXcigIUwqyeSPJjF142JVuPAS/SShrr8ARTHOx+4S4Lzmi qan5Nlr8L35hXDCtutsHe+Tnsj10MSffBtmN0G5a5CtlQ76yot3zpOeP8iXoU95+th/6zYm8se8 4nR2qKH4fYRbK3y41n6b4l09LbuBpOV5WccNbAjLBn1bN8ct3AkNt04Dpk0mu058YamdKOqpElV mteeFqwF26JaupX86Dha40Cb97qVtDV78+sB4oM15GSiig+H34vH3ESnkFRXYgNnhOct+9KHxbM cPRSqEplr0ENbkAeAzekJj56Z6H6n7kOmZ7/ZzzlKASjJPMkI4wGz1RRdVFmEdjuqSi3fEC74y0 XHr6IM= X-Received: by 2002:a17:902:e809:b0:2d7:4b42:9352 with SMTP id d9443c01a7336-2daec60af43mr131715375ad.3.1788421451864; Thu, 03 Sep 2026 00:44:11 -0700 (PDT) Received: from [10.125.112.20] ([122.11.210.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2dafe62d7c2sm5931425ad.29.2026.09.03.00.44.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 00:44:11 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 15:43:58 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/10] kdump: reduce vmcore size and capture time To: Baoquan He Cc: catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, robh@kernel.org, saravanak@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, m.szyprowski@samsung.com, mark.rutland@arm.com, kernel@xen0n.name, alex@ghiti.fr, hpa@zytor.com, ruirui.yang@linux.dev, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20260902073116.802752-1-chenwandun1@gmail.com> <6aef2f48-1cc5-408d-a5a2-2b4b4d45ad7b@gmail.com> Content-Language: en-US From: Wandun In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/3/26 15:31, Baoquan He wrote: > On 09/03/26 at 03:05pm, Wandun wrote: >> >> >> On 9/2/26 16:53, Baoquan He wrote: >>> Hi Wandun, >>> >>> On 09/02/26 at 03:31pm, Wandun Chen wrote: >>>> From: Wandun Chen >>>> >>>> On SoCs that carve out large firmware-owned reserved memory (GPU, >>>> camera ISP, ...), kdump currently dumps those carveouts as part of >>>> system RAM even though their contents are firmware state that is not >>>> useful for kernel crash analysis. >>>> >>>> This series introduces a MEMBLOCK_NODUMP flag in memblock to filter >>>> reserved memory on DT-based architectures (arm64, riscv, loongarch). >>>> Reserved regions default are marked MEMBLOCK_NODUMP so kdump omits them; >>>> reusable CMA regions are different because their pages are handed back >>>> to the buddy allocator and may carry crash-relevant data. >>>> >>>> ACPI systems already filter reserved memory out of the vmcore through >>>> their existing path; only DT-based systems currently fail to filter these >>>> regions, which is what this series addresses. The flag lives in memblock >>>> itself rather than in a DT-only structure, so the mechanism is generic and >>>> both ACPI and DT systems can benefit from it (suggested by Rob, thanks) [1]. >>> >>> Thanks for the effort. I am not against this patchset, and I haven't >>> went through it carefully. Just from the cover letter, you mentioned >>> generic, I am wondering if this can be generic for excluding other >>> memory regions. Asking this because I try to find a way to exclude >>> unwanted memory regions too, please check below link where there's >>> the relevant discussion. We definitely don't like inventing wheels >>> time after time. Do you think this memblock region excluding can >>> be used in other places of kernel? >>> >>> https://lore.kernel.org/all/aoLFai0gzzH2bGgy@MiWiFi-R3L-srv/T/#u >> >> >> Thanks for taking a look, and for the pointer to the crash-wipe thread. >> >> To answer your question directly: the exclusion mechanism in this series >> is already generic, memblock_mark_nodump() is the entry point. Any code >> that wants a region out of the vmcore just marks it MEMBLOCK_NODUMP, when >> preparing vmcore elf header by walking memblock, these regionss are skipped; >> This series is simply one caller, marking the DTS /reserved-memory and >> /memreserve/ regions with MEMBLOCK_NODUMP. > > Thanks, for memory not allocated from memblock, e.g buddy, is it still > good? Yes, still good, only need to pass the physical range to memblock_mark_nodump(). > >> >> x86 currently builds the vmcore elf header from iomem_resource, not >> memblock; it could be switched to memblock, but that would bring no >> benefit for the problem this series solves, so this series makes no >> x86 change. I'd personally be in favor of switching to memblock for >> a unified implementation across architectures. >> >> Best regards >> Wandun >> >> >>> >>>> >>>> Since the reserved memory regions are filtered out, the vmcore is >>>> smaller in size and faster to produce. >>>> >>>> The series is based on linux-next and is organized as follows: >>>> >>>> Patches 1-4: Preparation and bugfixes: fix the missing HugeTLB >>>> flagname, switch riscv crash_mem to memblock, fold the >>>> duplicated per-arch memblock walks into the weak >>>> defaults, and serialize crash header preparation against >>>> memory hotplug. >>>> Patches 5-9: NODUMP infrastructure: switch crash_core to >>>> for_each_mem_region(), introduce the MEMBLOCK_NODUMP >>>> flag, add a dumpable flag to struct reserved_mem, and >>>> mark /reserved-memory and /memreserve/ entries with >>>> MEMBLOCK_NODUMP flag. >>>> Patch 10: Exclude MEMBLOCK_NODUMP regions from the vmcore ELF >>>> header. >>>> >>>> In v5, Sashiko found some pre-existing issues related to reserved-memory, >>>> and has no dependency on this series, so these issues have been addressed >>>> in a separate series [2]. >>>> >>>> v5 --> v6: >>>> 1. Serialize crash header preparation against memory hotplug to avoid >>>> out-of-bounds or use-after-free issues. >>>> >>>> 2. MEMBLOCK_NODUMP marking is now done after memblock allows resizing, >>>> avoiding a panic from too few regions before resize is permitted. >>>> >>>> 3. Reordered the patches, put pre-existing bugfixes earlier in the series. >>>> >>>> >>>> v4 --> v5: >>>> 1. Rework the mechanism around a memblock-level MEMBLOCK_NODUMP flag >>>> (suggested by Rob) instead of the v4 opt-in 'dumpable' flag on >>>> DT-only struct reserved_mem. >>>> 2. Switch the riscv vmcore elf header preparation to use memblock >>>> instead of the resource tree, aligning it with arm64 and loongarch, >>>> so riscv also can exclude reserved memory from vmcore. >>>> 3. Deduplicate the vmcore elf header preparation: arm64, riscv and >>>> loongarch open-coded the same logic, so fold it into shared >>>> __weak defaults in crash_core. >>>> 4. Drop the v4 patch that saved /memreserve/ entries into the >>>> reserved_mem array; /memreserve/ is now marked MEMBLOCK_NODUMP >>>> directly. >>>> >>>> v3 --> v4: >>>> 1. Rebase this series on v7.2-rc1. >>>> 2. Add two cleanup patches (patch 02/03). >>>> 3. Simplify patch 03 to avoid checking whether initial_boot_params is >>>> NULL multiple times, suggested by Rob. >>>> >>>> v2 --> v3: >>>> 1. Fix out-of-bounds issue if device tree lacks /reserved-memory node. >>>> 2. Fix UAF issue when alloc_reserved_mem_array() fails. >>>> 3. Add some prepare patches. >>>> >>>> v1 --> v2: >>>> 1. v1 added an opt-out DT property ('linux,no-dump'). Per Rob's >>>> feedback [3], v2 drop that property and exclude reserve memory >>>> by default. >>>> 2. Split some prepared patches from the original patches. >>>> 3. Address coding-style comments on patch 5 from Rob. >>>> >>>> [1] https://lore.kernel.org/lkml/20260723234126.GA3253409-robh@kernel.org/ >>>> [2] https://lore.kernel.org/lkml/20260818092420.2859026-1-chenwandun1@gmail.com/ >>>> [3] https://lore.kernel.org/lkml/20260506144542.GA2072596-robh@kernel.org/ >>>> >>>> Meijing Zhao (1): >>>> mm: memblock: add missing HugeTLB flag name >>>> >>>> Wandun Chen (9): >>>> riscv: build crash_mem ranges from memblock instead of resource tree >>>> crash_core: fold duplicated memblock arch hooks into the weak default >>>> crash_core: serialize crash header preparation against hotplug >>>> crash_core: replace for_each_mem_range() with for_each_mem_region() >>>> memblock: introduce MEMBLOCK_NODUMP flag >>>> of: reserved_mem: add dumpable flag to opt-in vmcore >>>> of: reserved_mem: mark /reserved-memory entries with MEMBLOCK_NODUMP >>>> of: reserved_mem: mark /memreserve/ entries as MEMBLOCK_NODUMP >>>> crash_core: skip MEMBLOCK_NODUMP regions when building vmcore ELF >>>> header >>>> >>>> arch/arm64/kernel/machine_kexec_file.c | 29 ------------ >>>> arch/loongarch/kernel/machine_kexec_file.c | 27 ------------ >>>> arch/riscv/Kconfig | 2 +- >>>> arch/riscv/kernel/machine_kexec_file.c | 33 -------------- >>>> arch/x86/kernel/crash.c | 2 +- >>>> drivers/of/fdt.c | 2 + >>>> drivers/of/of_private.h | 2 + >>>> drivers/of/of_reserved_mem.c | 48 ++++++++++++++++++++ >>>> include/linux/crash_core.h | 2 + >>>> include/linux/memblock.h | 9 ++++ >>>> include/linux/of_reserved_mem.h | 1 + >>>> kernel/crash_core.c | 51 ++++++++++++++++++++-- >>>> kernel/dma/contiguous.c | 1 + >>>> mm/memblock.c | 17 ++++++++ >>>> 14 files changed, 131 insertions(+), 95 deletions(-) >>>> >>>> -- >>>> 2.43.0 >>>> >>