Re: [PATCH V5 4/6] slim: qcom: Add Qualcomm Slimbus controller driver

[Sagar Dharia <sdharia@codeaurora.org>]

[-- Attachment #1: Type: text/plain, Size: 1937 bytes --]

On 4/28/2016 5:28 AM, Mark Rutland wrote:
> On Wed, Apr 27, 2016 at 05:58:07PM -0600, Sagar Dharia wrote:
>
>> + - interrupts : Interrupt number used by this controller
>> + - clocks : Interface and core clocks used by this slimbus controller
>> + - clock-names : Required clock-name entries are:
>> +	"iface_clk" : Interface clock for this controller
>> +	"core_clk" : Interrupt for controller core's BAM
>> +
>> +Optional property:
>> + - reg entry for slew rate : If slew rate control register is provided, this
>> +	entry should be used.
>> + - reg-name for slew rate: "slimbus_slew_reg"
> Per the example below, this looks like an element in a separate system
> controller block, or part of some other controller that's not modelled
> here.
>
> What is this, exactly?
You are right, this entry is outside the controller block, but needs to 
be programmed by slimbus controller to make sure slew-rate of the clock 
line is controlled to be within spec.

I will incorporate other comments in the upcoming patch.

Thanks
Sagar
>
>> +
>> +Example:
>> +	slim@28080000 {
>> +		compatible = "qcom,slim-msm";
>> +		#address-cells = <4>;
>> +		#size-cells = <0>;
>> +		reg = <0x28080000 0x2000>, <0x80207C 4>;
>> +		reg-names = "slimbus_physical", "slimbus_slew_reg";
>> +		interrupts = <0 33 0>;
>> +		clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>;
>> +		clock-names = "iface_clk", "core_clk";
>> +
>> +		codec@0217.0060.01.00 {
>> +			compatible = "qcom,wcdv1", "slim";
> As mentioned on the generic binding, please drop the "slim" fallback
> here.
>
>> +			reg = <0x217 0x60 0x1 0x0>;
>> +		};
>> +	};
> Thanks,
> Mark.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


[-- Attachment #2: Type: text/html, Size: 3056 bytes --]