From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhang Yi <zhangyi@everest-semi.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
devicetree@vger.kernel.org
Cc: tiwai@suse.com, amadeuszx.slawinski@linux.intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Subject: Re: [PATCH v5 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
Date: Fri, 7 Mar 2025 14:12:36 +0100 [thread overview]
Message-ID: <ede60a70-f93f-42e7-aba5-2e5cfb4ac16a@kernel.org> (raw)
In-Reply-To: <20250307091916.100164-3-zhangyi@everest-semi.com>
On 07/03/2025 10:19, Zhang Yi wrote:
> Add device tree binding documentation for Everest ES8389 which
> is different from ES8388
>
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>
> ---
> .../bindings/sound/everest,es8389.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/everest,es8389.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/everest,es8389.yaml b/Documentation/devicetree/bindings/sound/everest,es8389.yaml
You got feedback how to create CC list. Two times.
You still create it incorrectly and Cc address which does not exist in
the kernel and is a proof you work on wrong tree, which I asked to correct.
What's more, there is still no changelog and you never responded to
review comments.
Can you slow down with resubmits and rethink the received feedback? I
expect that feedback to be responded to, so I am not wasting time here
repeating the same every time.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-07 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 9:19 [PATCH v5 0/2] ASoC: codecs: add support for ES8389 Zhang Yi
2025-03-07 9:19 ` [PATCH v5 1/2] " Zhang Yi
2025-03-07 9:19 ` [PATCH v5 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC Zhang Yi
2025-03-07 13:12 ` Krzysztof Kozlowski [this message]
2025-03-10 7:36 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-03-09 9:52 Zhang Yi
2025-03-10 7:51 Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede60a70-f93f-42e7-aba5-2e5cfb4ac16a@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).