From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7AD4380; Wed, 11 Jun 2025 18:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749667455; cv=none; b=B1Ln1ctxOclVegCBbCVah4hXWTWJuOj20p8aJ+ihmFutks6Y6WJwLaUrWt1G40+m0YAIMkE8FGtff79+Cs82he80cKIJtC5uzD0oOtFdJbKw2bqLuD48juI7omiueBUDZXHxxiofupQwScMk9EFzzrJ5Sol70S6LMoikwJOAObU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749667455; c=relaxed/simple; bh=0Y19FOGk8myMlwMfTdM5H4mSwwbBsWo93rX/f568q98=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gHt+xTzH39Rnw4FGTPqqh1Rf0u1Mjxn+6e3uExK21ceF2jXlRTceUxrV2XCNIeY7PRHze53hATg2Tcd1rtwx+Ur2wr+padfHaHaxtL4Ir4D63e0VIHAStQsD3IZ5KjbSc4wHy5uqeHsy/c1k+LtWZfD39viytL59+Xt/SY1bfRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iGFCpCTZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iGFCpCTZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD052C4CEE3; Wed, 11 Jun 2025 18:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749667454; bh=0Y19FOGk8myMlwMfTdM5H4mSwwbBsWo93rX/f568q98=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iGFCpCTZrsKYC0IDwdrcQGmr2hkdhm76Z12iG/RVLXRUwzJLlv5whVhXsO9glSuj9 o2BjpFodlGHdnApf3jNLl6wITOX+8yzJJWx1/rLf0/jC7z0O0y3VqTjBVEHSzYJjzv DfwuPsSX8WZZ8o0J/fp29CrVhpgevZ+9CmjW1oCPPMxBGhEB1+InoTaPIXO2uGug6d itwWjXBk0rFPZdN+dfjxs1W81OE3cuS0stSFH8vA4lCcojy5uSIkc9EqSa+Qon1Lct E78HEYcj6+2h7hqrZgs7+TpheNARFAzG66QFu6kkUS388sWteGaBMH+NyjQ2jCV+b3 dWqZNCzmsHmaw== Message-ID: Date: Wed, 11 Jun 2025 20:44:08 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: Add Apple SoC GPU To: fnkl.kernel@gmail.com Cc: asahi@lists.linux.dev, Maarten Lankhorst , Simona Vetter , David Airlie , Neal Gompa , Maxime Ripard , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Thomas Zimmermann , Alyssa Rosenzweig , Janne Grunau , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250611-sgx-dt-v1-0-7a11f3885c60@gmail.com> <20250611-sgx-dt-v1-1-7a11f3885c60@gmail.com> Content-Language: en-US From: Sven Peter In-Reply-To: <20250611-sgx-dt-v1-1-7a11f3885c60@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, I think there's a "gpu: " missing in the subject. On 11.06.25 19:32, Sasha Finkelstein via B4 Relay wrote: > From: Sasha Finkelstein > > Add bindings for the GPU present in Apple SoCs > > Signed-off-by: Sasha Finkelstein > --- > Documentation/devicetree/bindings/gpu/apple,agx.yaml | 95 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 96 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/apple,agx.yaml b/Documentation/devicetree/bindings/gpu/apple,agx.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..23df3ebd689b1e885eb99ca573343fe7f2d09dc4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/apple,agx.yaml > @@ -0,0 +1,95 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpu/apple,agx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple SoC GPU > + > +maintainers: > + - Sasha Finkelstein > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: apple,agx-g13g > + - items: > + - enum: > + - apple,agx-g13s > + - apple,agx-g13c > + - apple,agx-g13d > + - const: apple,agx-g13x > + - items: > + - const: apple,agx-g14g > + reg: > + items: > + - description: ASC coprocessor control Apple calls these co-processors ASC but I'm not sure that's really helpful to describe them. Maybe just "GPU coprocessor control registers"? > + - description: GPU block MMIO registers > + > + reg-names: > + items: > + - const: asc > + - const: sgx > + > + power-domains: > + maxItems: 1 > + > + mboxes: > + maxItems: 1 > + > + memory-region: > + items: > + - description: Region containing GPU MMU TTBs > + - description: Region containing GPU MMU page tables > + - description: > + Region containing a shared handoff structure for VM > + management coordination > + - description: Driver-opaque calibration blob > + - description: Calibration blob Like Alyssa mentioned, this description also raises more questions than it answers for me. Do we know what these two blobs contain or why they are two separate blobs? > + - description: Shared global variables with GPU firmware > + > + memory-region-names: > + items: > + - const: ttbs > + - const: pagetables > + - const: handoff > + - const: hw-cal-a > + - const: hw-cal-b > + - const: globals > + > + apple,firmware-compat: Nit: I'd prefer something like apple,firmware-abi here. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 3 > + description: > + MacOS version the current firmware is paired with, used to pick > + the version of firmware ABI to be used. > + Bootloader will overwrite this > + > +required: > + - compatible > + - reg > + - mboxes > + - memory-region > + - apple,firmware-compat > + > +additionalProperties: false > + > +examples: > + - | > + #include No need for the include for this example. > + gpu@6400000 { > + compatible = "apple,agx-g13g"; > + reg = <0x6400000 0x40000>, > + <0x4000000 0x1000000>; > + reg-names = "asc", "sgx"; > + mboxes = <&agx_mbox>; > + power-domains = <&ps_gfx>; > + memory-region = <&uat_ttbs>, <&uat_pagetables>, <&uat_handoff>, > + <&gpu_hw_cal_a>, <&gpu_hw_cal_b>, <&gpu_globals>; > + memory-region-names = "ttbs", "pagetables", "handoff", > + "hw-cal-a", "hw-cal-b", "globals"; > + > + apple,firmware-compat = <0 0 0>; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index a92290fffa163f9fe8fe3f04bf66426f9a894409..2a32c9c4ee355a1109a3e2031ea3663c39cc8c68 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2331,6 +2331,7 @@ F: Documentation/devicetree/bindings/arm/apple/* > F: Documentation/devicetree/bindings/clock/apple,nco.yaml > F: Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml > F: Documentation/devicetree/bindings/dma/apple,admac.yaml > +F: Documentation/devicetree/bindings/gpu/apple,agx.yaml > F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml > F: Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml > F: Documentation/devicetree/bindings/interrupt-controller/apple,* > Best, Sven