From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A10C433EF for ; Sun, 10 Apr 2022 14:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237923AbiDJOST (ORCPT ); Sun, 10 Apr 2022 10:18:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234650AbiDJOST (ORCPT ); Sun, 10 Apr 2022 10:18:19 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 035823BFA2 for ; Sun, 10 Apr 2022 07:16:07 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id k23so25969435ejd.3 for ; Sun, 10 Apr 2022 07:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+Ier55YBq9PNXban+FxSvSragDYPhYPa5evEDXq/Fig=; b=VXS41Q2rOvE4Ds0Sb8/throKElXhXYFYdLPD2TOODisPypChyK2EdZGnQ9nI3Uiaft wQTZwA02Whk5jsj59qPhldaBI6sINF4EN4OMfx3BtAdsDWhWdtPfHqzIA46FPNL4okob 8JSG3Y9pmZJ7zNNBMb0/b74yPOV3dJ33RN+9XF0Zpe1VW9KlZDJnD3RASREkmhk5PiaQ NGwSft2kTOs1ItjA4FFuG5bUU/ZGYRNuTmDco9eRXanTVFtf24Yi/oaCAas0xTw4KKbq COiRu7PDBoCZhR71sm7jFNzCajya62uuo1eHbWZpTToj5mQOaGWBYFfjzghRuzxUum6x bo7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+Ier55YBq9PNXban+FxSvSragDYPhYPa5evEDXq/Fig=; b=apNt5siO389OZvpOeS8omc6gTNQbR/qNvkSdbfrAeeMvjXF52Pb/+JoMphTn9HXdeR BOy34sTVvKMY6eeAocjjY+RLrJxsZCYY07fYl+GWvgwR3qmPm07qG1EsOlw0VUEj2XZL 9FIJ95yRuJ/9vcs+VvOGZs4/dOvr1Y7UJtc1Qou82jixX+QEsHVht0yGIWM2LAnMGfJH kRqCPnpR6TYEBvZ9yEekgZrwzCjy29B4+F9jkacuOD74Ep4T0NFWW+CbDE2HirOe4ZCf 2rGq/7fCWnH7kln6O+jQq5Zw4Vi8rDU8VLbQAlyPLw6GeSNdlzX7yAMySWzkz5Ew9Kf2 J8BA== X-Gm-Message-State: AOAM531vmnrt6HsnhMg8W+a7p7N4l0KsHDKbPP0Y7NErkkY0F08odEls JSRLRRSBGh1Uj8Mv0GvspFy2MQ== X-Google-Smtp-Source: ABdhPJzxe2slplshlwQ1W1F6InK0Nb005BmkiOZEL7lFbVsYAFgraYsxv06pLKpb5tSKR1gIsEhcSw== X-Received: by 2002:a17:907:3e0d:b0:6e0:daaa:63e0 with SMTP id hp13-20020a1709073e0d00b006e0daaa63e0mr26169491ejc.657.1649600165519; Sun, 10 Apr 2022 07:16:05 -0700 (PDT) Received: from [192.168.0.188] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id t19-20020a056402525300b0041952a1a764sm13592317edd.33.2022.04.10.07.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Apr 2022 07:16:04 -0700 (PDT) Message-ID: Date: Sun, 10 Apr 2022 16:16:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v1 1/6] dt-bindings: gpio: realtek-otto: Add rtl9300 compatible Content-Language: en-US To: Sander Vanheule , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Bert Vermeulen , linux-kernel@vger.kernel.org References: <7dfad6c63cea64ccd84907f1cf9f7c9c6d1ce3e9.1649533972.git.sander@svanheule.net> From: Krzysztof Kozlowski In-Reply-To: <7dfad6c63cea64ccd84907f1cf9f7c9c6d1ce3e9.1649533972.git.sander@svanheule.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/04/2022 21:55, Sander Vanheule wrote: > Add the "realtek,rlt9300-gpio", "realtek,otto-gpio" compatible for GPIO > nodes on the RTL930x SoC series. This SoC requires an extra register > range, defining the interrupt CPU mapping registers. > > Signed-off-by: Sander Vanheule > --- > .../bindings/gpio/realtek,otto-gpio.yaml | 33 +++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml > index 100f20cebd76..3c511e9af377 100644 > --- a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml > @@ -28,10 +28,10 @@ properties: > - enum: > - realtek,rtl8380-gpio > - realtek,rtl8390-gpio > + - realtek,rtl9300-gpio > - const: realtek,otto-gpio > > - reg: > - maxItems: 1 > + reg: true > > "#gpio-cells": > const: 2 > @@ -50,6 +50,23 @@ properties: > interrupts: > maxItems: 1 > > +if: You could put it under allOf:, so if you ever need to extend it, you don't mess with the indentation, but it's fine as it is. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof