From: "Kryštof Černý" <cleverline1mc@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, Conor Dooley <conor@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Stefan Wahren <stefan.wahren@chargebyte.com>,
Ben Gardner <bgardner@wabtec.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property
Date: Thu, 21 Nov 2024 16:56:44 +0100 [thread overview]
Message-ID: <ee013b8f-5526-4f32-bde3-aaebfb49e4d0@gmail.com> (raw)
In-Reply-To: <48f0b74f-561b-4a5b-8311-e2cfddb92e3b@kernel.org>
Dne 21.11.2024 v 8:43 Krzysztof Kozlowski napsal(a):
> On 20/11/2024 23:53, Kryštof Černý wrote:
>> Hello,
>>
>>> On 20/11/2024 09:34, Kryštof Černý wrote:
>>>> Hello,
>>>>
>>>>> On Fri, Nov 15, 2024 at 03:58:06PM +0100, Kryštof Černý via B4 Relay wrote:
>>>>>> From: Kryštof Černý <cleverline1mc@gmail.com>
>>>>>>
>>>>>> Adds the newly added vcc-supply property to bindings.
>>>>>
>>>>> This commit message is a circular argument. You're adding it to the
>>>>> binding, which of course means it is newly added.
>>>>
>>>> You are right, I will replace with "Adds the vcc-supply property to
>>>> bindings." in the next version.
>>>
>>> No, please say why, e.g. because it was missing and device has it
>>> according to datasheet.
>>
>> Right, what about:
>>
>> Adds the optional vcc-supply property to bindings, informs if the device
>> needs a regulator to be turned on for its operation
>
> It does not inform at all. All devices needs power, don't they? And what
> operation?
This is probably the best I can do:
ds2482 has a VCC pin, accepting 2.9-5.5 V. Allow optionally specifying
a voltage regulator to power the chip.
If you don't find this satisfactory, please provide a suggestion.
> Best regards,
> Krzysztof
Thank you for your patience,
Kryštof Černý
next prev parent reply other threads:[~2024-11-21 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 14:58 [PATCH 0/3] Add support for attaching a regulator to w1: ds2482 Kryštof Černý via B4 Relay
2024-11-15 14:58 ` [PATCH 1/3] w1: ds2482: Add regulator support Kryštof Černý via B4 Relay
2024-11-15 14:58 ` [PATCH 2/3] w1: ds2482: Fix datasheet URL Kryštof Černý via B4 Relay
2024-11-15 14:58 ` [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property Kryštof Černý via B4 Relay
2024-11-15 18:16 ` Conor Dooley
2024-11-20 8:34 ` Kryštof Černý
2024-11-20 8:48 ` Krzysztof Kozlowski
2024-11-20 22:53 ` Kryštof Černý
2024-11-21 7:43 ` Krzysztof Kozlowski
2024-11-21 15:56 ` Kryštof Černý [this message]
2024-11-21 16:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee013b8f-5526-4f32-bde3-aaebfb49e4d0@gmail.com \
--to=cleverline1mc@gmail.com \
--cc=bgardner@wabtec.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stefan.wahren@chargebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox